Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Xue, Ying" <Ying.Xue@windriver.com>
To:     Jon Maloy <jon.maloy@ericsson.com>
CC:     David Miller <davem@davemloft.net>,
        "Bai, Haiqing" <Haiqing.Bai@windriver.com>,
        "Gao, Zhenbo" <Zhenbo.Gao@windriver.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tipc: fix issue that tipc_dest neglects of big-endian
Thread-Topic: [PATCH] tipc: fix issue that tipc_dest neglects of big-endian
Thread-Index: AQHUOPWO0Fgxj94ZzUmvikkEOFXOIKTKbNaA//+L+Vs=
Date:   Tue, 21 Aug 2018 09:57:25 +0000
Message-ID: <E0E1BFBA-FB75-4ACC-AAE1-14647A0BEA7F@windriver.com>
References: <1534760761-30206-1-git-send-email-Haiqing.Bai@windriver.com>
 <20180820.192031.1137174206399090141.davem@davemloft.net>,<DM5PR15MB1513428048EE31705DA273549A310@DM5PR15MB1513.namprd15.prod.outlook.com>
In-Reply-To: <DM5PR15MB1513428048EE31705DA273549A310@DM5PR15MB1513.namprd15.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Sorry, I am on vacation too. I agree with Jon. Please temporarily hold this patch. Once I am back, I will review it as soon as possible.

Sent from my iPhone

> On Aug 21, 2018, at 9:52 PM, Jon Maloy <jon.maloy@ericsson.com> wrote:
> 
> Hi David, 
> Please hold this one for now. 
> 
> ///jon
> 
>> -----Original Message-----
>> From: David Miller <davem@davemloft.net>
>> Sent: Monday, 20 August, 2018 22:21
>> To: Haiqing.Bai@windriver.com
>> Cc: Jon Maloy <jon.maloy@ericsson.com>; ying.xue@windriver.com; zhenbo.gao@windriver.com; netdev@vger.kernel.org; linux-
>> kernel@vger.kernel.org
>> Subject: Re: [PATCH] tipc: fix issue that tipc_dest neglects of big-endian
>> 
>> From: Haiqing Bai <Haiqing.Bai@windriver.com>
>> Date: Mon, 20 Aug 2018 18:26:01 +0800
>> 
>>> The tipc multicast demo in tipcutils fails to work on big-endian hardware.
>>> The tipc multicast server can not receive the packets sent by the multicast
>>> client for that the dest port is always zero after tipc_dest_pop, then it
>>> is found that the struct tipc_dest fails to take big/little endian into
>>> account.
>>> 
>>> Signed-off-by: Haiqing Bai <Haiqing.Bai@windriver.com>
>>> Signed-off-by: Zhenbo Gao <zhenbo.gao@windriver.com>
>> 
>> Jon and Ying, please review.
>> 
>> thank you.