Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp5103050imm; Tue, 21 Aug 2018 06:23:08 -0700 (PDT) X-Google-Smtp-Source: AA+uWPywSzidjMuXYlocEMbSHQx+XwlhuvQOWLhl0HoyV7vkpgOnrm0S2Qq/OGOat9RX+lW7rlTg X-Received: by 2002:a62:20d8:: with SMTP id m85-v6mr53194170pfj.74.1534857788668; Tue, 21 Aug 2018 06:23:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534857788; cv=none; d=google.com; s=arc-20160816; b=xveuDhUX0K1u7M/iJbjkqvxawPVodT5BqlUAu4yMXF8S2Sz/7HNYlfHbeuwk2ALyeK My2BcnDlV3vrhdUSRJfWtosbdSK3OngIY8DUc1U6oo9cSFUJQC/h7m0v56C1vb+N9ezk iIzs53uQ4DNUEORvv6GPDDPPY8sXOUzARgttOTfNGr5nQ3WKONyevpLsH8F3QoqaUO7c meIa2efpf1o3vQGwWSTre6/XOn37aq2xdIUT9yYcDFvfLL8v51NEx6EyNA6ice0I04wY eOCE5ejyItlaHu/zBifqDaQIQ2rgC+WZZFHD1DVeWiEAY9H5E+V+x9F1FHMfdnhuE81j 82fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=UooHrg65v9Xjhm50NUzXo1DgbgowCNYaMHRImhGxEEU=; b=iiiHJ54eetvtD7ru2F9Z25EH+cGjAxg+HsR59+1QOLAlpa+XOU2nEDvlsTmrOx1HVu +1WPmfw5n7cXKCYT9gs2GjTsl4ALNxrZQ3PweFAIgkzjh9UKtJwhERt+vUUJr9LKULOS IwSxsmiZPJelPuZewXLfyzgjrojR61pgC2F6iCoAD2EJsBOw8Ik5Nozb9r9K1+6LOTOr aVZ5fNGz0kxGf2lpg7r9+/unyeLzDUK7j/WBNnh14ku5Zz0rYhj8BMaf3npZmcq6U8ka MOlyewkkEt4t7pNY/wUGJzT8smvl86uDtptFvgwRuvcGBh//bfhrVLF+pVEOjFCmCFvW Zogw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z12-v6si11501411pgu.692.2018.08.21.06.22.53; Tue, 21 Aug 2018 06:23:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727680AbeHUQlx (ORCPT + 99 others); Tue, 21 Aug 2018 12:41:53 -0400 Received: from mail.skyhub.de ([5.9.137.197]:49892 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726907AbeHUQlw (ORCPT ); Tue, 21 Aug 2018 12:41:52 -0400 X-Virus-Scanned: Nedap ESD1 at mail.skyhub.de Received: from mail.skyhub.de ([127.0.0.1]) by localhost (blast.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id EvaJ79_dH0Hg; Tue, 21 Aug 2018 15:21:27 +0200 (CEST) Received: from nazgul.tnic (77-85-47-250.ip.btc-net.bg [77.85.47.250]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 13D531EC0330; Tue, 21 Aug 2018 15:21:25 +0200 (CEST) Date: Tue, 21 Aug 2018 15:21:41 +0200 From: Borislav Petkov To: "Ghannam, Yazen" Cc: "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "tony.luck@intel.com" , "x86@kernel.org" Subject: Re: [PATCH 1/2] x86/MCE/AMD: Check for NULL banks in THR interrupt handler Message-ID: <20180821132141.GF30528@nazgul.tnic> References: <20180809140834.59264-1-Yazen.Ghannam@amd.com> <20180809161548.GA20928@nazgul.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 16, 2018 at 07:00:43PM +0000, Ghannam, Yazen wrote: > So I think we should keep the NULL pointer checks for now to keep this fix > small. I can make a new patch following your suggestion above. > > We can change the code so that we create the data structures during the > earlier init process, but I think this will be a much bigger change. This could > fall under the idea of decoupling the handling code from sysfs. Ok, then pls add the simpler fixes at the beginning of the series so that they can go to stable and have the more involved changes follow them. Thx. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --