Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp5130364imm; Tue, 21 Aug 2018 06:49:05 -0700 (PDT) X-Google-Smtp-Source: AA+uWPxk9Qzuqu8QS9EHcTPj6Im0aRcOyLkXGl6tV+67CyelsX3Gy+yprWrEodRn/t27Ihek7ksQ X-Received: by 2002:a63:8241:: with SMTP id w62-v6mr8707502pgd.230.1534859345658; Tue, 21 Aug 2018 06:49:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534859345; cv=none; d=google.com; s=arc-20160816; b=sDU9kWLaQ8y3nIfkqmKNMpOj4O2UARsOao3KyKSdi+KP65eNhpI93dTQ1mmD+Zw/Xr CtZgFCY+mnpFt9QzVKnVkqvveJEMuXcevHmjjLubJvYQgiZDRVY732mYfyec56E7AEi1 cePI587z7jUAKY2cMLMnyy4A0rokAbwPgDvx6/SYrbWM+uMd6AjMIYk/H7rvan5qHJJu xslQluWH/ytw61fEJRsChDWj2ANW3RLEdTHZL/wzl01DcHbRfLiSdZHdM4IpJgNIqJYh nil081m2CvajiDipcIihYignEtUY1y0eR1jrGey1hlx4MTGjhnSLybXLu0T09qqjPFCd 3WaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:mime-version:user-agent:date:message-id :to:subject:from:dmarc-filter:dkim-signature:dkim-signature :arc-authentication-results; bh=4CAo3Z0W0QCYNrFVrp+5wLcsPXnbNo/1ib+ZWrom5Ak=; b=gf9ZYqB1g477FY7u80jdupXzZCRoE3DUhT51iZO0c6YX4jIgy5CNurGa0gtDjkuD3s KHczCh/VpWy2sAbqh6+/bq282aSifduwnpScbLGL9A/ffXIl+7QWO8e0S9mUadXVv6Ja FWEbidLZXJwlCCuJ33uwa0AgM61rW5HuaVBbr+yeK9NmuCEgCA1wqnTgUZbPWp2v9xlj ayO3O4uvWoCqUYH3e6STvmQ8E83FG2PkRJlae/L9bpdWAVvoXEeTx/OLv+LQCEG2Soe7 mt4dLU1vdrnaM46cJ8lU3+vfw9m37ppDI5o8cIOU1Kz0UaYoO5B4zLkV/Qixktgq7Qdt Kkiw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=MpKBvyQ5; dkim=pass header.i=@codeaurora.org header.s=default header.b=MpKBvyQ5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h11-v6si13374589plk.141.2018.08.21.06.48.48; Tue, 21 Aug 2018 06:49:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=MpKBvyQ5; dkim=pass header.i=@codeaurora.org header.s=default header.b=MpKBvyQ5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727086AbeHURHy (ORCPT + 99 others); Tue, 21 Aug 2018 13:07:54 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:45708 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726679AbeHURHy (ORCPT ); Tue, 21 Aug 2018 13:07:54 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 2CF5461474; Tue, 21 Aug 2018 13:47:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1534859261; bh=Fnc23PoxZMiv56ZKhJKK1tOqcdTPCEs1Iru4rFPU9qI=; h=From:Subject:To:Date:From; b=MpKBvyQ5camamXpPRNHh8iyHM8OIv9lVQLp1HdAH2FMQQqui3NtnVUwjSpoOQYhae JedQ+wcHApuo2zQTMRhP5ivG/lQQZdC7b9txC6ewYIsrXWWMTrGVRldnq719+ysyU9 4OVEMhvSWS52ge4k+UaBOggYavQh/lu8caLD68UQ= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from [10.204.79.100] (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mojha@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 10CB0612E0; Tue, 21 Aug 2018 13:47:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1534859261; bh=Fnc23PoxZMiv56ZKhJKK1tOqcdTPCEs1Iru4rFPU9qI=; h=From:Subject:To:Date:From; b=MpKBvyQ5camamXpPRNHh8iyHM8OIv9lVQLp1HdAH2FMQQqui3NtnVUwjSpoOQYhae JedQ+wcHApuo2zQTMRhP5ivG/lQQZdC7b9txC6ewYIsrXWWMTrGVRldnq719+ysyU9 4OVEMhvSWS52ge4k+UaBOggYavQh/lu8caLD68UQ= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 10CB0612E0 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=mojha@codeaurora.org From: Mukesh Ojha Subject: Query on skip_onerr field in struct cpuhp_step To: lkml , Thomas Gleixner Message-ID: Date: Tue, 21 Aug 2018 19:17:31 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi All, This is about one of field in struct cpuhp_step * @skip_onerr: Do not invoke the functions on error rollback  *              Will go away once the notifiers are gone         bool                    skip_onerr; Why this field was introduced, can anyone explain the history behind ? As i don't see it being set from anywhere If it is specifically was dependent on notifiers, did we missed to remove it as the notifiers are gone or the usecase still there? And If it is still valid, in what scenario i would not want my callback to be called in rollback path? Thanks, Mukesh