Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org F14F26145F
Subject: Re: Query on skip_onerr field in struct cpuhp_step
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     lkml <linux-kernel@vger.kernel.org>
References: <c228c495-63fa-5af9-32ff-355410d78cc8@codeaurora.org>
 <alpine.DEB.2.21.1808211557180.1535@nanos.tec.linutronix.de>
From:   Mukesh Ojha <mojha@codeaurora.org>
Message-ID: <a8599754-5c8b-1667-1685-901f53319064@codeaurora.org>
Date:   Tue, 21 Aug 2018 20:10:47 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.21.1808211557180.1535@nanos.tec.linutronix.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 8/21/2018 7:27 PM, Thomas Gleixner wrote:
> On Tue, 21 Aug 2018, Mukesh Ojha wrote:
>> Hi All,
>>
>> This is about one of field in struct cpuhp_step
>>
>> * @skip_onerr: Do not invoke the functions on error rollback
>>   *              Will go away once the notifiers are gone
>>          bool                    skip_onerr;
>>
>> Why this field was introduced, can anyone explain the history behind ? As i
>> don't see it being set from anywhere
>>
>> If it is specifically was dependent on notifiers, did we missed to remove it
>> as the notifiers are gone or the usecase still there?
> As the comment says....

Thanks for your reply
Sorry, for further question but i did not get the comment ..did you 
mean, we can remove this from the structure as notifier are
not their now. ?

Also if you are aware with the history, can you tell , why would i want 
to avoid a call in undo_cpu_up path?

Thanks,
Mukesh