Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp5206240imm; Tue, 21 Aug 2018 07:59:03 -0700 (PDT) X-Google-Smtp-Source: AA+uWPzLi7psZUtXtXWkDrU2vk//IB0ezGGX+gcYYOrUAhONy9vUj+fYKM/KOKtvvDoo1OdsXPGW X-Received: by 2002:a63:ed07:: with SMTP id d7-v6mr48334324pgi.429.1534863543444; Tue, 21 Aug 2018 07:59:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534863543; cv=none; d=google.com; s=arc-20160816; b=jLXW62stdMF/O/e291petqcQ07HOR5kG9DQ4bvzKdm0phtzRAYmI96JwObjAL6b19X JqR3+IPBz6nccQegvXclfesUUw1zkuWAwcJj0rOK3aT7/dWRE6helIl5Krz4kQz4DS7h 51nUolqrAyhgNbEAd7J20oeeIK47+fqysY6bpoNAwQMZkteend/R5r9DwGb1hyplAb+T Gkp1JYE5Fns5QZQJFrAeQGuSw4CYupD3r6Y4T1rKCCXYyqYev2oxcqoNqbV/r6VhnUMt eVbEeCq35plYE78dM9s9ddNqQPpy2uSsoKyzRZfWMYLHCYdZSU2NHeN8aItIXHyv1drV bTpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version:arc-authentication-results; bh=rLaxZsDNJ4NXirwnwYCTQjcRwMiQhnTYXFNTveiU4lc=; b=NQOvbw8CSMVVX6KEtXc0PKUwOnzLNOlIriWAnEHs7MT/7D/9WYMZHDVPe/GJuQrE2/ 4mSIsXonNuVam0NXjRk/R3lgalOuDH8Qgu0mauBGNtxP9ivuhCInOfUCPy7couprhQx3 SuhyN7qSCvXrOurC1GxqTa8/9/v6shV3TCd/N1vEFs3V9iz1jFW95HmWYLt18IyGopQT DNB89U5LyR39BTRaERAcu6CCBKod8A6ypel1TyrAK2AfZuA4ipCxb/12w7gsWbsO+wJ7 xHyMWmbk6xRxMHylUe3mcaw01lOh/VtQgxJyjegujuGBMltscoBEM1Kd0DRkL8AzaP9r 6xWQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u14-v6si12074866pgq.398.2018.08.21.07.58.48; Tue, 21 Aug 2018 07:59:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727752AbeHUSRn convert rfc822-to-8bit (ORCPT + 99 others); Tue, 21 Aug 2018 14:17:43 -0400 Received: from coyote.holtmann.net ([212.227.132.17]:38855 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726590AbeHUSRn (ORCPT ); Tue, 21 Aug 2018 14:17:43 -0400 Received: from [172.20.13.211] (unknown [94.75.125.194]) by mail.holtmann.org (Postfix) with ESMTPSA id B7211CF355; Tue, 21 Aug 2018 17:04:16 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: [PATCH] Bluetooth: mediatek: Fix memory leak From: Marcel Holtmann In-Reply-To: <20180814151031.GA25096@embeddedor.com> Date: Tue, 21 Aug 2018 16:57:11 +0200 Cc: Sean Wang , Johan Hedberg , Matthias Brugger , linux-bluetooth@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: References: <20180814151031.GA25096@embeddedor.com> To: "Gustavo A. R. Silva" X-Mailer: Apple Mail (2.3445.9.1) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Gustavo, > In case memory resources for *fw* were allocated, release them before > return. > > Addresses-Coverity-ID: 1472611 ("Resource leak") > Fixes: 7237c4c9ec92 ("Bluetooth: mediatek: Add protocol support for MediaTek serial devices") > Signed-off-by: Gustavo A. R. Silva > --- > drivers/bluetooth/btmtkuart.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) patch has been applied to bluetooth-stable tree. Regards Marcel