Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 21 Aug 2018 16:13:10 +0100
From:   Tony Finch <dot@dotat.at>
To:     Harshit Jain <harshitjain6751@gmail.com>
cc:     linux-kernel@vger.kernel.org, Tony Finch <dot@dotat.at>
Subject: Re: [PATCH] scripts: unifdef: fix stringop-truncation warning
In-Reply-To: <20180817202038.27257-1-harshitjain6751@gmail.com>
Message-ID: <alpine.DEB.2.20.1808211611110.3596@grey.csi.cam.ac.uk>
References: <20180817202038.27257-1-harshitjain6751@gmail.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Harshit Jain <harshitjain6751@gmail.com> wrote:

>  /* modify this line */
> -static void Mpass (void) { strncpy(keyword, "if  ", 4); Pelif(); }
> +static void Mpass (void) { memcpy(keyword, "if  ", 4); Pelif(); }

Yes, this is a good improvement, but you also need to update the comment
to match the code.

Tony.
-- 
f.anthony.n.finch  <dot@dotat.at>  http://dotat.at/
Wight, Portland, Plymouth: Westerly 3 or 4, occasionally 5 in north. Slight,
occasionally moderate. Drizzle, fog banks. Moderate, occasionally very poor.