Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <acb93bae0086447c7cbe0eec05907335ebae7788.camel@perches.com>
Subject: Re: [PATCH] compiler-gcc: get back Clang build
From:   Joe Perches <joe@perches.com>
To:     Nick Desaulniers <ndesaulniers@google.com>, asmadeus@codewreck.org
Cc:     Masahiro Yamada <yamada.masahiro@socionext.com>,
        Kees Cook <keescook@chromium.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Jonathan Corbet <corbet@lwn.net>,
        Arnd Bergmann <arnd@arndb.de>, dwmw@amazon.co.uk,
        LKML <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Will Deacon <will.deacon@arm.com>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Ingo Molnar <mingo@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>
Date:   Tue, 21 Aug 2018 09:45:28 -0700
In-Reply-To: <CAKwvOdmLQen+TWF_F3e5-66vtF3FEnoxjEgZbjmOZ9cv6YrEpA@mail.gmail.com>
References: <1534834088-15835-1-git-send-email-yamada.masahiro@socionext.com>
         <20180821123832.GA19034@nautica>
         <CAKwvOdmLQen+TWF_F3e5-66vtF3FEnoxjEgZbjmOZ9cv6YrEpA@mail.gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 2018-08-21 at 09:32 -0700, Nick Desaulniers wrote:
> On Tue, Aug 21, 2018 at 5:38 AM Dominique Martinet
> <asmadeus@codewreck.org> wrote:
> > 
> > Nick Desaulniers Aug. 21, 2018, 8:09 a.m. UTC:
> > > Thanks for noticing, and sending this patch.  I'm happy to see others
> > > testing with Clang.  I noticed this too near the end of the day
> > > https://github.com/ClangBuiltLinux/linux/issues/27.
> > 
> > FWIW libbcc so many BPF users also use clang, so this has more impact
> > than just testing to build linux with clang (not that this would be any
> > reason to delay fixing either way)
> > 
> > I would tend to agree havin a compiler-common + make clang/intel not
> > include compiler-gcc would probably be best in the long run but we might
> > want a quick fix for 4.19 meanwhile..
> 
> That's fair. SOP here is quick (full) revert, then come up with a
> better fix.  And I do prefer Masahiro's partial revert to a full
> revert of Joe's patch.  That will give us more time to develop the
> proper fix rather than rush.  I'll try to see how we can more properly
> split the compiler specific headers.
> 
> Tested with gcc-7 and clang-8.

clang-8? Isn't the latest officlal clang 6.0.1 ?

http://releases.llvm.org/

vs

https://clang.llvm.org/docs/ReleaseNotes.html

So if something other than 6.0.x is required,
then some additional check should probably be
added to compiler-clang.h as well.