Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp5357143imm; Tue, 21 Aug 2018 10:18:30 -0700 (PDT) X-Google-Smtp-Source: AA+uWPyMkxjIAZS61GgU8DcwX29Y2eSJ0M9rHXcS4UFVEXVc48kvEPIOrCZpZ9Pf1vRNObY9Aj7K X-Received: by 2002:a62:444d:: with SMTP id r74-v6mr53644389pfa.96.1534871910337; Tue, 21 Aug 2018 10:18:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534871910; cv=none; d=google.com; s=arc-20160816; b=hVbNrfr/gVqxejw97zgkDMh3GIPafmtqetmhS5d7L6OschK26KJjNqJseSQaArE/pM aGyp82K3DJ2SxhOGCtCWVkPrpaGYssjfwARGCEM7ZlnhNhsR2+pcz6hngDBRT1ESdSlR 2pEf3AsOthO41kJL1ul1lu8z9koRUWib/AfnX2UhuRBvvkaGW5nBR/BHl1ituQohpk+3 y4P0N/cyBdg77farbSJZcfJ9kjwtZfCuwsBxyTPRfEaDDOlMPOsvbIO/zx4116u2pvmk IVcypuRk3kzJJ2mWyAGvhA5nwUmAuugZrAHyrqRyim9vDYqK2s5aeeT3DpQ4oLvHODtQ bDhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=iwQ/smDAnK5772xDVEaqKTMbRiJWihZBNRzxKN6AErg=; b=Se1hl3NLWPMg+Lj2Sk8UCunOXmgYOZX2tfWM+Xa4sAzHC28eflNhEPesdm74y7hd23 +Un3o7lB+7ViXqSdvK30CuVMe5Sa+uZ4ts3lnZ7UWvMeAT0kkJnfcz/k+HIFU/54RhYi 3qbZQ+7Cp1OCSZu8n1SOGUiU+bJqBJFCTkMbT1zNugI+v2UyPVQo8FhGlOD973rYy2KL DsMz3HzTpo6e55Vmg48iOY0v20J+xmsPDwpfTQsmPhFiX/Vv9o7Kg8oiJA0DaLBXEgg9 UIMehbDyol6a3jQhoye7fIh2l5u2w0COoPdE3ju78zY8+xVeVawPaLK97igEiz0HrUMD 9vnA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="d/OfFIPB"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m11-v6si13131061pgk.468.2018.08.21.10.18.15; Tue, 21 Aug 2018 10:18:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="d/OfFIPB"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727735AbeHUUhC (ORCPT + 99 others); Tue, 21 Aug 2018 16:37:02 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:34613 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727602AbeHUUhC (ORCPT ); Tue, 21 Aug 2018 16:37:02 -0400 Received: by mail-wm0-f66.google.com with SMTP id l2-v6so10138556wme.1 for ; Tue, 21 Aug 2018 10:16:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=iwQ/smDAnK5772xDVEaqKTMbRiJWihZBNRzxKN6AErg=; b=d/OfFIPB9Us8iSOH8aGirIo/fz4WFWzW/R8pITSTQ/FUZzHiTknz9AdmKrWE5AZMkz UU3oMPwyB1OdMSBQeesgeaKub4IEITVevbPo1uHXcAu7uuS0F2vlGi7Mo6EbQNt0j6hl nmMdIN5qGuDVRs11870wdKgvgViUqCBgQIxIBggqx3Htsq5pLdivCOP8XFgGrcJIRz/9 TB2AOC7svGq3apVHbopRm+g6mAFKWYaXQitnNwc0GkYHhlv6IXPpoul9rCw+xk+f6k7Z 2nVgGUNboFtsKerN0hgJ1rXC3vy3zMQzPBSWrOkcplnOneCW8QS8mO9fYnPoft3YbD1i xvqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=iwQ/smDAnK5772xDVEaqKTMbRiJWihZBNRzxKN6AErg=; b=QBWgJc77nLFpZ4uED0/a+1cTCZZoQzBiEUm1gx3oX21+BK5H7Xp/B/UNysd9hIscDM MKuDySHtZ1o+DQYRiwmMc+/1YEOGkJdGTAe0c/BJJNgui7VOzMWHn8R0EDkEgH5sDok3 +7oDulXmTCTLb02j1YFYwEVWF/iqysFrJud6ZMqtfARJByW0weP1dl4QcIdZqMAk3daK KEew1nMAcgFtZXNuR2L16u0ebSy7lf+Z2FzCr+nIDesVqnnaPBqh2zL/GuKQ/eK7EJ6M 5oOkFyDdswxNluoLXcDhUVDDXCmNszbuGckyQcDx7X0tehg/r992KNCdNqiM/OZBWcwX VBVw== X-Gm-Message-State: APzg51BesodScwAKMuof7Rp5XSZVelHpcbJ+gCf1y4+grAUX4GUAEq8+ qU/cEKav4v5JH9pXw1uLFYWVVch+wIY= X-Received: by 2002:a1c:1f50:: with SMTP id f77-v6mr209694wmf.52.1534871759449; Tue, 21 Aug 2018 10:15:59 -0700 (PDT) Received: from localhost.localdomain (host86-148-21-150.range86-148.btcentralplus.com. [86.148.21.150]) by smtp.gmail.com with ESMTPSA id 88-v6sm7564292wrf.95.2018.08.21.10.15.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Aug 2018 10:15:58 -0700 (PDT) From: John Whitmore To: linux-kernel@vger.kernel.org Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, John Whitmore Subject: [PATCH 12/17] staging:rtl8192u: Rename bValid - Style Date: Tue, 21 Aug 2018 18:15:32 +0100 Message-Id: <20180821171537.9330-13-johnfwhitmore@gmail.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180821171537.9330-1-johnfwhitmore@gmail.com> References: <20180821171537.9330-1-johnfwhitmore@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Rename the member variable bValid to valid, this clears the checkpatch issue with CamelCase naming. This is a coding style change which should have no impatch on runtime code execution. Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/ieee80211_tx.c | 2 +- .../staging/rtl8192u/ieee80211/rtl819x_BA.h | 2 +- .../rtl8192u/ieee80211/rtl819x_BAProc.c | 22 +++++++++---------- 3 files changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c index a61e3805437d..a7850b04c81b 100644 --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c @@ -335,7 +335,7 @@ static void ieee80211_tx_query_agg_cap(struct ieee80211_device *ieee, printk("===>can't get TS\n"); return; } - if (!pTxTs->tx_admitted_ba_record.bValid) + if (!pTxTs->tx_admitted_ba_record.valid) { TsStartAddBaProcess(ieee, pTxTs); goto FORCED_AGG_SETTING; diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h b/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h index a36e8ecc6c59..9ec381c049aa 100644 --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h @@ -51,7 +51,7 @@ union delba_param_set { struct ba_record { struct timer_list timer; - u8 bValid; + u8 valid; u8 DialogToken; union ba_param_set BaParamSet; u16 BaTimeoutValue; diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c index 3e88333688ea..feac3cb371cd 100644 --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c @@ -18,7 +18,7 @@ ********************************************************************************************************************/ static void ActivateBAEntry(struct ieee80211_device *ieee, struct ba_record *pBA, u16 Time) { - pBA->bValid = true; + pBA->valid = true; if (Time != 0) mod_timer(&pBA->timer, jiffies + msecs_to_jiffies(Time)); } @@ -30,7 +30,7 @@ static void ActivateBAEntry(struct ieee80211_device *ieee, struct ba_record *pBA ********************************************************************************************************************/ static void DeActivateBAEntry(struct ieee80211_device *ieee, struct ba_record *pBA) { - pBA->bValid = false; + pBA->valid = false; del_timer_sync(&pBA->timer); } /******************************************************************************************************************** @@ -47,13 +47,13 @@ static u8 TxTsDeleteBA(struct ieee80211_device *ieee, struct tx_ts_record *pTxTs u8 bSendDELBA = false; // Delete pending BA - if (pPendingBa->bValid) { + if (pPendingBa->valid) { DeActivateBAEntry(ieee, pPendingBa); bSendDELBA = true; } // Delete admitted BA - if (pAdmittedBa->bValid) { + if (pAdmittedBa->valid) { DeActivateBAEntry(ieee, pAdmittedBa); bSendDELBA = true; } @@ -73,7 +73,7 @@ static u8 RxTsDeleteBA(struct ieee80211_device *ieee, struct rx_ts_record *pRxTs struct ba_record *pBa = &pRxTs->rx_admitted_ba_record; u8 bSendDELBA = false; - if (pBa->bValid) { + if (pBa->valid) { DeActivateBAEntry(ieee, pBa); bSendDELBA = true; } @@ -89,7 +89,7 @@ static u8 RxTsDeleteBA(struct ieee80211_device *ieee, struct rx_ts_record *pRxTs ********************************************************************************************************************/ void ResetBaEntry(struct ba_record *pBA) { - pBA->bValid = false; + pBA->valid = false; pBA->BaParamSet.short_data = 0; pBA->BaTimeoutValue = 0; pBA->DialogToken = 0; @@ -478,11 +478,11 @@ int ieee80211_rx_ADDBARsp(struct ieee80211_device *ieee, struct sk_buff *skb) // Check if related BA is waiting for setup. // If not, reject by sending DELBA frame. // - if (pAdmittedBA->bValid) { + if (pAdmittedBA->valid) { // Since BA is already setup, we ignore all other ADDBA Response. IEEE80211_DEBUG(IEEE80211_DL_BA, "OnADDBARsp(): Recv ADDBA Rsp. Drop because already admit it! \n"); return -1; - } else if ((!pPendingBA->bValid) || (*pDialogToken != pPendingBA->DialogToken)) { + } else if ((!pPendingBA->valid) || (*pDialogToken != pPendingBA->DialogToken)) { IEEE80211_DEBUG(IEEE80211_DL_ERR, "OnADDBARsp(): Recv ADDBA Rsp. BA invalid, DELBA! \n"); ReasonCode = DELBA_REASON_UNKNOWN_BA; goto OnADDBARsp_Reject; @@ -617,7 +617,7 @@ TsInitAddBA( { struct ba_record *pBA = &pTS->tx_pending_ba_record; - if (pBA->bValid && !bOverwritePending) + if (pBA->valid && !bOverwritePending) return; // Set parameters to "Pending" variable set @@ -647,7 +647,7 @@ TsInitDelBA(struct ieee80211_device *ieee, struct ts_common_info *pTsCommonInfo, ieee80211_send_DELBA( ieee, pTsCommonInfo->addr, - (pTxTs->tx_admitted_ba_record.bValid)?(&pTxTs->tx_admitted_ba_record):(&pTxTs->tx_pending_ba_record), + (pTxTs->tx_admitted_ba_record.valid)?(&pTxTs->tx_admitted_ba_record):(&pTxTs->tx_pending_ba_record), TxRxSelect, DELBA_REASON_END_BA); } else if (TxRxSelect == RX_DIR) { @@ -673,7 +673,7 @@ void BaSetupTimeOut(struct timer_list *t) pTxTs->add_ba_req_in_progress = false; pTxTs->add_ba_req_delayed = true; - pTxTs->tx_pending_ba_record.bValid = false; + pTxTs->tx_pending_ba_record.valid = false; } void TxBaInactTimeout(struct timer_list *t) -- 2.18.0