Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp132405imm; Wed, 22 Aug 2018 01:11:26 -0700 (PDT) X-Google-Smtp-Source: AA+uWPwouX+nNZis/YqWEQdZpEKdNbv7dR4hHqnUIlRTQNEnMlh9Lr7cjClQLDiv7JpbN1kJsIbb X-Received: by 2002:a63:4306:: with SMTP id q6-v6mr49923312pga.181.1534925486620; Wed, 22 Aug 2018 01:11:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534925486; cv=none; d=google.com; s=arc-20160816; b=0rD/P2uWP9ieRa5bpEnaxHcQGBBzfYjgMs6mIDlTiC/eo8yFKqQ7a7GV2Y3dL7vBD7 mKwCks6O49gaD4ct10HI6VRHe90rV3//t5ZBPRkdJ8tnyeMxFZylXkN9fhAUlwmjNAvo /kfeb/Fl063hOGOmSzrzbJgZdhaezM7Pm+cGt3zZtKoQV49a6oeidtFEaVIhK6Rxgi/x yLUfV0gz0lxSYpQC/8mq03iD9JdbLdY+W6l3w69me259ESla45o8xCAgwoJj6j4E90fQ mFTAuaICbu8F8DjXBM8CihahI2k0zIF/YAAcFMol9SqjIUcLRB6m1vtOpMrHBDkcBlyF GI4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=Oh+JTHfZak+RN9TiDBWj1KzrjzuUd57Pxh6xg8iIeZw=; b=H3jzBRQHckX2c0eqKuZT2ZDkGhbMF26Yn+jAQV1qlfqj3x3C2nctTZALQzxWuSIj7d 7PQlC7dL7IGYVIq4SqYLNxyl1rxV99pCaUrv1ZREKzPpEff8dGfHspO62uwsRtwFSOH3 QOvTM529KtwrJvBBcGwNyJEfgzP69qHlZcInBB2F/LKhXvrdt5ZFaZwngYBovwaAhZxX Qt9WZl6dRn3gBQzC/fsWxjnxJ3+Sn4I+z2YJjYL4eVl5HIWoBL90WooGd+YOIuXHXkpA B2u0yumQ/XSLjyjJg5A5fKVY9Bd2izjW66M7yijUYJecGF6jOk3GXUgsVg0Sds93f/CA G8Xg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cirrus.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r14-v6si1184798pfa.44.2018.08.22.01.11.10; Wed, 22 Aug 2018 01:11:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cirrus.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728386AbeHVLc5 (ORCPT + 99 others); Wed, 22 Aug 2018 07:32:57 -0400 Received: from mx0a-001ae601.pphosted.com ([67.231.149.25]:57082 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728302AbeHVLc4 (ORCPT ); Wed, 22 Aug 2018 07:32:56 -0400 Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w7M8980j027782; Wed, 22 Aug 2018 03:09:08 -0500 Authentication-Results: ppops.net; spf=none smtp.mailfrom=ckeepax@opensource.cirrus.com Received: from mail4.cirrus.com ([87.246.98.35]) by mx0a-001ae601.pphosted.com with ESMTP id 2kxgv1cwec-1; Wed, 22 Aug 2018 03:09:08 -0500 Received: from EX17.ad.cirrus.com (unknown [172.20.9.81]) by mail4.cirrus.com (Postfix) with ESMTP id E891E611C8A7; Wed, 22 Aug 2018 03:11:02 -0500 (CDT) Received: from imbe.wolfsonmicro.main (198.61.95.81) by EX17.ad.cirrus.com (172.20.9.81) with Microsoft SMTP Server id 14.3.408.0; Wed, 22 Aug 2018 09:09:06 +0100 Received: from imbe.wolfsonmicro.main (imbe.wolfsonmicro.main [198.61.95.81]) by imbe.wolfsonmicro.main (8.14.4/8.14.4) with ESMTP id w7M896Zq022135; Wed, 22 Aug 2018 09:09:06 +0100 Date: Wed, 22 Aug 2018 09:09:06 +0100 From: Charles Keepax To: CC: , , , Sapthagiri Baratam Subject: Re: [PATCH v2] mfd: arizona: Correct calling of runtime_put_sync Message-ID: <20180822080906.GR32322@imbe.wolfsonmicro.main> References: <5b7c2583.1c69fb81.c4b41.086e@mx.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <5b7c2583.1c69fb81.c4b41.086e@mx.google.com> User-Agent: Mutt/1.5.20 (2009-12-10) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=823 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1808220084 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 21, 2018 at 07:52:44PM +0530, sapthagiri.baratam@gmail.com wrote: > From: Sapthagiri Baratam > > Don't call runtime_put_sync when clk32k_ref is ARIZONA_32KZ_MCLK2 > as there is no corresponding runtime_get_sync call. > > MCLK1 is not in the AoD power domain so if it is used as 32kHz clock > source we need to hold a runtime PM reference to keep the device from > going into low power mode. > > fixes: cdd8da8cc66b ("mfd: arizona: Add gating of external MCLKn clocks") > Signed-off-by: Sapthagiri Baratam > --- Acked-by: Charles Keepax Thanks, Charles