Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp527692imm; Wed, 22 Aug 2018 08:13:58 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYU/irSo4TLoe2NWz9m65Ihw8HHkf/BFY6OP8N5OY8gFbQi6OaNYEHq47yGNBsGHkzq8P4Y X-Received: by 2002:a17:902:9045:: with SMTP id w5-v6mr758884plz.10.1534950838299; Wed, 22 Aug 2018 08:13:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534950838; cv=none; d=google.com; s=arc-20160816; b=eJXgPJTMpCJWgMcLYy40U8RdAHSjGvkMC376aD5V0taOkIWjomYBRV3+Tg1iuxGwGO XGSODTKR2mOr+QB/2ymV49u+cxtH5/kN/RPhOeqeVgBrn3gI83sW1m3QEEagvLIk96qu tO/D0EXTjK5CFIlvWHJBBhCu7FNpKq4w6uFZYGJhCfU6Zwj9E+jpYCIZhQ5Z9m3Hs1kd 0l+smmBWdppSU0OyWHshIXXpC9I+eRms3k8geb7NpNkNL1Vb6UJ5pUOciE8NowgJPI9b bJSrCqEvHY49pNKtgsIf/8dwsBNic4r6a2Ucz+hczE+XDqJyDv7fixmo9L715f2qStWB m71Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:references:cc:to:subject:from:arc-authentication-results; bh=Eoio2Za9h2Slvi/P+Gmrbc2iIuu1DzoMpkkzZB2q0sE=; b=hZbYNbG7f5xiS68SQwS4f5s2ichKzbRk7/gFtux4Rcj3zZNGPt5ey2pZ2QaItKV337 bXUJ36tvu+2PByRI8yMGYwGy/rmAwhavxFhIGdmkLWFewd9FdJc6xre25Cj2h+wF3fwU Hhar8ZUYlwr87kRpj9/KLahQYmTtiEZpPBNBIN3ffEbunIBuEMX/r1dbHqWTc9kI/isA uPtfzYibWBOzjCpGSQjQP0iJOP9eCjDcD+VCM2F8Ubh6KW4XVqxAM/82Sj2Thk9QOYE0 M9+/et5b+UW2bq74tTNvxPwCLjTDwhkk1gaoA+3iyPkvHQwJrhi8+3pFV9gSao3hF6BO XNxA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b1-v6si1776209plc.168.2018.08.22.08.13.42; Wed, 22 Aug 2018 08:13:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729287AbeHVSWE (ORCPT + 99 others); Wed, 22 Aug 2018 14:22:04 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:33964 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729273AbeHVSWE (ORCPT ); Wed, 22 Aug 2018 14:22:04 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 185FDED1; Wed, 22 Aug 2018 07:56:51 -0700 (PDT) Received: from [10.4.12.131] (e110467-lin.Emea.Arm.com [10.4.12.131]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3A5963F2EA; Wed, 22 Aug 2018 07:56:48 -0700 (PDT) From: Robin Murphy Subject: Re: [PATCH 0/4] numa, iommu/smmu: IOMMU/SMMU driver optimization for NUMA systems To: John Garry , Ganapatrao Kulkarni Cc: "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "iommu@lists.linux-foundation.org" , "linux-mm@kvack.org" , "Will.Deacon@arm.com" , "gklkml16@gmail.com" , "Tomasz.Nowicki@cavium.com" , "Robert.Richter@cavium.com" , "mhocko@suse.com" , "akpm@linux-foundation.org" , "vbabka@suse.cz" , "jnair@caviumnetworks.com" , Marek Szyprowski , "thunder.leizhen@huawei.com" , Linuxarm , Christoph Hellwig References: <20170921085922.11659-1-ganapatrao.kulkarni@cavium.com> <452f1665-eb3a-5e8c-f671-099ef4a15d84@huawei.com> Message-ID: Date: Wed, 22 Aug 2018 15:56:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <452f1665-eb3a-5e8c-f671-099ef4a15d84@huawei.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi John, On 22/08/18 14:44, John Garry wrote: > On 21/09/2017 09:59, Ganapatrao Kulkarni wrote: >> Adding numa aware memory allocations used for iommu dma allocation and >> memory allocated for SMMU stream tables, page walk tables and command >> queues. >> >> With this patch, iperf testing on ThunderX2, with 40G NIC card on >> NODE 1 PCI shown same performance(around 30% improvement) as NODE 0. >> >> Ganapatrao Kulkarni (4): >> ? mm: move function alloc_pages_exact_nid out of __meminit >> ? numa, iommu/io-pgtable-arm: Use NUMA aware memory allocation for smmu >> ??? translation tables >> ? iommu/arm-smmu-v3: Use NUMA memory allocations for stream tables and >> ??? comamnd queues >> ? iommu/dma, numa: Use NUMA aware memory allocations in >> ??? __iommu_dma_alloc_pages >> >> ?drivers/iommu/arm-smmu-v3.c??? | 57 >> +++++++++++++++++++++++++++++++++++++----- >> ?drivers/iommu/dma-iommu.c????? | 17 +++++++------ >> ?drivers/iommu/io-pgtable-arm.c |? 4 ++- >> ?include/linux/gfp.h??????????? |? 2 +- >> ?mm/page_alloc.c??????????????? |? 3 ++- >> ?5 files changed, 67 insertions(+), 16 deletions(-) >> > > Hi Ganapatrao, > > Have you any plans for further work on this patchset? I have not seen > anything since this v1 was posted+discussed. Looks like I ended up doing the version of the io-pgtable change that I suggested here, which was merged recently (4b123757eeaa). Patch #3 should also be effectively obsolete now since the SWIOTLB/dma-direct rework (21f237e4d085). Apparently I also started reworking patch #4 in my tree at some point but sidelined it - I think that was at least partly due to another thread[1] which made it seem less clear-cut whether this is always the right thing to do. Robin. [1] https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1693026.html