Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp584389imm; Wed, 22 Aug 2018 09:07:35 -0700 (PDT) X-Google-Smtp-Source: AA+uWPwSaUq9bDE8rlf9G+eLA0yhnnS6iflfHcvFSaZGGLuc+xWdFh6es5+w1b2Qz70k+6fHXieG X-Received: by 2002:a62:8d16:: with SMTP id z22-v6mr59153460pfd.181.1534954055822; Wed, 22 Aug 2018 09:07:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534954055; cv=none; d=google.com; s=arc-20160816; b=LsYA2wlcvSGBJOrgQV/CIbQItyFz4wX/2nqUk/+RH+rwBuAAbtp0nzVjQl04pjDzQv ro2D/x9B0r/vQOijeOTvlyFbY+S2/m5HjdM8uo96AxfOZRAEL+vQWCMXTqi6vQeTIQRb DQbogJMPEHqz+fpXOrp99BYV9lZ2ivN1ydYqMM+x2CGLUEvAn3MMyPf0MPVC2W11iz1P +F0GUx5cm4FgndIXPoiFRcxpPj0kWjN7jHmJEOvDPZJHOrOdvIGhtgKPqIiX3QgyQ+tD hWjlYkrVEWJLOQC+wGnzRlbhKKsieqrrOqrHHwb/0l0w9xQpC69HUtcuLHD9UqhWC97R Wm1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=RFS9d38ZVoCo6FbVONVURvIYznwdAhIjJeGRhAxKE+U=; b=GhTUNO5kruZRsFv3orw+wqG1do7dhGjmMV85O910cNIpn6Ike8H02voLBCl/RExwTB orTQBMG3iWVWIKzARoWUwcTsgGdRLFWckWR9zQQQ6IQspud7/KAcSdLxxrpzvem9SW6c wnB6R7OT/iRYosm+LidJxb7w6fLB1gx5HMPM812hVyklJOps6f6YLrDLMx+Kn8XTjlgq f066g+cKR+K7IqN3AS/7qB/s8GWuxreehXiGYy5MDOK5WHE/DRORkBuMrKgaYB/LAmzi 9GFrEYIRFygF5qp12QXhnwU4O2gp6n9I2Y0B4bQeOssKAwurQP7VN8scsA7x/Xy9R71b nEnQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e4-v6si2020503pgp.147.2018.08.22.09.07.20; Wed, 22 Aug 2018 09:07:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726847AbeHVTbW (ORCPT + 99 others); Wed, 22 Aug 2018 15:31:22 -0400 Received: from mx2.suse.de ([195.135.220.15]:33444 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726812AbeHVTbW (ORCPT ); Wed, 22 Aug 2018 15:31:22 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 4C0F6AED3; Wed, 22 Aug 2018 16:05:52 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 189F21E361C; Wed, 22 Aug 2018 18:05:51 +0200 (CEST) Date: Wed, 22 Aug 2018 18:05:51 +0200 From: Jan Kara To: Jeremy Cline Cc: Jan Kara , linux-kernel@vger.kernel.org, Josh Poimboeuf Subject: Re: [PATCH 1/2] fs/quota: Replace XQM_MAXQUOTAS usage with MAXQUOTAS Message-ID: <20180822160551.GE23037@quack2.suse.cz> References: <20180731013731.1987-1-jcline@redhat.com> <20180731013731.1987-2-jcline@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180731013731.1987-2-jcline@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 31-07-18 01:37:30, Jeremy Cline wrote: > XQM_MAXQUOTAS and MAXQUOTAS are, it appears, equivalent. Replace all > usage of XQM_MAXQUOTAS and remove it along with the unused XQM_*QUOTA > definitions. > > Signed-off-by: Jeremy Cline Thanks for the cleanup. The patch looks good, just one small nit: > diff --git a/include/uapi/linux/dqblk_xfs.h b/include/uapi/linux/dqblk_xfs.h > index 03d890b80ebc..a5846cde8272 100644 > --- a/include/uapi/linux/dqblk_xfs.h > +++ b/include/uapi/linux/dqblk_xfs.h > @@ -27,11 +27,6 @@ > #define XQM_CMD(x) (('X'<<8)+(x)) /* note: forms first QCMD argument */ > #define XQM_COMMAND(x) (((x) & (0xff<<8)) == ('X'<<8)) /* test if for XFS */ You can delete XQM_COMMAND() as well here. > -#define XQM_USRQUOTA 0 /* system call user quota type */ > -#define XQM_GRPQUOTA 1 /* system call group quota type */ > -#define XQM_PRJQUOTA 2 /* system call project quota type */ > -#define XQM_MAXQUOTAS 3 > - > #define Q_XQUOTAON XQM_CMD(1) /* enable accounting/enforcement */ > #define Q_XQUOTAOFF XQM_CMD(2) /* disable accounting/enforcement */ > #define Q_XGETQUOTA XQM_CMD(3) /* get disk limits and usage */ Honza -- Jan Kara SUSE Labs, CR