Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp631916imm; Wed, 22 Aug 2018 09:53:33 -0700 (PDT) X-Google-Smtp-Source: AA+uWPzUJvg4rM1cjlq4xxNV2GSH6AqpBo05vzENufU4RH6SBpTpXbb4NdvdTivZZfEVQsD1Eflp X-Received: by 2002:a17:902:44c:: with SMTP id 70-v6mr14254689ple.125.1534956813431; Wed, 22 Aug 2018 09:53:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534956813; cv=none; d=google.com; s=arc-20160816; b=rBAGXvSQ8KWgeDeX8qadQJ17CiPQj0WCmKUT9KkqGV5HY6pnLrMUrZKeZ3qYmV0Tdi EG0aPuagxOyd6D/REBGIvccQWU7zr46+LV4gZyri3eODbGVkaLNVhX4opm7G91we+Wix ADfY21kFz0nIF4+lcVe7HH85TYU7YskDfvxjUApidXXEFGBDUfpI60aoTN/uFljeqg8G ZXMlyntJAmOdHC34gH6F/EQj2JYFjwLSa669K4ZoMDHbLUUxusY/TVRcsx6ymBlmRdaG cWJc+aics1WMO2Mr3+/4AwUWUv3oOUlWYB8FlUUSeqVpGui9KCGKmAO0prPAXYNcswB3 iETw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:references:in-reply-to:date :subject:cc:to:from:arc-authentication-results; bh=GzysghsCkTciTBa2nFvtZh/2mjfAn5zwSZHu60/JxdY=; b=OlO4yPJIYjvRFPMCOcG7blrlKbbu8pY2BPI8ns2Mq3B2qhv1hA4rbZbRyjPvcImk3W R1/W/oF/F+vpaA31IU75SCPre28byTTUj81ifYqWIjxcHcCZkoSXWesn/e3nRpsamJny TgTrlM3Pjq7C7zdM8X7cHWWzL52txvwc6LtEJEPzOLodthsDJqq875af3e2NjQ6oJOiG z7N5lItjZO5p6r0GELkdxuxc87Y+y+ufcsNmY2LDJXDq2ZusYMpH5NWyvh24IbgwpzPD PeSli4lBrZbdrSwc/OZHe2O5X4A/BBjFuwpaPFhDTmusg1LnWAfwne5MBSGJ9IIDDdYP mz3w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z128-v6si2095996pgb.185.2018.08.22.09.53.18; Wed, 22 Aug 2018 09:53:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727455AbeHVURs (ORCPT + 99 others); Wed, 22 Aug 2018 16:17:48 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:44190 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727391AbeHVURs (ORCPT ); Wed, 22 Aug 2018 16:17:48 -0400 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w7MGmfDQ111237 for ; Wed, 22 Aug 2018 12:52:09 -0400 Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com [195.75.94.103]) by mx0a-001b2d01.pphosted.com with ESMTP id 2m1avuabdg-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 22 Aug 2018 12:52:09 -0400 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 22 Aug 2018 17:52:07 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp07.uk.ibm.com (192.168.101.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 22 Aug 2018 17:52:05 +0100 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w7MGq39n39649474 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 22 Aug 2018 16:52:03 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 85EF6AE051; Wed, 22 Aug 2018 19:51:41 +0100 (BST) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 33BBBAE04D; Wed, 22 Aug 2018 19:51:41 +0100 (BST) Received: from morel-ThinkPad-W530.boeblingen.de.ibm.com (unknown [9.152.224.111]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 22 Aug 2018 19:51:41 +0100 (BST) From: Pierre Morel To: david@redhat.com Cc: linux-kernel@vger.kernel.org, cohuck@redhat.com, linux-s390@vger.kernel.org, kvm@vger.kernel.org, frankja@linux.ibm.com, akrowiak@linux.ibm.com, borntraeger@de.ibm.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com Subject: [PATCH v2 4/5] KVM: s390: vsie: Always test the crycbd for NULL Date: Wed, 22 Aug 2018 18:51:56 +0200 X-Mailer: git-send-email 2.7.4 In-Reply-To: <1534956717-14087-1-git-send-email-pmorel@linux.ibm.com> References: <1534956717-14087-1-git-send-email-pmorel@linux.ibm.com> X-TM-AS-GCONF: 00 x-cbid: 18082216-0028-0000-0000-000002EE436D X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18082216-0029-0000-0000-000023A78613 Message-Id: <1534956717-14087-5-git-send-email-pmorel@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-08-22_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=699 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1808220169 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org BUG: the crycbd must be tested for null even if not crossing a page boundary (which will never occur in this case anyway). Signed-off-by: Pierre Morel --- arch/s390/kvm/vsie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/s390/kvm/vsie.c b/arch/s390/kvm/vsie.c index 0b12916..7ee4329 100644 --- a/arch/s390/kvm/vsie.c +++ b/arch/s390/kvm/vsie.c @@ -172,7 +172,7 @@ static int shadow_crycb(struct kvm_vcpu *vcpu, struct vsie_page *vsie_page) if ((crycb_addr & PAGE_MASK) != ((crycb_addr + 128) & PAGE_MASK)) return set_validity_icpt(scb_s, 0x003CU); - else if (!crycb_addr) + if (!crycb_addr) return set_validity_icpt(scb_s, 0x0039U); /* copy only the wrapping keys */ -- 2.7.4