Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 22 Aug 2018 23:36:58 +0200
From:   Sebastian Reichel <sre@kernel.org>
To:     Johan Hovold <johan@kernel.org>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Frank Rowand <frowand.list@gmail.com>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        stable <stable@vger.kernel.org>, NeilBrown <neilb@suse.de>,
        Felipe Balbi <balbi@ti.com>
Subject: Re: [PATCH 9/9] power: supply: twl4030-charger: fix OF sibling-node
 lookup
Message-ID: <20180822213658.uuzsalnlxbayc4ml@earth.universe>
References: <20180822105547.9634-1-johan@kernel.org>
 <20180822105547.9634-10-johan@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="kfx3tqsq374xuhtg"
Content-Disposition: inline
In-Reply-To: <20180822105547.9634-10-johan@kernel.org>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--kfx3tqsq374xuhtg
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Wed, Aug 22, 2018 at 12:55:47PM +0200, Johan Hovold wrote:
> Use the new of_get_compatible_child() helper to lookup the usb sibling
> node instead of using of_find_compatible_node(), which searches the
> entire tree and thus can return an unrelated (non-sibling) node.
>=20
> This also addresses a potential use-after-free (e.g. after probe
> deferral) as the tree-wide helper drops a reference to its first
> argument (i.e. the parent device node).
>=20
> While at it, also fix the related phy-node reference leak.
>=20
> Fixes: f5e4edb8c888 ("power: twl4030_charger: find associated phy by more=
 reliable means.")
> Cc: stable <stable@vger.kernel.org>     # 4.2
> Cc: NeilBrown <neilb@suse.de>
> Cc: Felipe Balbi <balbi@ti.com>
> Cc: Sebastian Reichel <sre@kernel.org>
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---

Reviewed-by: Sebastian Reichel <sre@kernel.org>

-- Sebastian

>  drivers/power/supply/twl4030_charger.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/power/supply/twl4030_charger.c b/drivers/power/suppl=
y/twl4030_charger.c
> index bbcaee56db9d..b6a7d9f74cf3 100644
> --- a/drivers/power/supply/twl4030_charger.c
> +++ b/drivers/power/supply/twl4030_charger.c
> @@ -996,12 +996,13 @@ static int twl4030_bci_probe(struct platform_device=
 *pdev)
>  	if (bci->dev->of_node) {
>  		struct device_node *phynode;
> =20
> -		phynode =3D of_find_compatible_node(bci->dev->of_node->parent,
> -						  NULL, "ti,twl4030-usb");
> +		phynode =3D of_get_compatible_child(bci->dev->of_node->parent,
> +						  "ti,twl4030-usb");
>  		if (phynode) {
>  			bci->usb_nb.notifier_call =3D twl4030_bci_usb_ncb;
>  			bci->transceiver =3D devm_usb_get_phy_by_node(
>  				bci->dev, phynode, &bci->usb_nb);
> +			of_node_put(phynode);
>  			if (IS_ERR(bci->transceiver)) {
>  				ret =3D PTR_ERR(bci->transceiver);
>  				if (ret =3D=3D -EPROBE_DEFER)
> --=20
> 2.18.0
>=20

--kfx3tqsq374xuhtg
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAlt913cACgkQ2O7X88g7
+pqSrhAAgJWkbj4ZZr0TfSV4uMcPbTetTFIezbONmXZrVGme1CcgxsR7F36fJT+M
JSSj5+MyASYbc7O9eLRThkq3t05SHu7jf9WdV8pwEgHdHLJPGalIrWpmK5i4SxOc
d4m/S075tKYqTQEo2tMNzsdQAMBMU+2QYDc/Q5aBEW73Iyqww098rMZsgPEykF9q
G4Mk3gpu/GY46W6grbQKLWPpBX3bN5lRM/5Vz9rbZGj39AUqAnAWHmZU24USTnVg
AjOcZZ3kyZqRx+Lu5dpqhzmpsD5g7ZQ3DrYzJqZvlCvPC1gn+L9FbXKwuubMHbZ2
qhC6vwWNNGry/OwnfsbGNcWweX2O3JN7aWFgTSnpRGvAQeZB1GF7GIJG966oLpwW
11lGN5G0qqf+6e5OhCPs1oCM1n9i2en6Env65bIBOp3Pe0VHr58UcLs/7EFa7Mu6
5bOFFfCqr65XtHw5lm0LLRAy8XDLhHKFF7eLj6zCiKeafdxW4Ey/H9ACW48GpybB
1cQzWtYueiqDeCtrVYPBEtZPuNSp6R6pvsDGu/AFV/tjkVRP6F2IuM2LWlYC5YKB
zwEA87iPBp6trkSoc0b495FAbKkc6/hl44wVTzPip6p9ZEraGOFpzQLWl5wAMN43
ambgNNO72a6H+QTnYcpnKt78RwzAYIBugyOG4V+9wL69YK8iOZs=
=FeKy
-----END PGP SIGNATURE-----

--kfx3tqsq374xuhtg--