Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1191427imm; Wed, 22 Aug 2018 21:41:22 -0700 (PDT) X-Google-Smtp-Source: AA+uWPy61gRQSipnCdLd74YUopBHc9k0kdL+LDGeA4efrZuv5Pq/TZR5i8CsKbKF0bAuPyaOJDUc X-Received: by 2002:a62:8acd:: with SMTP id o74-v6mr61037375pfk.12.1534999281946; Wed, 22 Aug 2018 21:41:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534999281; cv=none; d=google.com; s=arc-20160816; b=sJvhe2gaqlAB53ixHMIVqIHVOQtz3ZVS3u03wwM+0ozwpYJhQlMBBQLVdQc9dSCpT6 lrwmQT9IOWSSVjuiMbU7VTfOfDKAeD2YRPxOPOugOyueOPGPBqSP8q3OszixMSKSAvfM vKVbPUn2pJ93M8tkrPQfcHP01n6qpr6ljCoUIYr/N0m0fVSlF65Pmt/lZItM0PyB/w94 Js5w4g62CAwUkH8P+pMYNTIA6OdldqF9/pETllnCESgqHMaDIxLW0/G0ao3lHNv9eTIt P3pdwj3Un8PML6UY6jR4dXRkj4KPtzoGhfq2vKsQ3AkoER3+aQE5YOSrIQqE1mlOEqes 3Rdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=cte3x8Qe9E+JNIE2/IBjlvV/VDjPKClq99/Jv/6afE8=; b=WV6LyWth38Y18yV2ZkbGpSZffHdz/exYChvPePuyFAMjvKNjBJW9/WTM07XsTOVX2v /BWrvBd6wwuvfd9+2DjcIwYxv2cLRRuxV5GcJSdLTBFb0OWC+LSfSaZofTykNL9iJNml SdxQA3uAEqbSMAqZfi1RjKG38iemGmui5xsOeWU2+1wS/vg/3G3DA6eOOky4xY/hiWuI dFibN0N+G5mkrXHoNbfTMIIcdXbz9QxEmmjFiG91MKnWtucaY0Y3bXnRK8d46ygMHYch d+Y2chz31SHvUX0ftf+joQqe123ywABYenW3yNmzw+oI3VtXe4Ptd09nORShEOwItgNE iJKg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f62-v6si4059962pfb.218.2018.08.22.21.41.06; Wed, 22 Aug 2018 21:41:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728433AbeHWIHL (ORCPT + 99 others); Thu, 23 Aug 2018 04:07:11 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:41534 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728121AbeHWIHK (ORCPT ); Thu, 23 Aug 2018 04:07:10 -0400 Received: from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net [74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 60492100A2000; Wed, 22 Aug 2018 21:39:25 -0700 (PDT) Date: Wed, 22 Aug 2018 21:39:24 -0700 (PDT) Message-Id: <20180822.213924.602801295731723249.davem@davemloft.net> To: sam@mendozajonas.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org Subject: Re: [PATCH net] net/ncsi: Fixup .dumpit message flags and ID check in Netlink handler From: David Miller In-Reply-To: <20180822045744.9267-1-sam@mendozajonas.com> References: <20180822045744.9267-1-sam@mendozajonas.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 22 Aug 2018 21:39:25 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Samuel Mendoza-Jonas Date: Wed, 22 Aug 2018 14:57:44 +1000 > The ncsi_pkg_info_all_nl() .dumpit handler is missing the NLM_F_MULTI > flag, causing additional package information after the first to be lost. > Also fixup a sanity check in ncsi_write_package_info() to reject out of > range package IDs. > > Signed-off-by: Samuel Mendoza-Jonas Applied.