Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1275862imm; Wed, 22 Aug 2018 23:41:39 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZ9b+aDbKVrcoxDSOOXbVqB+g13B5zXwvGuiT5pAqKvhacY2U6zVIoHdCo89iby+6+EX6vK X-Received: by 2002:a62:384a:: with SMTP id f71-v6mr10208830pfa.48.1535006499491; Wed, 22 Aug 2018 23:41:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535006499; cv=none; d=google.com; s=arc-20160816; b=tzM/I2U7Esq5vHM1jkK0/tCEHVK8VyV6iQXohotosoJ54duPZtCAvlZEA04fCu0peC CkBFcZGUFlM10MSfip6MbwKPR8htEaYvOWVcnQXVHr7AiRGKc81D0AEt6Gpwmlh1yjZo 5DmqEawAlAmGEuDZxShWmpl6FVm+/jYb1+47TMQBEDb3gdDwx4ph/5np7g/gwF6OBVO0 F8uG8XbctpoTsSHq3Gimm9WpE4jh/FesVTYW76mvz5CclD2WgAgZNNo2Omgen5FcQTMm Jxy6vmEVsfFXhQncd6sOtr2JWlegPaEoe+NeDmEdUVMoAeoSbBzSpkxvJS5UqiZU0LFl t/eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date:from :references:cc:to:subject:reply-to:arc-authentication-results; bh=ZdHeOmuUkprxKpbJtCGVjeQkweoo5sgbTpzn8H6AcCU=; b=SL0alZ7i/lnWYrx0VWD1XYNkAAGSCWQ+zv4rFMlzBDz51oMflp6pO5A+Qy8QaJMmoZ jxDFQkQPHf3DeMlxcuCMf8HJIloR/e/pxEPswxlWH2m92WhP1IzQAp29JwIn4u2rakiB uziuFTc8KeUygzMLy7XoWUyJURyayP/ZytDbMj33iAzdZlCPbRNSi1nl7Oy+eggflGT+ kmcvTusdaa5zyF7OBkNjmjn4SNoloikOC8PFUONZXjdSfVjZKW95gEeLtmn86g09izzm eJueg8OrnZWRdiBvz+1/yO4HnVd5UkrVmT/0qLk2+YH2GdU25jhyW6aTKQSlMGjwDPvx 0qHA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w11-v6si3410513plz.333.2018.08.22.23.41.23; Wed, 22 Aug 2018 23:41:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726285AbeHWKIZ (ORCPT + 99 others); Thu, 23 Aug 2018 06:08:25 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:44016 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726075AbeHWKIZ (ORCPT ); Thu, 23 Aug 2018 06:08:25 -0400 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w7N6d1ck125873 for ; Thu, 23 Aug 2018 02:40:17 -0400 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0a-001b2d01.pphosted.com with ESMTP id 2m1qt8g51x-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 23 Aug 2018 02:40:17 -0400 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 23 Aug 2018 07:40:15 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 23 Aug 2018 07:40:11 +0100 Received: from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com [9.149.105.60]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w7N6e9pY44499186 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 23 Aug 2018 06:40:09 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CCA5842042; Thu, 23 Aug 2018 09:40:10 +0100 (BST) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5FE7D42041; Thu, 23 Aug 2018 09:40:10 +0100 (BST) Received: from [9.152.224.92] (unknown [9.152.224.92]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 23 Aug 2018 09:40:10 +0100 (BST) Reply-To: pmorel@linux.ibm.com Subject: Re: [PATCH v2 1/5] KVM: s390: vsie: BUG correction by shadow_crycb To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, cohuck@redhat.com, linux-s390@vger.kernel.org, kvm@vger.kernel.org, frankja@linux.ibm.com, akrowiak@linux.ibm.com, borntraeger@de.ibm.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com References: <1534956717-14087-1-git-send-email-pmorel@linux.ibm.com> <1534956717-14087-2-git-send-email-pmorel@linux.ibm.com> <8300634d-8500-1898-e283-175fc893054a@redhat.com> From: Pierre Morel Date: Thu, 23 Aug 2018 08:40:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <8300634d-8500-1898-e283-175fc893054a@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 18082306-0020-0000-0000-000002BA87FF X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18082306-0021-0000-0000-00002107E1AC Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-08-23_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1808230070 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/08/2018 18:53, David Hildenbrand wrote: > On 22.08.2018 18:51, Pierre Morel wrote: >> Copy the key mask to the right offset inside the shadow CRYCB >> >> Signed-off-by: Pierre Morel >> Reviewed-by: David Hildenbrand >> --- >> arch/s390/kvm/vsie.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/arch/s390/kvm/vsie.c b/arch/s390/kvm/vsie.c >> index 9175518..12b9707 100644 >> --- a/arch/s390/kvm/vsie.c >> +++ b/arch/s390/kvm/vsie.c >> @@ -173,7 +173,8 @@ static int shadow_crycb(struct kvm_vcpu *vcpu, struct vsie_page *vsie_page) >> return set_validity_icpt(scb_s, 0x0039U); >> >> /* copy only the wrapping keys */ >> - if (read_guest_real(vcpu, crycb_addr + 72, &vsie_page->crycb, 56)) >> + if (read_guest_real(vcpu, crycb_addr + 72, >> + vsie_page->crycb.dea_wrapping_key_mask, 56)) >> return set_validity_icpt(scb_s, 0x0035U); >> >> scb_s->ecb3 |= ecb3_flags; >> > > Please fixup the subject as requested. (were there more RB-s?) > Yes, sorry, will do. No no other RB yet. -- Pierre Morel Linux/KVM/QEMU in Böblingen - Germany