Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: v4.19-rc0: compile problem in ./include/media/cec.h:82:24:
To:     Pavel Machek <pavel@ucw.cz>, hans.verkuil@cisco.com,
        mchehab+samsung@kernel.org,
        kernel list <linux-kernel@vger.kernel.org>
References: <20180822204426.GA23832@amd> <20180822211212.GA30897@amd>
From:   Hans Verkuil <hansverk@cisco.com>
Message-ID: <2412c578-637b-547a-aa20-79a5dc33a94c@cisco.com>
Date:   Thu, 23 Aug 2018 08:38:15 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.7.0
MIME-Version: 1.0
In-Reply-To: <20180822211212.GA30897@amd>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 22/08/18 23:12, Pavel Machek wrote:
> Hi!
> 
>> I'm getting this in -rc0:
>>
>>   CC      drivers/gpu/drm/ttm/ttm_tt.o
>>   In file included from ./include/media/cec-notifier.h:13:0,
>>                    from drivers/gpu/drm/i915/intel_drv.h:42,
>> 		                    from
>>   drivers/gpu/drm/i915/i915_trace.h:11,
>>                    from drivers/gpu/drm/i915/i915_drv.h:2667,
>> 		                    from
>>   drivers/gpu/drm/i915/i915_irq.c:36:
>>   ./include/media/cec.h:82:24: error: ‘CEC_EVENT_PIN_5V_HIGH’
>>   undeclared here (not in a function)
>>    #define CEC_NUM_EVENTS CEC_EVENT_PIN_5V_HIGH
>>                            ^
>> 			   ./include/media/cec.h:94:26: note: in
>>   expansion of macro ‘CEC_NUM_EVENTS’
>>     struct list_head events[CEC_NUM_EVENTS]; /* queued events */
>>                               ^
>>  CC      drivers/input/serio/serport.o
>>
>> Reverting 4786b0d6f3ca6da8db02b0a58cd2b785cb0b80ab seems to help.
> 
> No, sorry, it does not. I was confused. Let me try
> 
> HDMI CEC support (MEDIA_CEC_SUPPORT) [N/y/?] (NEW) y
> 
> No change.
> 
> Let me add
> 
> #include <uapi/linux/cec.h>
> 
> into include/media/cec.h... no.
> 
> Any ideas?
> 								Pavel
> 

media/cec.h includes linux/cec-funcs.h which includes linux/cec.h. This last
header defines CEC_EVENT_PIN_5V_HIGH.

If it doesn't for some reason, then you have some broken tree since it definitely
is there if I look at the current mainline kernel.

Regards,

	Hans