Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1334335imm; Thu, 23 Aug 2018 01:01:02 -0700 (PDT) X-Google-Smtp-Source: AA+uWPzZP2EWFBsE/YKalrh3QXjx3P1IH3NSGocJihzSOjyybfP0dubgeBIgpgvh+ZgcB50AEmz7 X-Received: by 2002:a62:9c17:: with SMTP id f23-v6mr61780548pfe.209.1535011262391; Thu, 23 Aug 2018 01:01:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535011262; cv=none; d=google.com; s=arc-20160816; b=pZeEJwLHZt+H3h1APe+i7oXa7H6qexHB1vRJKnijCvD8P09nNDtZ6HA1rRxzNl6WLP A51wTfly84vaU/LhzaoNUR6olThcR+Ok55jKR8fB02VXgNp7CTnT+p5XTHTZnri9IDOV u891VTZ2fJtfw75fqb2hF41xJxw+YQDK9wkmhhUyg0+F902kKiRO1Hd/zhQ+SFnV/xXe ct2klQViuscRguM8CynomT72VTV4wDBtPKOhIgNRm4MPMOhBE39J9l0LAk7gx5XBbS0Q n8sk0OVGPVtXwJzviPMeM6DdzfbuCPe8QApwmTnGA8O2DfAeWksrIkzUhfZq5aVK6/fP h3Lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=Od58ZyukAHufrNTVJDyGDg07k4Eu8mIveWenYQUuYUo=; b=kyM5H2Eg6dgOF+unHkKSAmW8MfOf4lkmPm3wCVPJO/zFR/JyPGy7Mmx8s9K5Bh6fe6 tedX3uwdY86Q2oQm6vBKUgXmDEaEgg8XWXiBDteJcXCW1uMxrnJMsP22CpHWHUdTpdpv TSXxSCUzn3224yjvhCMGc8gp6mYDmV8luEOgrNsdCZzBIilI6qVqPkomxb4oYFBQkXue xrvawyUSWVO7ZqKLnPZuwu175VqvVW4ynNoC60E5tzc0gUKtFdyU/2D89txF4Y0mfYVo zONEv65/i1FgVTFKmxj/fNdvEaYkk+rrc/gXED8jnbrRYz6YRYfKAZrca4s6KVAL8tv9 ATbA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l5-v6si4093453pff.304.2018.08.23.01.00.47; Thu, 23 Aug 2018 01:01:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728277AbeHWL1V (ORCPT + 99 others); Thu, 23 Aug 2018 07:27:21 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:41914 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726978AbeHWL1V (ORCPT ); Thu, 23 Aug 2018 07:27:21 -0400 Received: from localhost (5355525A.cm-6-6b.dynamic.ziggo.nl [83.85.82.90]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 7D4FDBB6; Thu, 23 Aug 2018 07:58:57 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yuiko Oshino , "David S. Miller" , Sasha Levin Subject: [PATCH 4.4 44/79] smsc75xx: Add workaround for gigabit link up hardware errata. Date: Thu, 23 Aug 2018 09:53:20 +0200 Message-Id: <20180823074921.997805359@linuxfoundation.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180823074918.641878835@linuxfoundation.org> References: <20180823074918.641878835@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yuiko Oshino [ Upstream commit d461e3da905332189aad546b2ad9adbe6071c7cc ] In certain conditions, the device may not be able to link in gigabit mode. This software workaround ensures that the device will not enter the failure state. Fixes: d0cad871703b898a442e4049c532ec39168e5b57 ("SMSC75XX USB 2.0 Gigabit Ethernet Devices") Signed-off-by: Yuiko Oshino Signed-off-by: David S. Miller Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/net/usb/smsc75xx.c | 62 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 62 insertions(+) --- a/drivers/net/usb/smsc75xx.c +++ b/drivers/net/usb/smsc75xx.c @@ -81,6 +81,9 @@ static bool turbo_mode = true; module_param(turbo_mode, bool, 0644); MODULE_PARM_DESC(turbo_mode, "Enable multiple frames per Rx transaction"); +static int smsc75xx_link_ok_nopm(struct usbnet *dev); +static int smsc75xx_phy_gig_workaround(struct usbnet *dev); + static int __must_check __smsc75xx_read_reg(struct usbnet *dev, u32 index, u32 *data, int in_pm) { @@ -840,6 +843,9 @@ static int smsc75xx_phy_initialize(struc return -EIO; } + /* phy workaround for gig link */ + smsc75xx_phy_gig_workaround(dev); + smsc75xx_mdio_write(dev->net, dev->mii.phy_id, MII_ADVERTISE, ADVERTISE_ALL | ADVERTISE_CSMA | ADVERTISE_PAUSE_CAP | ADVERTISE_PAUSE_ASYM); @@ -978,6 +984,62 @@ static int smsc75xx_wait_ready(struct us return -EIO; } +static int smsc75xx_phy_gig_workaround(struct usbnet *dev) +{ + struct mii_if_info *mii = &dev->mii; + int ret = 0, timeout = 0; + u32 buf, link_up = 0; + + /* Set the phy in Gig loopback */ + smsc75xx_mdio_write(dev->net, mii->phy_id, MII_BMCR, 0x4040); + + /* Wait for the link up */ + do { + link_up = smsc75xx_link_ok_nopm(dev); + usleep_range(10000, 20000); + timeout++; + } while ((!link_up) && (timeout < 1000)); + + if (timeout >= 1000) { + netdev_warn(dev->net, "Timeout waiting for PHY link up\n"); + return -EIO; + } + + /* phy reset */ + ret = smsc75xx_read_reg(dev, PMT_CTL, &buf); + if (ret < 0) { + netdev_warn(dev->net, "Failed to read PMT_CTL: %d\n", ret); + return ret; + } + + buf |= PMT_CTL_PHY_RST; + + ret = smsc75xx_write_reg(dev, PMT_CTL, buf); + if (ret < 0) { + netdev_warn(dev->net, "Failed to write PMT_CTL: %d\n", ret); + return ret; + } + + timeout = 0; + do { + usleep_range(10000, 20000); + ret = smsc75xx_read_reg(dev, PMT_CTL, &buf); + if (ret < 0) { + netdev_warn(dev->net, "Failed to read PMT_CTL: %d\n", + ret); + return ret; + } + timeout++; + } while ((buf & PMT_CTL_PHY_RST) && (timeout < 100)); + + if (timeout >= 100) { + netdev_warn(dev->net, "timeout waiting for PHY Reset\n"); + return -EIO; + } + + return 0; +} + static int smsc75xx_reset(struct usbnet *dev) { struct smsc75xx_priv *pdata = (struct smsc75xx_priv *)(dev->data[0]);