Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1335167imm; Thu, 23 Aug 2018 01:01:46 -0700 (PDT) X-Google-Smtp-Source: AA+uWPyadpPAnt5b2RSkFsUQ9/DIMgxWoZcXTGPjJ0mQJCS0Sai1T7MUfd1U36+V5aTZZC3t3wSC X-Received: by 2002:a63:4e25:: with SMTP id c37-v6mr54456304pgb.6.1535011306213; Thu, 23 Aug 2018 01:01:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535011306; cv=none; d=google.com; s=arc-20160816; b=x1lalAa69Y88HTSWTnq/Ss+mDM0w46haGaXzmAjH+F1eWHlhK67ceRUE1bbBxU/2kq jFDX0VfEYR6IiW+F9dSdBNaCavhYRSR1NkAQa1q/WHQUoSYBkKkB0lCHcC+azcwPj2df R2vVOSLOMCQ/o0G4SYCrrvTlY2r8Mp+qbwC+2WZ4+t/4sQvVySpF3M+IzO0o0+K6SnX0 ywHtqDHjiDyQ9wGVaXxQizgMHAWtR+9xnuFZ1xnDS99gpvg5uXfeCr75bIcp8WwNGcCK sdFysh5lvW25yckfLwP7Pn8aHx2fjKMUaMopymXg42zyWtlutUCppAY3W1XvTT6wb/ae XB7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=AXssUW8hcdCkHA3AJKvD7W+wucszMYYKOMa/jBy8ZIY=; b=NJ1SNwTW3X+KCoiELcoVULLnKMGg8hx5CP2w6sBMLHVnXS5YwSuMq45j93ryC819mM BBeaVImLJjR7N7KNp/QpaFY8pBBO/ZDxyBdfH9vJOSFf1kg8W6LZwxDdAPiv1SV3dQ5l mbCa2bGfut2liqLgNwhVlBVdHbM8cfDYvnebhTC4ZXrwKPI1FQ/iAcomrv4Bf7VWifDh XxJRbA6lib1oKp4K6C5JdA7J2bgS9L4Ygyz8PvBLJ+0x9E4gRJ5WPEQ7WNGjkVL+zkc5 nenAg5UIB1/oVYPftpdIB7cokVeGCJQmyo/47x/0mWjP8LBvKjncu8S0lFjNKEZV9L4v 4A3w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z33-v6si3806325plb.323.2018.08.23.01.01.30; Thu, 23 Aug 2018 01:01:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728341AbeHWL1a (ORCPT + 99 others); Thu, 23 Aug 2018 07:27:30 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:41960 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726978AbeHWL1a (ORCPT ); Thu, 23 Aug 2018 07:27:30 -0400 Received: from localhost (5355525A.cm-6-6b.dynamic.ziggo.nl [83.85.82.90]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 1CA24BB6; Thu, 23 Aug 2018 07:59:06 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Stefan Schmidt , Sasha Levin Subject: [PATCH 4.4 47/79] ieee802154: at86rf230: switch from BUG_ON() to WARN_ON() on problem Date: Thu, 23 Aug 2018 09:53:23 +0200 Message-Id: <20180823074922.172707485@linuxfoundation.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180823074918.641878835@linuxfoundation.org> References: <20180823074918.641878835@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Stefan Schmidt [ Upstream commit 20f330452ad8814f2289a589baf65e21270879a7 ] The check is valid but it does not warrant to crash the kernel. A WARN_ON() is good enough here. Found by checkpatch. Signed-off-by: Stefan Schmidt Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/net/ieee802154/at86rf230.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/ieee802154/at86rf230.c +++ b/drivers/net/ieee802154/at86rf230.c @@ -932,7 +932,7 @@ at86rf230_xmit(struct ieee802154_hw *hw, static int at86rf230_ed(struct ieee802154_hw *hw, u8 *level) { - BUG_ON(!level); + WARN_ON(!level); *level = 0xbe; return 0; }