Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1335256imm; Thu, 23 Aug 2018 01:01:52 -0700 (PDT) X-Google-Smtp-Source: AA+uWPwwW8t38jmhnJ28M9HZBY+M5aA3aBN5wuC+uhZjRkao9qyr0GCzU21aVGQNpf6hdcj8pSKb X-Received: by 2002:a17:902:b70f:: with SMTP id d15-v6mr50140800pls.53.1535011312123; Thu, 23 Aug 2018 01:01:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535011312; cv=none; d=google.com; s=arc-20160816; b=1CJghkrXDQx0cBC+fV6LKSUBXgWEceBFX/1dLSO7VvO3JMMIgE1XP/AFzH+gvNgG4i uMzzVgb5RI28cTgUNWk1fAa7zwYuf8LXN6ZD/qL6SheMysl7K9HWKMATwz/hv2w0nEoc kC9c4jZ5MSkiBekGZ2UXXsNtlesn+pw8lQ8k7xUPh2p44t+a3heDWHKmCXoULdxvFzPx QAFM17tFdav5hnYGeTw567xp2ktgNyQ7c82EpBt0c0kPH+htB97mPXtXXQkB5mqYeTaY owvji6x2D9T5oWkjKaUF578dsIPx4yS/vI6wohhHVO0vH09zcGLpXHUFWWw5ZtncXFBw n9sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=ob+UpGhZGRHk3FsOVBxtJm44/+rjCuiQ87rJFsBNqE0=; b=ogt2rE8BgJfY5pYcvyw/8O6c3bVZYgW61cRtrIOBqNHNYdmAY1meu/gz82ly7/2MrO DSdqkwPCi3ypxKGi/kgQ4tbkzbK8azcNpL5o6NuGnqVORo3cEdBIQXanyWNMu0qMNgbI F5Vt07OaUhu2As2gjgJBprn1HDRGXHe891O+IIK5OlIL3dXzxjrzD96D3oMdyVdo5Fq9 t0vjWJ7uws7/dY2djv1t9IfU99Y8dqFa3eArNGjn0YpzJF6tINF4tet28C7w8BCrjOGY QMfYR8UV10YyZ7xpuLUak8m1T2Hlq14L7hvAFmmEi8KpUGvnzU3K8RWxXYr3XJtaJQ7l epeA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c6-v6si3589032plr.32.2018.08.23.01.01.36; Thu, 23 Aug 2018 01:01:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728382AbeHWL1h (ORCPT + 99 others); Thu, 23 Aug 2018 07:27:37 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:41978 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726836AbeHWL1g (ORCPT ); Thu, 23 Aug 2018 07:27:36 -0400 Received: from localhost (5355525A.cm-6-6b.dynamic.ziggo.nl [83.85.82.90]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 8212D9D2; Thu, 23 Aug 2018 07:59:13 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Stefan Schmidt , Sasha Levin Subject: [PATCH 4.4 49/79] ieee802154: fakelb: switch from BUG_ON() to WARN_ON() on problem Date: Thu, 23 Aug 2018 09:53:25 +0200 Message-Id: <20180823074922.305236961@linuxfoundation.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180823074918.641878835@linuxfoundation.org> References: <20180823074918.641878835@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Stefan Schmidt [ Upstream commit 8f2fbc6c60ff213369e06a73610fc882a42fdf20 ] The check is valid but it does not warrant to crash the kernel. A WARN_ON() is good enough here. Found by checkpatch. Signed-off-by: Stefan Schmidt Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/net/ieee802154/fakelb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/ieee802154/fakelb.c +++ b/drivers/net/ieee802154/fakelb.c @@ -49,7 +49,7 @@ struct fakelb_phy { static int fakelb_hw_ed(struct ieee802154_hw *hw, u8 *level) { - BUG_ON(!level); + WARN_ON(!level); *level = 0xbe; return 0;