Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1800247imm; Thu, 23 Aug 2018 08:58:34 -0700 (PDT) X-Google-Smtp-Source: AA+uWPzXJTqLHWzG0hl6Dy/fQgwQsOLcjc9SWSF99ZFEzaKjrm6Ni4NV/6GUaRuaAWZ6Q9AxVwlo X-Received: by 2002:a62:455b:: with SMTP id s88-v6mr62832316pfa.203.1535039914603; Thu, 23 Aug 2018 08:58:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535039914; cv=none; d=google.com; s=arc-20160816; b=jSlUDClY9KQ6wGMj7FW9SIKpKwljww4xST2lURDoh+8lp0nlwme6WtEDU4Z/o2Xu5s rFUMrahe5+6f4oAauRc2STD0/7AT23lJQN5j4xAx0ZWYCAJpa3RF0YkHBWsGom06b6jT BIvbcUPks4gGzF1minZGBqkM+m3V1Yjqhr9sQ9koIOCBe7vIIBiGSJq0pnmPsV5SVvjm KL3WqRa82PLxl0p96v213d0jDwaj/0wofvVvUFQjlWIbxgpa+83YX2NhY9Bpb/AgJWm3 kXxP8hQX34bbQXIjeM6MSupXEufhf9l6F70+6dHGpZhNhIPugreYnCi3aKJb+7P+Zr3j XgMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=P3N3DBK3VNoIGYhW3QfC7L5w0EWAO81rS0MW1fX/+e8=; b=BreB37cMtKvXl9dG6HqKvsbQNyQraicqLzBk5IuQuiHrt/8y/Ws/ow7Je1K9xGxTEc kvfaUT5LoByM2O32aXjjzRzCiV8yO6v+egMlFH8ZhwGsvDZ/AZb+8cpUjHT+0BMow/tT RcR/Yq101Q2XlAt9Fjj8Dsr5iVtenLYn3xq5rMC7Z+md+x1PXIDrHA+FKumvQTStoBf3 xx9JtMEEbH8NPEnlmVCa8zmG8VwHvUxK6uvYXhFKom2/Bomz819aFvuGd0g7OLqBG17g pz7FJZlfem48vKd9FIG77BeKhAy3Gjime8SQATMmc7X+LVJv4c8qhfTmQE1S3ZJ7/PbA C19w== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=UGYfwAfT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k13-v6si4581221pgg.346.2018.08.23.08.58.18; Thu, 23 Aug 2018 08:58:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=UGYfwAfT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729948AbeHWNUS (ORCPT + 99 others); Thu, 23 Aug 2018 09:20:18 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:42700 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726325AbeHWNUR (ORCPT ); Thu, 23 Aug 2018 09:20:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=P3N3DBK3VNoIGYhW3QfC7L5w0EWAO81rS0MW1fX/+e8=; b=UGYfwAfTu3XfaMfpYMuNjYx+L cw2XSmwOMkLageq9GqCoGDqKZZJ/iNC/XWc+x5wReP5It1V5+8n1hS66MK++ts+ama5KqjeXnLTHQ 4rt92I7tuPAYU8hx1uLMCfLRdHBrCnCLEOGCvRoSLxsXhzVu/MXJBeFDKSf/PxlP7yBIY=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=debutante.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpa (Exim 4.89) (envelope-from ) id 1fsmGi-0007G7-2t; Thu, 23 Aug 2018 09:51:08 +0000 Received: by debutante.sirena.org.uk (Postfix, from userid 1000) id 906491124604; Thu, 23 Aug 2018 10:51:07 +0100 (BST) Date: Thu, 23 Aug 2018 10:51:07 +0100 From: Mark Brown To: Dmitry Torokhov Cc: ryans.lee@maximintegrated.com, Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Kuninori Morimoto , "alsa-devel@alsa-project.org" , lkml , ryan.lee.maxim@gmail.com Subject: Re: [PATCH] ASoC: max98373: Added 10ms delay after amp software reset Message-ID: <20180823095107.GA5207@sirena.org.uk> References: <20180823001519.20056-1-ryans.lee@maximintegrated.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="PNTmBPCT7hxwcZjr" Content-Disposition: inline In-Reply-To: X-Cookie: Truth is free, but information costs. User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --PNTmBPCT7hxwcZjr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Aug 22, 2018 at 05:31:04PM -0700, Dmitry Torokhov wrote: > On Wed, Aug 22, 2018 at 5:21 PM Ryan Lee wrote: > > + mdelay(10); > Is it really necessary for the CPU to spin for 10msec here? > usleep_range() would be better solution. Or msleep() for that matter, it's not going ot be the end of the world if we delay a bit too long. --PNTmBPCT7hxwcZjr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlt+g4oACgkQJNaLcl1U h9BrhQf/Zim+9StJ1iLMas05ZDR6IOmI8Vk166JzDc5Cl04crEzXRGtkjTjIPszh nO5s0JhVanRN0I2RXQvD1nXHDeXIAOt88susgnBH86u7HFLGO471NnvZW/R7W8JD hMUNwL3RfbRAMbkGA11dlvU/pQ/Q7nAE4NPmMIBS5Z3W3ZIb3yIXeEAO7osAtAbU 5ggStp5ly2w8A2kPEsDVuaYTDKPloD2DP+9QWl8b3c1N9PD5+kAFjGEgNR+7o3A8 cCw9zFfpkQekbYQHqsVw8iV2tWJClPqNvtwl2qbq35/MeMbfnaePaFVWDe/jBE93 LiB34dB+w7sqy1wv9Ahq+zUra29Lfg== =Jim1 -----END PGP SIGNATURE----- --PNTmBPCT7hxwcZjr--