Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1802507imm; Thu, 23 Aug 2018 09:00:37 -0700 (PDT) X-Google-Smtp-Source: AA+uWPy2dTaRmmiHUA6oeB9gWF0IRM6rxbJOZk/FzMJ8ocTIWmXzoNe0urak9Vhz++vxLOSJyl+L X-Received: by 2002:a17:902:1566:: with SMTP id b35-v6mr58725779plh.135.1535040037531; Thu, 23 Aug 2018 09:00:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535040037; cv=none; d=google.com; s=arc-20160816; b=OoTmG1kP6pgfDQ87ubyboMElNNLRky5IpKEKsRSv0XnvJF895YM7bf49l8R+YcQ4Pz jpp24hWMjvzHy7mapW9fCsGY5DFJShmzkFT6Koo9FZZq+bdnpm9x32cFbjS7xddavxUA 5eD6al32XhpCKF2rANKOSIj/vDq+HrOiVdJrPd7vZ/z+9b7daz6JmHuBZcfZ/x1H0AEW oi1jFzLp8tiJMA+GGlJd7JnF+O00n0gcQUeIVECeeOdgEWuLYb6V69wMFGgkPffWgwyj DhMkkRDOXW0FAS6cXk0l2hc1drQ4fohkAzZs6rn9Ic3NjoqwXt4J/80h+1YVRzXKPy/q +2Ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=fODfQuiHBLMcztzm+pp1axzpbGBMbaK/f1um0+yom84=; b=Mz8UgnLWgKnI7Mizj4qXPC7HdrLYRUy+6p8OsXCo8AFcVUOK6vUvQ5IMFWnevFfMKz Qm/2e59WEmSCAc2LaEhUA2Ul+711hoQr/JrMONEj10EfzXmozMrnbAHqBuIj/Dn6Cx8Q aWScHTpe5mzkR0JuN/EnoQu37NQUBBf7Bvh/Pu4lAX7m+dysZewywS8ePzDE6Gy7z9Dn E2xIDAYem+kXpUqvTmZZwBGLyw4a1BKcXfyhvq5rOOcYbNybcHffiwX4C+VDF8NxFh7o hVUIVTZ/Au3CU4l+0q9NwYIZAMToCnprAqgTGGZUFAeWFV6ZaAjadTm/kWH+wccqexPn /9iw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=vIdobQvP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 71-v6si5371820pfa.305.2018.08.23.09.00.22; Thu, 23 Aug 2018 09:00:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=vIdobQvP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730267AbeHWNuZ (ORCPT + 99 others); Thu, 23 Aug 2018 09:50:25 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:36588 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727356AbeHWNuZ (ORCPT ); Thu, 23 Aug 2018 09:50:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=fODfQuiHBLMcztzm+pp1axzpbGBMbaK/f1um0+yom84=; b=vIdobQvPAXdIZXqu36u0tcBbe XxA9RLRwVGXS9lnl7cca6XPT8/OUFmHoNZBnAW1V7MGO9fL5qgRmLaMm5gpyJxRE+4BgtxhWZcIj6 S/FdYvf5WF29+nMfUJsEbY90/YRrOfsBlrXUAZT0hAtBLd204sT5olVMOLNm9UsKifwhg=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=debutante.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpa (Exim 4.89) (envelope-from ) id 1fsmjx-0007IM-LD; Thu, 23 Aug 2018 10:21:21 +0000 Received: by debutante.sirena.org.uk (Postfix, from userid 1000) id 527591124604; Thu, 23 Aug 2018 11:21:21 +0100 (BST) Date: Thu, 23 Aug 2018 11:21:21 +0100 From: Mark Brown To: Kirill Kapranov Cc: Geert Uytterhoeven , linux-spi@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH -next] spi: Fix double IDR allocation with DT aliases Message-ID: <20180823102121.GC5207@sirena.org.uk> References: <20180821095303.27664-1-geert+renesas@glider.be> <35fbd3ae-3ac3-f6ef-874b-3d99c4d4d29a@compulab.co.il> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ctP54qlpMx3WjD+/" Content-Disposition: inline In-Reply-To: <35fbd3ae-3ac3-f6ef-874b-3d99c4d4d29a@compulab.co.il> X-Cookie: Truth is free, but information costs. User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ctP54qlpMx3WjD+/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Aug 22, 2018 at 08:51:40PM +0300, Kirill Kapranov wrote: Please don't top post, reply in line with needed context. This allows readers to readily follow the flow of conversation and understand what you are talking about and also helps ensure that everything in the discussion is being addressed. > I have to point at the following threat: a dynamically allocated ID may > 'squat' a bus ID that intended for a device with statically allocated ID. > This scenario is possible since module loading order is uncertain. > This threat seems to be inevitable... For DT systems the dynamically allocated IDs start at the maximum positive ID and work down so in practice it is vanishingly unlikely that there will be a collision as idiomatic static DT IDs would be low integers. --ctP54qlpMx3WjD+/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlt+iqAACgkQJNaLcl1U h9DEYwf+PeNSBmBQJsoTnSeUanFKW3zKsRohegEb3DegJ5Rmq6PL5PLV7V6KhWTU UGRz17Z0DB70xLyzs4sUPC/6L4xCw4fYMYLBulUIzFWKQlmGFKsGzfx4E8VY7pN5 Izw0MFPUnrKsT84C8m1k3PWaa4qprvBRKnAUKCBQZnzGz80ZLE1T7nsb05szBQKx NRYobSv124dL9aomXEywmcSWk22T+8eRb6OEPPQ/DxHPZfdxHMkb4ehMhPUFz7wb K2m9P5zaEKN1cTM8aNWoRSRmh92Y626DH6/WmmwtBfX3ppcDXoPImwnI4qeb12P2 dzP36/20rWtDmkVlLeaBPlZMSr7LcA== =9h9Y -----END PGP SIGNATURE----- --ctP54qlpMx3WjD+/--