Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   David Laight <David.Laight@ACULAB.COM>
To:     'Michal Hocko' <mhocko@kernel.org>, Weikang Shi <swkhack@gmail.com>
CC:     "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "alexander.h.duyck@intel.com" <alexander.h.duyck@intel.com>,
        "vbabka@suse.cz" <vbabka@suse.cz>,
        "mgorman@suse.de" <mgorman@suse.de>,
        "l.stach@pengutronix.de" <l.stach@pengutronix.de>,
        "vdavydov.dev@gmail.com" <vdavydov.dev@gmail.com>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "my_email@gmail.com" <my_email@gmail.com>
Subject: RE: [PATCH] fs: fix local var type
Thread-Topic: [PATCH] fs: fix local var type
Thread-Index: AQHUOtKgUsSAnLeal0y8ska0EIofcaTNMUuQ
Date:   Thu, 23 Aug 2018 11:23:35 +0000
Message-ID: <b66e21d0f55b4f568c81bb9d5d22b7a7@AcuMS.aculab.com>
References: <1535014754-31918-1-git-send-email-swkhack@gmail.com>
 <20180823111355.GD29735@dhcp22.suse.cz>
In-Reply-To: <20180823111355.GD29735@dhcp22.suse.cz>
Accept-Language: en-GB, en-US
Content-Language: en-US
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Michal Hocko
> Sent: 23 August 2018 12:14
> 
> On Thu 23-08-18 01:59:14, Weikang Shi wrote:
> > In the seq_hex_dump function,the remaining variable is int, but it receive a type of size_t
> argument.
> > So I change the type of remaining
> 
> The changelog should explain _why_ we need this fix. Is any of the code
> path overflowing?
> 
> Besides that I do not think this fix is complete. What about linelen?
> 
> Why do we even need len to be size_t? Why it cannot be int as well. I
> strongly doubt we need more than 32b here.

Although you may well want 'unsigned int' to avoid the sign extension
instruction that gets added for x86_64 when a signed int is added
to a pointer.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)