Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1836438imm; Thu, 23 Aug 2018 09:31:35 -0700 (PDT) X-Google-Smtp-Source: AA+uWPxjIaMZ5l2zyDOwcT9P+Kebre+r4EMkVGFNUbEqP6S3wdWlBW3eae88QVXs5gD5UWZyKzsU X-Received: by 2002:a17:902:28a4:: with SMTP id f33-v6mr58974075plb.297.1535041895395; Thu, 23 Aug 2018 09:31:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535041895; cv=none; d=google.com; s=arc-20160816; b=fwpdcF7rX1UMHeIahnZvMds/89hyFKFxnGd+9kl5OJgSCQ/ljOGfM2CXaZe9m9Elx1 OyBdMxK1Ervevbvs2Ras8VFSWxQEJ9hnnPvxseS5v/x2kfpeo9yj9J2zv3H7+XibkBm2 0o8X8cs36oFdEnBr81/6vepEiAB4f9j7tMViM6a6XSdIKxFRcvA/cG8rS5cAjvuMqlnD 2YU8q3h42xfA56YJI/uZDSJSF81YSs6aMJplo3axGjtw0E6z4sAhxHXNIKjQ/QQFaEMN 5bfbBVZ1lAqTvbdzms2QvOxMQafM87FICBENWrXT4lrk+tNdc6rs7o7KS19gjYtgIeKQ G0/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=U6eTt6ZYBTue3kzpbrJdTVTz8nAxFQ9vgRhLQRP3Df8=; b=TNYZU173PX1Dvc7wrcPBN6s5zJKKUQZ06abY7TaMzvHUjxqkFzup4Dkik2VuJRQY+/ +rnhgGoc8W3Vk+irVqrYSNSiofDJPVNcrRFQrp9YpEhEi54Nle7QFc331Bs5C0spKv7h DcOdBrwE7ByCVq+gB6GZKg+BtsNb2k36mLFu7ux5sAFjk68kN7sSNYLfT8TXdd8mDSii Vtrog4zDsoUNpby+3L0TkVRUipsieHGBjXHsujQAJ3y3WGwV2ibcJhZL/UAdJLVy+ZV1 +Fz5q9baMfK6ixF0DdpIJnwKIcJx+UEbbkZcyVvlfgqamwFlRTFHMJ9ofDnQ1li5DxGS H8/w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a190-v6si4630855pgc.241.2018.08.23.09.31.20; Thu, 23 Aug 2018 09:31:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727462AbeHWTyy (ORCPT + 99 others); Thu, 23 Aug 2018 15:54:54 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:53876 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727407AbeHWTyy (ORCPT ); Thu, 23 Aug 2018 15:54:54 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 287A77DAC9; Thu, 23 Aug 2018 16:24:27 +0000 (UTC) Received: from vitty.brq.redhat.com (unknown [10.43.2.155]) by smtp.corp.redhat.com (Postfix) with ESMTP id 15EDF2166BA1; Thu, 23 Aug 2018 16:24:25 +0000 (UTC) From: Vitaly Kuznetsov To: kvm@vger.kernel.org Cc: Paolo Bonzini , =?UTF-8?q?Radim=20Kr=C4=8Dm=C3=A1=C5=99?= , Jim Mattson , linux-kernel@vger.kernel.org Subject: [PATCH] x86/kvm/nVMX: avoid redundant double assignment of nested_run_pending Date: Thu, 23 Aug 2018 18:24:24 +0200 Message-Id: <20180823162424.13282-1-vkuznets@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Thu, 23 Aug 2018 16:24:27 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Thu, 23 Aug 2018 16:24:27 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'vkuznets@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org nested_run_pending is set 20 lines above and check_vmentry_prereqs()/ check_vmentry_postreqs() don't seem to be resetting it (the later, however, checks it). Signed-off-by: Vitaly Kuznetsov --- arch/x86/kvm/vmx.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index 6c3514750d0c..8a63b8cf9458 100644 --- a/arch/x86/kvm/vmx.c +++ b/arch/x86/kvm/vmx.c @@ -14221,9 +14221,6 @@ static int vmx_set_nested_state(struct kvm_vcpu *vcpu, check_vmentry_postreqs(vcpu, vmcs12, &exit_qual)) return -EINVAL; - if (kvm_state->flags & KVM_STATE_NESTED_RUN_PENDING) - vmx->nested.nested_run_pending = 1; - vmx->nested.dirty_vmcs12 = true; ret = enter_vmx_non_root_mode(vcpu, NULL); if (ret) -- 2.14.4