Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp1854781imm; Thu, 23 Aug 2018 09:50:31 -0700 (PDT) X-Google-Smtp-Source: AA+uWPz2IBsgeN7lUuinHk/F/+pmMpuRZAm3kMkt073W96TdZiqFmE1r/EoRnPbyQbr0frFJ/I2d X-Received: by 2002:a63:7e1c:: with SMTP id z28-v6mr24605207pgc.246.1535043031802; Thu, 23 Aug 2018 09:50:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535043031; cv=none; d=google.com; s=arc-20160816; b=fCWDw12LquPxaPjMETtRrEOjnFaKnJJkvyU8ZZV8dV+XjhEVTbd1qScDnYpshZ3w0U xglJwQk7pWE21sgy+Jb3MjxtLouTZVwq1ga+QLYPU8rx/pva3T14C3n89sQIYoRed/kM 4KR6RVLtKGWuw3v17iyxU7x/eNtm7iqEH6avkSpXTPfx74HmTSreL+JX6bZ7Ab6j5LRu PnNUJzV98l8pcNJDBoQppkbcai97G6M09ez1XgmyKga6weOjIPbGESkiRc81/aMi27WV MAQI6+pL+ouEiI+oP4hpsHVl+61bQiS2IAs1h9US7yjz2p9jDohTc0pupxVnGyjMRe9Y t2ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date :arc-authentication-results; bh=dnInTT3LW/SCT1Xtpq6saUb+x6IEI3k3JIj890rR1bU=; b=Cefo1/Ue0Tfg0ZE6ukkzTaKvtXT0aparEoMvcmNFBrugHpYoIhd8Aw5jPh37ipmhwq XUjEaJB7NWhVJKmbRnFD6w9WUT4TUcFO9cN1wq37/mzorj7yQCz03b0C+cX8vP5mEmXT /rgxmPRyukR4Bfn48QniBPS7PBHu3/G2SAzQas9eNPUWs8029mTeS0gwoubDVb/ohixw eCF0/WLDUsjvYWxRC7ePRivUv6gbOZazXpaXo/6xd7twPxfZ3VMgbGR2o3izLgWzLOGE EdM0GlHjNhgLvuWVLjJLnMPepCuJLq8ejBb4FOVQa/FGx2wEZTZ66Uqn24R1b2fA70HE hQDA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 3-v6si4644770pld.36.2018.08.23.09.50.16; Thu, 23 Aug 2018 09:50:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726438AbeHWUTT (ORCPT + 99 others); Thu, 23 Aug 2018 16:19:19 -0400 Received: from namei.org ([65.99.196.166]:44088 "EHLO namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726064AbeHWUTT (ORCPT ); Thu, 23 Aug 2018 16:19:19 -0400 Received: from localhost (localhost [127.0.0.1]) by namei.org (8.14.4/8.14.4) with ESMTP id w7NGmdfp011040; Thu, 23 Aug 2018 16:48:39 GMT Date: Fri, 24 Aug 2018 02:48:39 +1000 (AEST) From: James Morris To: "Serge E. Hallyn" cc: Christian Brauner , linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] security/capabilities: remove check for -EINVAL In-Reply-To: <20180822135825.GA7223@mail.hallyn.com> Message-ID: References: <20180822115240.18196-1-christian@brauner.io> <20180822135825.GA7223@mail.hallyn.com> User-Agent: Alpine 2.21 (LRH 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 22 Aug 2018, Serge E. Hallyn wrote: > Quoting Christian Brauner (christian@brauner.io): > > bprm_caps_from_vfs_caps() never returned -EINVAL so remove the > > rc == -EINVAL check. > > > > Signed-off-by: Christian Brauner > > Thanks. > > Reviewed-by: Serge Hallyn Thanks, I'll queue this for post -rc1 next-general. -- James Morris