Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261891AbTJADej (ORCPT ); Tue, 30 Sep 2003 23:34:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261892AbTJADej (ORCPT ); Tue, 30 Sep 2003 23:34:39 -0400 Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:35028 "EHLO www.linux.org.uk") by vger.kernel.org with ESMTP id S261891AbTJADei (ORCPT ); Tue, 30 Sep 2003 23:34:38 -0400 Date: Wed, 1 Oct 2003 04:34:37 +0100 From: viro@parcelfarce.linux.theplanet.co.uk To: Bernd Eckenfels Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] linuxabi Message-ID: <20031001033437.GP7665@parcelfarce.linux.theplanet.co.uk> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 01, 2003 at 04:05:57AM +0200, Bernd Eckenfels wrote: > > +#define MS_NODIRATIME 2048 /* Do not update directory access times */ > > +#define MS_BIND 4096 > > +#define MS_POSIXACL (1<<16) /* VFS does not apply the umask */ > > can we clean that up? with shifting, without shifting, with comments and without comments? I suggest to use the linuxdoc comments mandatory for the abi files. ... and make it enum, while we are at it. It's cleaner, it survives cpp and it can be handled by gdb et.al. in sane way. Unless we really want to support pre-v7 compilers, there is no benefit in using #define for such constants. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/