Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2699063imm; Fri, 24 Aug 2018 03:58:11 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYX7ucPZMiyGpfwx/GnqW37MJqepPqAEm+T6q5W7PWSUWuZICSKlvkDh6DXcWEH1ZJyafw4 X-Received: by 2002:a62:225d:: with SMTP id i90-v6mr1421857pfi.246.1535108291048; Fri, 24 Aug 2018 03:58:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535108291; cv=none; d=google.com; s=arc-20160816; b=lTJT6XdkmoZtK0hj0R+UbxyG48CYEEQMwkLjkTi+eQMlioHQv1zVjO063BV5ETFs57 XDbd/bvuauxL5yC1xyt6yg/t0FWFzSx5cVwVUk32Fh8VT5sIFdB0mPSz+6B23VmT1u8A 3yqZlXza3gD3uqSjESnKtAExv+JC9x6ewvGPYNQFJkwp3whi0rwM5HXfbIgP/g2OrMMV CckEeKOj7tjqCeRqgf3vQYZTigg5MYuiwrVdsD/odmGzi6QhLhGH+SNvlGt1UATygvxs lknQkghWDYWY6CP8QVtdcoP8NQJ0eRdZJKf4bg5VLMJc/+RUibslQE0r0oyERlkDORDa EY0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=2v6ZDxWJBdPjyVOqXldEzQZbaFfKtrQEkyAYzEdm2bg=; b=BQ7d/W9Es0/atcucXqnhidRb8UgWiuYJURiO6c+Z6GwgfB1YHwntpR9jcMfhaD3Y5V EHvjq1BReJCQwv8c+YqH0oqru5sAR7V3wxHr3YQw4D6fLK4BtHlqCpvlGBenHK/2NK5+ QdU26+7c8BkuYhxtlcIVdlSiuexdGRuRB1V8AzFuSQsvXtacDJSlqxjSiBPW6peOUVSc 8iJweUN1SG82OgLse4VJDSqyYwfwZr14oNRMujjQUo834KJVhOGaN9G3JF1ge2yQFNa5 +R+17hED6JaVWsag6L6h5XZfCKDoXWZO8Xi5dtMmWmxOiRKYZaKH8UGMRy9nL8/zyNRu Xq8A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u22-v6si6722113plj.434.2018.08.24.03.57.55; Fri, 24 Aug 2018 03:58:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726898AbeHXOaM (ORCPT + 99 others); Fri, 24 Aug 2018 10:30:12 -0400 Received: from www.osadl.org ([62.245.132.105]:34471 "EHLO www.osadl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726522AbeHXOaM (ORCPT ); Fri, 24 Aug 2018 10:30:12 -0400 Received: from debian01.hofrr.at (178.115.242.59.static.drei.at [178.115.242.59]) by www.osadl.org (8.13.8/8.13.8/OSADL-2007092901) with ESMTP id w7OAUI7C006666; Fri, 24 Aug 2018 12:30:18 +0200 From: Nicholas Mc Guire To: Linus Walleij Cc: Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Nicholas Mc Guire Subject: [PATCH] ARM: u300: add missing check for kmalloc Date: Fri, 24 Aug 2018 12:28:54 +0200 Message-Id: <1535106534-983-1-git-send-email-hofrat@osadl.org> X-Mailer: git-send-email 2.1.4 X-Spam-Status: No, score=0.6 required=6.0 tests=BAYES_00,SUSPICIOUS_RECIPS autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on www.osadl.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org kmalloc return for bigrxbuf_virtual was not being checked - in case of failure set status, cleanup bigtxbuf_virtual and baile out. Signed-off-by: Nicholas Mc Guire Fixes: c7c8c78fdf6e ("ARM: 5667/3: U300 SSP/SPI board setup and test") --- Issue found with experimental coccinelle script Not sure about the checkpatch message: CHECK: Comparison to NULL could be written "!bigrxbuf_virtual" #32: FILE: arch/arm/mach-u300/dummyspichip.c:67: + if (bigrxbuf_virtual == NULL) { As the current check for bigtxbuf_virtual uses == NULL that was retained for consistency here. Patch was compile tested with: u300_defconfig (implies MACH_U300_SPIDUMMY=y) Patch is against 4.18 (localversion-next is next-20180824) arch/arm/mach-u300/dummyspichip.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/mach-u300/dummyspichip.c b/arch/arm/mach-u300/dummyspichip.c index 68fe986..ff293ee 100644 --- a/arch/arm/mach-u300/dummyspichip.c +++ b/arch/arm/mach-u300/dummyspichip.c @@ -62,7 +62,13 @@ static ssize_t dummy_looptest(struct device *dev, status = -ENOMEM; goto out; } + bigrxbuf_virtual = kmalloc(DMA_TEST_SIZE, GFP_KERNEL); + if (bigrxbuf_virtual == NULL) { + kfree(bigtxbuf_virtual); + status = -ENOMEM; + goto out; + } /* Fill TXBUF with some happy pattern */ memset(bigtxbuf_virtual, 0xAA, DMA_TEST_SIZE); -- 2.1.4