Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2728189imm; Fri, 24 Aug 2018 04:28:00 -0700 (PDT) X-Google-Smtp-Source: ANB0VdaS4w4BYpaupqWIlfeW50h5H1uQi1myzmz9S+0wI1HEsUHT5A1j1sQZMoYkgiURxdJhrvRl X-Received: by 2002:a17:902:18a:: with SMTP id b10-v6mr1344993plb.62.1535110080909; Fri, 24 Aug 2018 04:28:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535110080; cv=none; d=google.com; s=arc-20160816; b=efU0ILN/vC0S0ZcyqoKeDJ429bg53FDn8lWnuZ/42cjlcnD1Khr0f3ozx6/Oit7eUJ x5Fgkaikv8Nr+yNwYaOgpNmpiyL347hEyZ6PehqxLQxlCTQOz0s0oHNV8bMO7zSz0U6P RF/pCok3hZIjZ/1AueQg2EQMNPCCdecAX5e11xrKNybb5tZZqLeQ0uqBillgsSYdbjgC VdDbnnrznc+35FDm3kd1vrilGYuY3z+ahWAgK4GbbJquLRmTREMWYb3CWevP2dI3nF+H 2ARbXwNcTn0BAqMe8gaOfZc+bG2UkJvJua8Ph30brYInHGvWqMajZFRWyH3idpM8gCyr CgXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=hHgZFcKKVpqBS2HpR2wph4YkrsqOHhtK1U4NDMBSDbI=; b=Iq1PIbkYVqjNVFXaMf+O1OAYGsBerEQIqxHwia2AUPDA6vX94P022iTDI+oNX1ikrw wC5ha+Tw2enxFqyZ0VR7EdKA98FJnLoURpeW+2NfAgY8WI3n45U/12ZocElXAAmFgias msNvE0ozqkbygHqpEqiFBcxfRu4gbflg9LpH7hex6DyZybQXSO/KCCq/MTJxIaWI+xEu 8lq4VCGDpI3TwEL6Z8Q+W+idqEKjzZugGu9H5llmmC5TwiE75bTeNmCo5Q4Fi0mokkpJ WZJoyKCT40AN+d3NDEGuBEiJJ94DIQfLpXyLI96Y4xkTpdIA3RmdqsUbI2joEp9ou7P1 lJxw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i28-v6si7456646pfi.105.2018.08.24.04.27.45; Fri, 24 Aug 2018 04:28:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727610AbeHXO7e (ORCPT + 99 others); Fri, 24 Aug 2018 10:59:34 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:45886 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726462AbeHXO7e (ORCPT ); Fri, 24 Aug 2018 10:59:34 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1ftADO-0006EI-5b; Fri, 24 Aug 2018 19:25:18 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1ftADO-0001N0-1T; Fri, 24 Aug 2018 19:25:18 +0800 Date: Fri, 24 Aug 2018 19:25:18 +0800 From: Herbert Xu To: Mikulas Patocka Cc: "David S. Miller" , linux-crypto@vger.kernel.org, Mike Snitzer , dm-devel@redhat.com, linux-kernel@vger.kernel.org Subject: Re: Deadlock when using crypto API for block devices Message-ID: <20180824112517.pct5bwdlhfdtqwil@gondor.apana.org.au> References: <20180824021010.hfar7gasp34ddrib@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 24, 2018 at 07:22:19AM -0400, Mikulas Patocka wrote: > > And also ablkcipher_next_slow, ablkcipher_copy_iv, skcipher_next_slow, > skcipher_next_copy, skcipher_copy_iv, blkcipher_next_slow, > blkcipher_copy_iv. > > So, I think that dropping CRYPTO_TFM_REQ_MAY_SLEEP is not possible. These should never trigger for dm-crypt AFAICS since it only happens if you provide unaligned input/output. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt