Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp2939606imm; Fri, 24 Aug 2018 07:55:57 -0700 (PDT) X-Google-Smtp-Source: ANB0VdaKH4edoDnqY05rjX6UdFNI3htieMgTFCVjOIDNz+PkPxT1UtC0NqZVy0WPZLOFQbzGfwlz X-Received: by 2002:a65:4984:: with SMTP id r4-v6mr2107281pgs.238.1535122557179; Fri, 24 Aug 2018 07:55:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535122557; cv=none; d=google.com; s=arc-20160816; b=dpC/8dR0S6rYzhY8YlO0r8EgSIC3AtXBC8SVkqWcHUBHsBVittfCJCmAdzgZKRmJsD U/2ucVU7aEoY+jEaGxO3NdWIOoPvL4Cy6+nJFr+yKNL69XiL1C3ze4LXONn5z05cUp1s RmZwEiKhgiJDhx+itt/dn2ac9oOwl53N7w07Ym4l0XNZDu93xAebqzxDHoEq9UstXHuC P0cVMkMf2AfVD2+P7U5GCgMDXyhU7vBTju3ICkYZompNdycCd2m+Lm2URp/4p0bNZo0t 2/C0WYM3cn3guyN1xa2zsZ0u4JfokNUCcHoR+PuT52Djg4XJAOjdM/6unUo3wy7Lv+uf 4SGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=iGSWkShzxKmp4y9EgSFQrKQYvPJbUEcE97ALgc+NgjM=; b=eJ4saUcljdApe0o7LmsO8bXnpWacLS3wT6SVZr/b685nfyXdR/h8F/sUEgR2gd61f8 JAIqjVSA+ClXTqEZWhBCmkyBriIatfbGobi9YDPUL/VfGaeymkgKPJcBVHh/dZtiufX+ 26No4Y7NlogzrVTkVP4k0tHMlYoe5t/8XHAa9jgCu3FUzOC1sdDFI7z4Q5ycWb2ZV250 +JSoueaY+YNDvDc0OUg5jAO0lsSpBk8d0FC/ybV1QAXgxehbqqJ6ZOHBkr0iym6VBXkr A3VDGLfSM5Dokc/9nrX8Pky8/1kfF2nlgM2iAIn+PM3WhxCzvqKv5baoezpacraxzBW+ 7w9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=O8y71oUb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f9-v6si6707889plo.206.2018.08.24.07.55.41; Fri, 24 Aug 2018 07:55:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=O8y71oUb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727753AbeHXS2e (ORCPT + 99 others); Fri, 24 Aug 2018 14:28:34 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:45332 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727452AbeHXS2d (ORCPT ); Fri, 24 Aug 2018 14:28:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=iGSWkShzxKmp4y9EgSFQrKQYvPJbUEcE97ALgc+NgjM=; b=O8y71oUb7QyMBvM2vzR4DqMYA Oy/Q9vYUuCKsuwVBvOdNnUVyRaXyuPeJavaXEpHqYF4elJE2alsJj2fUj1PfAuzgddE92ql2OxnD6 1cGiQOmS4oupnnvnP4E88yST3xINhzYy+kD2QylcW/ydWDo2HVO1mszNfK5Kqvzs01hOp4TNbw0m7 OL2dScKmm1Nn4uFaD4qkDm4XfwX2QE6CzIx3UxHg/ML6z/aiMlFkC57Kvmb46eqNJ50F5UVi4E9d7 CJDqUJZcb6mnQbgCqpwD692Vx2topt5epMd58/PcV1uTSFPrRsQ6utlG65LPTLJT8UXfgArrW6QSd FUojVSGfQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1ftDSr-0003t7-3n; Fri, 24 Aug 2018 14:53:29 +0000 Date: Fri, 24 Aug 2018 07:53:28 -0700 From: Christoph Hellwig To: murphyt7@tcd.ie Cc: leo.duran@amd.com, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Changing the AMD IOMMU API path to work in an atomic context which is necessary for any custom drivers using the IOMMU API while holding a spinlock. Message-ID: <20180824145328.GA7996@infradead.org> References: <1535120929-5693-1-git-send-email-murphyt7@tcd.ie> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1535120929-5693-1-git-send-email-murphyt7@tcd.ie> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 24, 2018 at 02:28:49PM +0000, murphyt7@tcd.ie wrote: > From: Tom Murphy > > --- > > This patch allows the IOMMU API path in the AMD driver to be called from an atomic context. > This is useful for anyone building a driver which needs to call the IOMMU API while holding a spinlock. I don't think that is a good idea. Please point to the code in the driver and we can't probably find a better solution.