Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Roy Pledge <roy.pledge@nxp.com>
To:     Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Leo Li <leoyang.li@nxp.com>
CC:     "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] soc: fsl: qbman: qman: avoid allocating from non
 existing gen_pool
Thread-Topic: [PATCH 2/2] soc: fsl: qbman: qman: avoid allocating from non
 existing gen_pool
Thread-Index: AQHUOylQodMfgkj4pkqAJ+hezXnndQ==
Date:   Fri, 24 Aug 2018 14:53:56 +0000
Message-ID: <DB6PR0402MB272745FC786675AB113E7C7986360@DB6PR0402MB2727.eurprd04.prod.outlook.com>
References: <20180823213600.23426-1-alexandre.belloni@bootlin.com>
 <20180823213600.23426-2-alexandre.belloni@bootlin.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 66c4db69-8b78-4dca-c9d6-08d609d16af2
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Aug 2018 14:53:56.5554
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0402MB2904
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 8/23/2018 5:36 PM, Alexandre Belloni wrote:=0A=
> If the qman driver didn't probe, calling qman_alloc_fqid_range,=0A=
> qman_alloc_pool_range or qman_alloc_cgrid_range (as done in dpaa_eth) wil=
l=0A=
> pass a NULL pointer to gen_pool_alloc, leading to a NULL pointer=0A=
> dereference.=0A=
>=0A=
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>=0A=
> ---=0A=
>  drivers/soc/fsl/qbman/qman.c | 3 +++=0A=
>  1 file changed, 3 insertions(+)=0A=
>=0A=
> diff --git a/drivers/soc/fsl/qbman/qman.c b/drivers/soc/fsl/qbman/qman.c=
=0A=
> index ecb22749df0b..8cc015183043 100644=0A=
> --- a/drivers/soc/fsl/qbman/qman.c=0A=
> +++ b/drivers/soc/fsl/qbman/qman.c=0A=
> @@ -2729,6 +2729,9 @@ static int qman_alloc_range(struct gen_pool *p, u32=
 *result, u32 cnt)=0A=
>  {=0A=
>  	unsigned long addr;=0A=
>  =0A=
> +	if (!p)=0A=
> +		return -ENODEV;=0A=
> +=0A=
>  	addr =3D gen_pool_alloc(p, cnt);=0A=
>  	if (!addr)=0A=
>  		return -ENOMEM;=0A=
=0A=
Reviewed-by: Roy Pledge <roy.pledge@nxp.com>=0A=
=0A=