Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] x86/kvm/nVMX: avoid redundant double assignment of
 nested_run_pending
To:     Vitaly Kuznetsov <vkuznets@redhat.com>, kvm@vger.kernel.org
References: <20180823162424.13282-1-vkuznets@redhat.com>
Cc:     Paolo Bonzini <pbonzini@redhat.com>,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        Jim Mattson <jmattson@google.com>, linux-kernel@vger.kernel.org
From:   Krish Sadhukhan <krish.sadhukhan@oracle.com>
Message-ID: <97047d0e-cfbb-8c23-a0d3-62bcb92a56c4@oracle.com>
Date:   Fri, 24 Aug 2018 13:37:42 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.6.0
MIME-Version: 1.0
In-Reply-To: <20180823162424.13282-1-vkuznets@redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 08/23/2018 09:24 AM, Vitaly Kuznetsov wrote:
> nested_run_pending is set 20 lines above and check_vmentry_prereqs()/
> check_vmentry_postreqs() don't seem to be resetting it (the later, however,
> checks it).
>
> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> ---
>   arch/x86/kvm/vmx.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 6c3514750d0c..8a63b8cf9458 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -14221,9 +14221,6 @@ static int vmx_set_nested_state(struct kvm_vcpu *vcpu,
>   	    check_vmentry_postreqs(vcpu, vmcs12, &exit_qual))
>   		return -EINVAL;
>   
> -	if (kvm_state->flags & KVM_STATE_NESTED_RUN_PENDING)
> -		vmx->nested.nested_run_pending = 1;
> -
>   	vmx->nested.dirty_vmcs12 = true;
>   	ret = enter_vmx_non_root_mode(vcpu, NULL);
>   	if (ret)
Reviewed-by: Krish Sadhukhan <krish.sadhukhan@oracle.com>