Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp3336368imm; Fri, 24 Aug 2018 15:14:24 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZvCCaCahoYI01Vl7qPNVp82PYTiqUbVTA9lalX7iuOQsdAn/shWOCQYtkqvRIpxfRx8QsI X-Received: by 2002:a65:608b:: with SMTP id t11-v6mr3381473pgu.259.1535148864171; Fri, 24 Aug 2018 15:14:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535148864; cv=none; d=google.com; s=arc-20160816; b=tN5A2ZL4xWXYcEX4bsVSEruOCft2bDIU7b79G9dmaEPJ1CUJGLGmXldOy1PTJkxdh9 K8lZrWXfe7NmVViRDkLRSYUhD9hZsllv7gLsQ5Dlou/y16Mezzh0mrabvq+a23p8naQ/ C6soP+AD4tMG7PJZCz1q/YYoGQ9OHfZHNf0ejtYOFcUd+QWl9ZXg2igCJg6HGX++v18d cApc42eb5uUXl0Ve/p9wk8SM+z6BC2qFfJPb9RSR2a+5yB2i8OvpgQGusQ9gJncaH5Il 5BvDiyNV5d/9sr6rLSUP6Y9XeI0RCOAjraYFLWSuuDOYKvtfpH0s/q42cRS1Uh9KomTK cAEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature:arc-authentication-results; bh=4hGWNp7Bsk69DpU8HQwCpjnaeh9B6rwD7duUx+24XQ8=; b=UQR19R2GoGgg3wsbevWDRW89RDyf4lCMFFceuCPI5iFe1OR+UGF1SH50obEPrHSpbL 1EXyy9uv6g9O5p/r1DpJoOsq7YaXMcLbe3OeiuMgVs1nyxaeSXnn9F04GQyseyI/cuay ww881L2UXEb7QWHiEYzb9tO20VeNv1Qd55iKeLmSCyDM9GYpD9ywNcOJAQtv6Bvy5BYC 9y/+Vdxtgwcd33si3gxkg8wES9Wo+iisYtQQTEDVUVKihY76ZuuO0LV6gJD54oYt3J/n 2ZAypP5AD0nQpZ3QfiDO1Z81QrsS4eGesXPWuWuyenBRnFbIoNUeU3GX2kOwteujisYl SZWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=04b2uNED; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q18-v6si6435776pgg.620.2018.08.24.15.14.08; Fri, 24 Aug 2018 15:14:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=04b2uNED; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727199AbeHYBtg (ORCPT + 99 others); Fri, 24 Aug 2018 21:49:36 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:46814 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726563AbeHYBtg (ORCPT ); Fri, 24 Aug 2018 21:49:36 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w7OM8wQV172383; Fri, 24 Aug 2018 22:12:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=4hGWNp7Bsk69DpU8HQwCpjnaeh9B6rwD7duUx+24XQ8=; b=04b2uNEDYlvPrH4093Q+xNAVD2/JFN2rN1TRaV/jsHotkcnpABbfJ0uo0gap0YPvLIsw duzMev8xPeoYSl0Vk0Ylc/4sdRmNQkknVpRFcY2HrBbvt5X958b2vknvjSp/kQe98nUr 8mn3q4HztUFsIA8MBVvH3vRKm5x0PG33U3Szf/IIjonXw5JhRK0Ccp65inYD0o1UvWBV AS8qTdz68+Ir7ewBJ7ho0DHiOIQMuycRuwaSyclKTiYPBMRNmGuo4Qy7qtdU6R5DK0Wz GD8SwLggliCyDhXXkhOcGjeTiBZJoEmFbiZMfaGR+D00nUNd0IQG1ukRw5t0HkM71Imf QQ== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp2120.oracle.com with ESMTP id 2kxc3raasv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 24 Aug 2018 22:12:46 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w7OMCiFT032436 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 24 Aug 2018 22:12:44 GMT Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w7OMCgTL024342; Fri, 24 Aug 2018 22:12:43 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 24 Aug 2018 15:12:42 -0700 To: Ard Biesheuvel Cc: "Martin K. Petersen" , Jeffrey Lien , Christoph Hellwig , "linux-kernel\@vger.kernel.org" , "linux-crypto\@vger.kernel.org" , "linux-block\@vger.kernel.org" , "linux-scsi\@vger.kernel.org" , "herbert\@gondor.apana.org.au" , "tim.c.chen\@linux.intel.com" , David Darrington , Jeff Furlong Subject: Re: [PATCH] Performance Improvement in CRC16 Calculations. From: "Martin K. Petersen" Organization: Oracle Corporation References: <1533928331-21303-1-git-send-email-jeff.lien@wdc.com> <20180822062016.GA10356@infradead.org> Date: Fri, 24 Aug 2018 18:12:39 -0400 In-Reply-To: (Ard Biesheuvel's message of "Fri, 24 Aug 2018 22:54:26 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8995 signatures=668707 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=747 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1808240222 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ard, > This looks like it should work, yes. It does rely on the module name > to start with 'crct10dif' but I guess that is reasonable, and matches > the current state on all architectures. Yep, I verified the module names on ARM and Power. There really wasn't much I could key off of other than the name string. > Anyone care to boot test this? Jeffrey? Did some quick tests on my end with both scsi_debug and FC hardware. I verified that performance went up as I loaded crct10dif-pclmul while the test was running: [ 23.488059] CRC T10 DIF calculated using crypto hash crct10dif-generic [ 156.922455] sd 0:0:0:0: [sda] Enabling DIX T10-DIF-TYPE1-CRC protection [ 221.577731] CRC T10 DIF calculated using crypto hash crct10dif-pclmul R 63.60 MB/s, W 61.00 MB/s, IOPS 486 | Ops 4460, Rec 0, Err 0 R 61.80 MB/s, W 62.00 MB/s, IOPS 493 | Ops 6926, Rec 0, Err 0 R 62.60 MB/s, W 60.80 MB/s, IOPS 494 | Ops 9396, Rec 0, Err 0 R 59.40 MB/s, W 58.80 MB/s, IOPS 482 | Ops 11804, Rec 0, Err 0 R 151.40 MB/s, W 155.40 MB/s, IOPS 1216 | Ops 17883, Rec 0, Err 0 R 165.00 MB/s, W 166.40 MB/s, IOPS 1327 | Ops 24520, Rec 0, Err 0 R 175.00 MB/s, W 177.40 MB/s, IOPS 1417 | Ops 31604, Rec 0, Err 0 R 185.80 MB/s, W 188.60 MB/s, IOPS 1507 | Ops 39137, Rec 0, Err 0 R 200.60 MB/s, W 203.00 MB/s, IOPS 1629 | Ops 47284, Rec 0, Err 0 Note that in this case the CRC is calculated twice per I/O (block layer and scsi_debug). I'll do some more testing over the weekend... -- Martin K. Petersen Oracle Linux Engineering