Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] MIPS: BCM47XX: Enable USB power on Netgear WNDR3400v3
To:     Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi>,
        =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>
Cc:     linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
References: <20180819192023.18463-1-tuomas.tynkkynen@iki.fi>
From:   Hauke Mehrtens <hauke@hauke-m.de>
Message-ID: <8b81db2e-050f-c467-04b5-d81244f2f500@hauke-m.de>
Date:   Sat, 25 Aug 2018 16:26:38 +0200
MIME-Version: 1.0
In-Reply-To: <20180819192023.18463-1-tuomas.tynkkynen@iki.fi>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 08/19/2018 09:20 PM, Tuomas Tynkkynen wrote:
> Setting GPIO 21 high seems to be required to enable power to USB ports
> on the WNDR3400v3. As there is already similar code for WNR3500L,
> make the existing USB power GPIO code generic and use that.
> 
> Signed-off-by: Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi>

I didn't runtime tested this and didn't checked the board, but this
looks good.

Acked-by: Hauke Mehrtens <hauke@hauke-m.de>

> ---
>  arch/mips/bcm47xx/workarounds.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/mips/bcm47xx/workarounds.c b/arch/mips/bcm47xx/workarounds.c
> index 1a8a07e7a563..46eddbec8d9f 100644
> --- a/arch/mips/bcm47xx/workarounds.c
> +++ b/arch/mips/bcm47xx/workarounds.c
> @@ -5,9 +5,8 @@
>  #include <bcm47xx_board.h>
>  #include <bcm47xx.h>
>  
> -static void __init bcm47xx_workarounds_netgear_wnr3500l(void)
> +static void __init bcm47xx_workarounds_enable_usb_power(int usb_power)
>  {
> -	const int usb_power = 12;
>  	int err;
>  
>  	err = gpio_request_one(usb_power, GPIOF_OUT_INIT_HIGH, "usb_power");
> @@ -23,7 +22,10 @@ void __init bcm47xx_workarounds(void)
>  
>  	switch (board) {
>  	case BCM47XX_BOARD_NETGEAR_WNR3500L:
> -		bcm47xx_workarounds_netgear_wnr3500l();
> +		bcm47xx_workarounds_enable_usb_power(12);
> +		break;
> +	case BCM47XX_BOARD_NETGEAR_WNDR3400_V3:
> +		bcm47xx_workarounds_enable_usb_power(21);
>  		break;
>  	default:
>  		/* No workaround(s) needed */
>