Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 25 Aug 2018 20:27:58 +0200 (CEST)
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Mukesh Ojha <mojha@codeaurora.org>
cc:     lkml <linux-kernel@vger.kernel.org>
Subject: Re: Query on skip_onerr field in struct cpuhp_step
In-Reply-To: <a8599754-5c8b-1667-1685-901f53319064@codeaurora.org>
Message-ID: <alpine.DEB.2.21.1808252025590.1195@nanos.tec.linutronix.de>
References: <c228c495-63fa-5af9-32ff-355410d78cc8@codeaurora.org> <alpine.DEB.2.21.1808211557180.1535@nanos.tec.linutronix.de> <a8599754-5c8b-1667-1685-901f53319064@codeaurora.org>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 21 Aug 2018, Mukesh Ojha wrote:
> On 8/21/2018 7:27 PM, Thomas Gleixner wrote:
> > > If it is specifically was dependent on notifiers, did we missed to remove
> > > it as the notifiers are gone or the usecase still there?
> > As the comment says....
> 
> Thanks for your reply
> Sorry, for further question but i did not get the comment ..did you mean, we
> can remove this from the structure as notifier are not their now. ?

Yes, that's why the comment for that member says: Remove after conversion.

> Also if you are aware with the history, can you tell , why would i want to
> avoid a call in undo_cpu_up path?

Because the notifiers worked completely differently. Go back in the
git history where the initial conversion from notifiers to the state
machine happened.

Thanks,

	tglx