Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp4787025imm; Sun, 26 Aug 2018 03:45:25 -0700 (PDT) X-Google-Smtp-Source: ANB0Vdal3eIa8A8E55pj6YE/xicJ4cvBnmuuvrvcdWQHrNbYzBRwU85U5Q3LR/GrNT3n3eHXHqRJ X-Received: by 2002:a17:902:42a:: with SMTP id 39-v6mr8720166ple.39.1535280325714; Sun, 26 Aug 2018 03:45:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535280325; cv=none; d=google.com; s=arc-20160816; b=v0DpXDvQClA1sms0u9BrinQRZEarfIooARDjmsI9qQGcRkjHqJHDZns8YnbP1ZmABX lQ7fumy26UYskBMSf+N0JVYoeJv1u7LUmQytf9lN7B8Y9eohBbe/mXlMlPBMMlQUQeHh hr5fMWavTyQj2Ff0yX33OVYC3mU/0WKz4Rpx+qLmCH9MKsUNJfmhNmkVll09xwv/UBTx DmdX3SsOvS1bzOQFrAeHROtu7NM2bfgUnxKhp6iNicmSyzSbuokuQoIO3yCmF+/jF8B/ qElKXPyF2dr3HrM+CUY08ruqHdxa7wZ0Q5skmh6NwMwA9hyckbr/AKiryULB5RQqtYxg wWfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=30IZKoTNtpyvYc4hXyEGiYv4imtMORewtfjc/KlR6WU=; b=kFRFTFYZ3wexakYYMlVfkwIFr3npMfAlBXdBW7bNadKVAjUTUbwlxGlh9LVf+RcDxF lFT70hcXrh/5mABQ1Rvfe2DiuhH/wF5ecF1CTSd3KUhKbxYDsSHs2hhujMhYSco2NDaB MtGErV67h7veR57saU9lyqFzYRbxhvHbFYioDO12W7NzooCTLnAsOt7c5YOGk+Fwp34S cCXpyJn4XFz9t7t36hhY89DaJQedETFXNtanvlAUGqbEM/f7shwWYugiZrnWUh3n1RD9 NWvLZk0ToxpNFNua3bHbKVTB0jHHEm6qNK0cjfRJAYPPG+N7Id/qmiU46Zd11nmxMEs8 6oSg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x17-v6si10964448pgi.243.2018.08.26.03.44.58; Sun, 26 Aug 2018 03:45:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726697AbeHZOZY (ORCPT + 99 others); Sun, 26 Aug 2018 10:25:24 -0400 Received: from mga04.intel.com ([192.55.52.120]:9612 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726415AbeHZOZX (ORCPT ); Sun, 26 Aug 2018 10:25:23 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Aug 2018 03:43:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,290,1531810800"; d="scan'208";a="86474575" Received: from kohsamui.iil.intel.com ([10.236.193.12]) by orsmga002.jf.intel.com with ESMTP; 26 Aug 2018 03:43:10 -0700 From: Alexey Skidanov To: labbott@redhat.com, dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org, Alexey Skidanov Subject: [PATCH] staging: android: ion: Clean unused debug_show memeber of the heap object Date: Sun, 26 Aug 2018 13:44:12 +0300 Message-Id: <1535280252-26647-1-git-send-email-alexey.skidanov@intel.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Signed-off-by: Alexey Skidanov --- drivers/staging/android/ion/ion.h | 5 ----- drivers/staging/android/ion/ion_system_heap.c | 24 ------------------------ 2 files changed, 29 deletions(-) diff --git a/drivers/staging/android/ion/ion.h b/drivers/staging/android/ion/ion.h index 876197b..0afa9cd 100644 --- a/drivers/staging/android/ion/ion.h +++ b/drivers/staging/android/ion/ion.h @@ -158,8 +158,6 @@ struct ion_heap_ops { * @lock: protects the free list * @waitqueue: queue to wait on from deferred free thread * @task: task struct of deferred free thread - * @debug_show: called when heap debug file is read to add any - * heap specific debug info to output * * Represents a pool of memory from which buffers can be made. In some * systems the only heap is regular system memory allocated via vmalloc. @@ -180,9 +178,6 @@ struct ion_heap { spinlock_t free_lock; wait_queue_head_t waitqueue; struct task_struct *task; - - int (*debug_show)(struct ion_heap *heap, struct seq_file *s, - void *unused); }; /** diff --git a/drivers/staging/android/ion/ion_system_heap.c b/drivers/staging/android/ion/ion_system_heap.c index b5c3195..d0d0490 100644 --- a/drivers/staging/android/ion/ion_system_heap.c +++ b/drivers/staging/android/ion/ion_system_heap.c @@ -213,29 +213,6 @@ static struct ion_heap_ops system_heap_ops = { .shrink = ion_system_heap_shrink, }; -static int ion_system_heap_debug_show(struct ion_heap *heap, struct seq_file *s, - void *unused) -{ - struct ion_system_heap *sys_heap = container_of(heap, - struct ion_system_heap, - heap); - int i; - struct ion_page_pool *pool; - - for (i = 0; i < NUM_ORDERS; i++) { - pool = sys_heap->pools[i]; - - seq_printf(s, "%d order %u highmem pages %lu total\n", - pool->high_count, pool->order, - (PAGE_SIZE << pool->order) * pool->high_count); - seq_printf(s, "%d order %u lowmem pages %lu total\n", - pool->low_count, pool->order, - (PAGE_SIZE << pool->order) * pool->low_count); - } - - return 0; -} - static void ion_system_heap_destroy_pools(struct ion_page_pool **pools) { int i; @@ -282,7 +259,6 @@ static struct ion_heap *__ion_system_heap_create(void) if (ion_system_heap_create_pools(heap->pools)) goto free_heap; - heap->heap.debug_show = ion_system_heap_debug_show; return &heap->heap; free_heap: -- 2.7.4