Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 27 Aug 2018 11:16:53 +0530
From:   Vinod <vkoul@kernel.org>
To:     Huang Shijie <sjhuang@iluvatar.ai>
Cc:     sudeep.dutt@intel.com, ashutosh.dixit@intel.com,
        dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dma: mic_x100_dma: use devm_kzalloc to fix an issue
Message-ID: <20180827054652.GW2388@vkoul-mobl>
References: <20180822024027.8984-1-sjhuang@iluvatar.ai>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180822024027.8984-1-sjhuang@iluvatar.ai>
User-Agent: Mutt/1.9.2 (2017-12-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 22-08-18, 10:40, Huang Shijie wrote:
> The following patch introduced an issue.
>     commit f6206f00d8c5 ("dmaengine: mic_x100_dma: use the new helper to simplify the code")
> 
> This issue is :
> 
> 	kfree(mic_dma_dev)
> 	.....
> 	dma_async_device_unregister(mic_dma_dev->device);
> 
> Free the memory, and use it again.
> 
> So use devm_kzalloc to allocate mic_dma_dev to fix it.
> 
> When the Devres try to release the resources, it will call release at the
> following order:
> 
> 	dma_async_device_unregister(mic_dma_dev->device);
> 	.....
> 	kfree(mic_dma_dev)

After fixing the subsystem name, applied thanks
-- 
~Vinod