Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 27 Aug 2018 07:03:17 -0700
From:   Tejun Heo <tj@kernel.org>
To:     Bernd Edlinger <bernd.edlinger@hotmail.de>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv3] Fix range checks in kernfs_get_target_path
Message-ID: <20180827140317.GD3978217@devbig004.ftw2.facebook.com>
References: <AM5PR0701MB2657711C49D0229DBED3A24EE4460@AM5PR0701MB2657.eurprd07.prod.outlook.com>
 <AM5PR0701MB265723084A8E48954B914CF4E4340@AM5PR0701MB2657.eurprd07.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <AM5PR0701MB265723084A8E48954B914CF4E4340@AM5PR0701MB2657.eurprd07.prod.outlook.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Aug 26, 2018 at 10:55:24AM +0000, Bernd Edlinger wrote:
> Ping...
> Sorry, I had actually completely forgotten about this one.
> 
> On 07/07/18 19:52, Bernd Edlinger wrote:
> > The terminating NUL byte is only there because the buffer is
> > allocated with kzalloc(PAGE_SIZE, GFP_KERNEL), but since the
> > range-check is off-by-one, and PAGE_SIZE==PATH_MAX, the
> > returned string may not be zero-terminated if it is exactly
> > PATH_MAX characters long.? Furthermore also the initial loop
> > may theoretically exceed PATH_MAX and cause a fault.
> > 
> > Signed-off-by: Bernd Edlinger <bernd.edlinger@hotmail.de>

Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

-- 
tejun