Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp5980575imm; Mon, 27 Aug 2018 07:41:34 -0700 (PDT) X-Google-Smtp-Source: ANB0VdbfzJaLlVbur6YyYWDvSd0mFPvL82a8ruJRcGRMEdJxAAFOas1UEpafh0J/DKSZMmqVmA1Y X-Received: by 2002:a62:6d02:: with SMTP id i2-v6mr15025522pfc.218.1535380894590; Mon, 27 Aug 2018 07:41:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535380894; cv=none; d=google.com; s=arc-20160816; b=CrAuvWIkcIGuqOReUAvsxN9lbCwZKemp0FPPvLVzx9joGaEoI0knfN7UzFPAwtaKjt PXCB76tY1Vq8oS5bNvNxdldyKKQaINrY2JdipdDq1pRjDY1n2q0m0y/rgXmuf71bYGGQ oQJv0ck8GSxoYLthWSyCxuLQE/6qYPOolBIX02KBT/P7WhR897XXa68YVzN/Hs0LpVgF mkVzqDj393s7kstJAUiw5xyjTESu2wkVaR1DAo0QbajbKylQmGTIxCazfqQb0HQmZPYV VFr+JfkvrnsYCfD3XVuSvIvHUO5SFJDNhNKyaY9EblFoCFxKRe4W+pmmPqvijXHIUHPu i3YQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=iKrwdnjr3T1Wk9A/mO8JS/4vpucKrbYFF7MqB/0EJLs=; b=kFAWvzUWn8hSxnZoiJ4Z/2zQLyabpJPLGBNGkXBVoIZ10PrUMS/wtLqbpN4Y4YHkHY /cCzXY3B/RbKAWaYs3Nabm+K9VmfK/DHlsPw9zwBeJ0i8UEk8XDID4qQua0/QtTlqzpG PKZQEAypDF9pCACFbIE1h4jqJtyZtvA7mLKzOgtzt9wu4BfD3szLB+1jySLP13TKrlz3 Dv6Va2SWDp58+lZ6dXnhWLm5rSkaCFijZw41ZSj0QZChRgvAhBnbYMKAXnOStDks+e+u NHzfs1kBGTexxzkXjMkhn+REdUCVAYmZhhZedfRgRKvAE4plHtB3jn6Q+Q1YDsoi0NT8 IFxw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b="Uz8P+fE/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 71-v6si16887132pfa.305.2018.08.27.07.40.55; Mon, 27 Aug 2018 07:41:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b="Uz8P+fE/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727593AbeH0SZD (ORCPT + 99 others); Mon, 27 Aug 2018 14:25:03 -0400 Received: from smtprelay2.synopsys.com ([198.182.60.111]:49060 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726953AbeH0SZD (ORCPT ); Mon, 27 Aug 2018 14:25:03 -0400 Received: from mailhost.synopsys.com (mailhost1.synopsys.com [10.12.238.239]) by smtprelay.synopsys.com (Postfix) with ESMTP id 53ED910C1653; Mon, 27 Aug 2018 07:38:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1535380689; bh=q3YqdrjAJZNRdEQQIlBP0LhqGoSbVJw0DCfhY77+6fk=; h=From:To:Cc:Subject:Date:From; b=Uz8P+fE/sB5SsoQD8hceADdrJJSp2Bh2Ne4c2X0USfD47mfhJNd3EuqqDybRVzkcT 5LOa2gtbbbkW3NeVgSS3sEmsskuA01H8jxTJaqq7dRH7S5UHSGKHeUd8csZc0YEY9p /UpG2VqrDeofwWgKEBiYfby+fKZVMuUpUmwjLMvabXm6yalQ6IhL4dCNP5hHKF2H0r kzy5dno4+gMZftaX6Dx9WUJUwiB9/OnMGBY/rOziPvEc4kcpC2b/4X/UOy2aKH48pm sZ+iaN3I+I++uKxluCnUib31HoNKDMAVj4hG2/WGy+uYaNmVCBNr95BZwpCByZ+bP5 oEXa52Pca+zyw== Received: from paltsev-e7480.internal.synopsys.com (paltsev-e7480.internal.synopsys.com [10.121.3.36]) by mailhost.synopsys.com (Postfix) with ESMTP id B3E8755E0; Mon, 27 Aug 2018 07:38:06 -0700 (PDT) From: Eugeniy Paltsev To: Philipp Zabel Cc: linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org, Alexey Brodkin , Eugeniy Paltsev Subject: [PATCH] ARC: HSDK: improve reset driver Date: Mon, 27 Aug 2018 17:38:03 +0300 Message-Id: <20180827143803.28178-1-Eugeniy.Paltsev@synopsys.com> X-Mailer: git-send-email 2.14.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As for today HSDK reset driver implements only .reset() callback. In case of driver which implements one of standard reset controller usage pattern (call *_deassert() in probe(), call *_assert() in remove()) that leads to inoperability of this reset driver. Improve HSDK reset driver by calling .reset() callback inside of .assert()/.deassert() callbacks to avoid each reset controller user adaptation for work with both reset methods (reset() and .assert()/.deassert() pair) Signed-off-by: Eugeniy Paltsev --- drivers/reset/reset-hsdk.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/reset/reset-hsdk.c b/drivers/reset/reset-hsdk.c index 8bce391c6943..1fd91df91343 100644 --- a/drivers/reset/reset-hsdk.c +++ b/drivers/reset/reset-hsdk.c @@ -86,6 +86,8 @@ static int hsdk_reset_reset(struct reset_controller_dev *rcdev, static const struct reset_control_ops hsdk_reset_ops = { .reset = hsdk_reset_reset, + .assert = hsdk_reset_reset, + .deassert = hsdk_reset_reset, }; static int hsdk_reset_probe(struct platform_device *pdev) -- 2.14.4