Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp6233179imm; Mon, 27 Aug 2018 12:01:21 -0700 (PDT) X-Google-Smtp-Source: ANB0VdY/87lVN9Si08V1YqDSQbQP7LW1sG9NWFxIdpyWv4QmcAwSndmq5SpCkdzMNX8ZZYSmwVKc X-Received: by 2002:a62:7182:: with SMTP id m124-v6mr15452354pfc.73.1535396481517; Mon, 27 Aug 2018 12:01:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535396481; cv=none; d=google.com; s=arc-20160816; b=QsNsc1I3FNGE3snTWRkPfAEy2KQrIImS+UXEWJvE0aGS83bTyFc1AHiI1ha6v8z+fn HoeoRW4lWUYaXU+d4JYGrHsuNYgpvRv0W07ydW464vlOomHOYI0h+pdntGooPtGGof97 PUTrx4CnR779rWs1o4aHXl27VSbro8Dfulb7umy5eA+IDMpQPKIlQseceT0gP0e2A7VO yPgMgDzXSFEsEoGeh8bGnJsFgyxdYMmlDOwNf0zUbD3W2N+xS47LHagFOabs7UCqddS3 VRH3pUP4xbl6h1QMv3TqU5+HWboEm+BHdJCx3Y4JHhX6h21/fASKEbjfaFQ00noOlool /ZxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=rr6X5S7h8exasUI6LOFspgu6m0Tv0VEvQiJr3QFW/I8=; b=HlCmu/2RsbzXgBasbkTarNXZuujxaKoE9gCcFDcDuuwHVg7ydWsT09lI/GSXe5rcYp xXJ76WzSgR632lq3obt3/KxTWYc0caYBAc0YxzwfyUHDFBNTgwtUtsN5nqVSS3fYaNiF KYbi8xDXt7XGM/XJICGWKOpK1QqSj/QFPg+WPDiO8NZ4mOoNeHUzg3YvTcoMYPyCXaK5 xfxXLqD7zizeqTwyPTyYZ8lwo65SR3JPbbtjQNdOe96xzRiexsgxDRkgZyydv+12x1wX DPV+TJqcIVZvFgNa6W1l8vmKcXVJcCfOV1xMJdMsRskF3ccgHl/YwS7jSPSZMqZf4VT1 wP7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=HNI8UIl9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i90-v6si2903pli.274.2018.08.27.12.01.05; Mon, 27 Aug 2018 12:01:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=HNI8UIl9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728075AbeH0Wqw (ORCPT + 99 others); Mon, 27 Aug 2018 18:46:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:45718 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726958AbeH0Wqw (ORCPT ); Mon, 27 Aug 2018 18:46:52 -0400 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 76B4E208DA for ; Mon, 27 Aug 2018 18:59:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1535396342; bh=rr6X5S7h8exasUI6LOFspgu6m0Tv0VEvQiJr3QFW/I8=; h=In-Reply-To:References:From:Date:Subject:To:Cc:From; b=HNI8UIl9C2YOXJhHGzYVMu2/TFXJQst+uTadr9vn7MbNYe0sexxBslyyU6MTcV+uz 7Wuja//zK5V6XFs1HGLk0vMYFXWFQaOF9Hwz1fbp+jMg4Yf4JbVDSp1Z4s6yAF+l9L ll5B8TIePrUMVhgk4Rk9tI8lyZEiInVqrJXCGK7k= Received: by mail-wr1-f51.google.com with SMTP id g33-v6so33016wrd.1 for ; Mon, 27 Aug 2018 11:59:02 -0700 (PDT) X-Gm-Message-State: APzg51CbRcjPYLL8bpbBOi/ZsdqNKsxnyBmxNHiEdRxpVv5rg4NZlfoW R3iIsg8mWK59ONlY4/rIK+VizhtW4asoG1IaN6YNMA== X-Received: by 2002:adf:dcc1:: with SMTP id x1-v6mr9811540wrm.21.1535396340968; Mon, 27 Aug 2018 11:59:00 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a1c:548:0:0:0:0:0 with HTTP; Mon, 27 Aug 2018 11:58:40 -0700 (PDT) In-Reply-To: <0000D631-FDDF-4273-8F3C-714E6825E59B@gmail.com> References: <20180824180438.GS24124@hirez.programming.kicks-ass.net> <56A9902F-44BE-4520-A17C-26650FCC3A11@gmail.com> <9A38D3F4-2F75-401D-8B4D-83A844C9061B@gmail.com> <8E0D8C66-6F21-4890-8984-B6B3082D4CC5@gmail.com> <20180826112341.f77a528763e297cbc36058fa@kernel.org> <20180826090958.GT24124@hirez.programming.kicks-ass.net> <20180827120305.01a6f26267c64610cadec5d8@kernel.org> <4BF82052-4738-441C-8763-26C85003F2C9@gmail.com> <20180827170511.6bafa15cbc102ae135366e86@kernel.org> <01DA0BDD-7504-4209-8A8F-20B27CF6A1C7@gmail.com> <0000D631-FDDF-4273-8F3C-714E6825E59B@gmail.com> From: Andy Lutomirski Date: Mon, 27 Aug 2018 11:58:40 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: TLB flushes on fixmap changes To: Nadav Amit Cc: Andy Lutomirski , Masami Hiramatsu , Peter Zijlstra , Kees Cook , Linus Torvalds , Paolo Bonzini , Jiri Kosina , Will Deacon , Benjamin Herrenschmidt , Nick Piggin , "the arch/x86 maintainers" , Borislav Petkov , Rik van Riel , Jann Horn , Adin Scannell , Dave Hansen , Linux Kernel Mailing List , linux-mm , David Miller , Martin Schwidefsky , Michael Ellerman Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 27, 2018 at 11:54 AM, Nadav Amit wrote: >> On Mon, Aug 27, 2018 at 10:34 AM, Nadav Amit wrote: >> What do you all think? > > I agree in general. But I think that current->mm would need to be loaded, as > otherwise I am afraid it would break switch_mm_irqs_off(). > What breaks?