Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <1535411336.3516.2.camel@megha-Z97X-UD7-TH>
References: <00000000000072d64d05737b6b8c@google.com> <20180820073119.GA14931@sol.localdomain>
 <CAKv+Gu9Y0TLOuMba43HPihYqy-kk0nttBfPj1_UukiYy1cBcFw@mail.gmail.com>
 <20180822062036.mdq4q5o5zdzuxh7s@gondor.apana.org.au> <1535411336.3516.2.camel@megha-Z97X-UD7-TH>
From:   Ard Biesheuvel <ard.biesheuvel@linaro.org>
Date:   Tue, 28 Aug 2018 01:01:00 +0200
Message-ID: <CAKv+Gu_oZ0Z37WV1h4opi-cYZT5FWU_bmrkBjx8LXpvKpPoZNA@mail.gmail.com>
Subject: Re: KASAN: use-after-free Read in sha512_ctx_mgr_resubmit
To:     Megha Dey <megha.dey@linux.intel.com>
Cc:     Herbert Xu <herbert@gondor.apana.org.au>,
        Eric Biggers <ebiggers@kernel.org>,
        Tim Chen <tim.c.chen@linux.intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        syzbot <syzbot+d5455bac3ba1ee9114e5@syzkaller.appspotmail.com>,
        "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" 
        <linux-crypto@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        syzkaller-bugs <syzkaller-bugs@googlegroups.com>,
        "the arch/x86 maintainers" <x86@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 28 August 2018 at 01:08, Megha Dey <megha.dey@linux.intel.com> wrote:
> On Wed, 2018-08-22 at 14:20 +0800, Herbert Xu wrote:
>> On Tue, Aug 21, 2018 at 02:43:56PM +0200, Ard Biesheuvel wrote:
>> >
>> > I agree. The code is obviously broken in a way that would have been
>> > noticed if it were in wide use, and it is too complicated for mere
>> > mortals to fix or maintain. I suggest we simply remove it for now, and
>> > if anyone wants to reintroduce it, we can review the code *and* the
>> > justification for the approach from scratch (in which case we should
>> > consider factoring out the algo agnostics plumbing in a way that
>> > allows it to be reused by other architectures as well)
>>
>> I agree too.  Could one of you guys send me a patch to remove
>> them?
>>
>
> Hi,
>
> We are working on a fix to solve these corner cases.
>

Great. thanks.

But it would also be helpful if you could try and answer the questions
raised by Eric:
- in which cases does this driver result in a speedup?
- how should we tune the flush delay to prevent pathological
performance regressions?
- is it still safe in the post-Spectre era of computing to aggregate
hash input from different sources (which may be different users
altogether) and process them as a single source of input?