Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp6533273imm; Mon, 27 Aug 2018 18:26:11 -0700 (PDT) X-Google-Smtp-Source: ANB0Vdaw3FiBW5mESdHuDftIdvjF0N931PmupsP3/SA8nsfEFNVTIzLFAg+w+svYgDATLGlFKVHC X-Received: by 2002:a17:902:3041:: with SMTP id u59-v6mr15005875plb.99.1535419570998; Mon, 27 Aug 2018 18:26:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535419570; cv=none; d=google.com; s=arc-20160816; b=leJM6yN71fLcT9R+UH7bv7gXADMa1LtwKVhiDRgczaU4Bwl5xLN1nzGQSwiTMecDAj 6n58lEL4HdTqDHpbDGZdN8KXX2uhW9ulbjoNNk7UssZRNPMI3jhdoJbyYJqr6XntK+4r yRkPqjOqf/e3++qCby6ItZaouK8Vz4Hf5EBdFNzntFjQEsFBPqWSNuCuCcthix9OsmBv 7i/HmtjRttY4HYaunYVKs0WKKOlacJVwh5/KRCaqNdgUMLBChY8z+QiTt5kklERuVqpg gbS4+QM50cNaF+TZl64YPCQz8C/C8LuWoNKDWPgdKl5qBhXhJ50jOkOMzFY8N2TulXUB 833A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=4oSDwJDeihfUA+HsgtBsTUowt1giyERk8qdXwsrphSQ=; b=XcQtB8MPkhnZ89qtr57tU/29tmlZ/p7GeDKN48NJ9qEiO8PJa1urEFbdQoediXyu54 S5ElIDK39BuZEUEkAOeej3G51NrFfb/DYgvj57xipHSVw3voT8A5GNC2of5bn3Wxp707 pXZM9Xl+1TgZSkTtOYPHpI36RMKb1sHpXsUWD8QcF7/TgbxCoQNqN/hQXggBJvv2iUV9 Ixj9b4e/m2eYbLqx/xhjVAh9v1WW+Q8A0iMDXTKk/DAY5plfldc7UazC8ASfJX2u/AXJ catOv0Q6rftYzbX8XJwI23ZYhXeD1hWB53YhqoSYjy+xYVji2u+X+Ln77oSWXROWunxq Ixig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=C7eCYV3w; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y67-v6si853592pfa.47.2018.08.27.18.25.55; Mon, 27 Aug 2018 18:26:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=C7eCYV3w; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727050AbeH1FNq (ORCPT + 99 others); Tue, 28 Aug 2018 01:13:46 -0400 Received: from mail-qk0-f195.google.com ([209.85.220.195]:35198 "EHLO mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725724AbeH1FNp (ORCPT ); Tue, 28 Aug 2018 01:13:45 -0400 Received: by mail-qk0-f195.google.com with SMTP id 89-v6so705219qkp.2; Mon, 27 Aug 2018 18:24:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=4oSDwJDeihfUA+HsgtBsTUowt1giyERk8qdXwsrphSQ=; b=C7eCYV3wf8XiGqBQeswOX3LQ69qJ0QmzUlmKgzi4xwmWwprv5V7oH3khOU0fNlArbO Mr6QY2kmh8IQ5UFnQqnG9Jju0t2pzJSm0auDj9hkNvTdwixyAyfeoZW40vl5UrCd4hhK xPzO4O4xmTB5cvOEmScuDcJS9ZFbVHi2hshztZjX+JRQ8a870PP/lugH0CSACBGLYyas n3qwpSuGmQIpM6+HGDjU/rM+nEJZt2jR77VeuY/LMKRsebAvXVAJ1f5bDpqemC0JxpAS wSW/1UohoZvVfM2JTXjOPcIb+ZYQoxXdb1ReaGRlalj81qDvVudXSxhojk1CwxgFN5tq hX/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=4oSDwJDeihfUA+HsgtBsTUowt1giyERk8qdXwsrphSQ=; b=DZl6vBDD3cI5X4l/zEWL68xJBKeW3NDyLEBz5iFUgJ2b0GwNooMz2xHgf+iIuIW8/7 x1EKsMMIT1BOYbYgfwIzElQLEOzM1+NEvXEMtVBDkvWEU2IWHd3NQ0dxZ55STdBT7y35 INkvqa9VdBifBMxrXBHngIpmRR3PEvYpv96hIRn5s+dJYRWq14Tby8ItaM/RHVoHFQ5T fniaJaA5Xej2EdJUmIQ8LIrWChG0962ZE2flNzm9AKMI8JKoKvNgWQUtxDnDBGpxeOTD Z2PD2d6zaR80NCvMoCo8V40c6qTcxyRzbeLd7l8zbGqLruQUQIUI+V1bmE+ICSzzPbq1 Os0w== X-Gm-Message-State: APzg51APDx2DiQysOH9FS6iuXRmkyHjj/JrIkFHcJDiN6KPNUWZ1qFxD 0+wUIE7AHLR7qb11ZrBaxic= X-Received: by 2002:a37:1599:: with SMTP id 25-v6mr16312321qkv.245.1535419476182; Mon, 27 Aug 2018 18:24:36 -0700 (PDT) Received: from Salils-Air.fios-router.home (pool-100-35-223-222.nwrknj.fios.verizon.net. [100.35.223.222]) by smtp.gmail.com with ESMTPSA id g14-v6sm588486qtc.66.2018.08.27.18.24.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Aug 2018 18:24:35 -0700 (PDT) Date: Mon, 27 Aug 2018 21:24:34 -0400 From: Salil Kapur To: gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] USB: Removing NULL check for pool since dma_pool_destroy is safe Message-ID: <20180828012434.GA19415@Salils-Air.fios-router.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Removing NULL check for pool since dma_pool_destroy is safe Signed-off-by: Salil Kapur --- drivers/usb/core/buffer.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/usb/core/buffer.c b/drivers/usb/core/buffer.c index 77eef8acff94..f641342cdec0 100644 --- a/drivers/usb/core/buffer.c +++ b/drivers/usb/core/buffer.c @@ -101,12 +101,8 @@ void hcd_buffer_destroy(struct usb_hcd *hcd) return; for (i = 0; i < HCD_BUFFER_POOLS; i++) { - struct dma_pool *pool = hcd->pool[i]; - - if (pool) { - dma_pool_destroy(pool); - hcd->pool[i] = NULL; - } + dma_pool_destroy(hcd->pool[i]); + hcd->pool[i] = NULL; } } -- 2.14.4