Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp6813210imm; Tue, 28 Aug 2018 01:12:59 -0700 (PDT) X-Google-Smtp-Source: ANB0VdbugRWuehL1AeCDuBQfis7Jir9Myko6sr+BuZWxoJop24qvnXyOaghMCQB3ENhKi5swe0cF X-Received: by 2002:a63:a053:: with SMTP id u19-v6mr472773pgn.394.1535443979525; Tue, 28 Aug 2018 01:12:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535443979; cv=none; d=google.com; s=arc-20160816; b=fanEtAz5OS/AjhrMRfJhTUognWT9EnyQ/j6Dj2wrWAR86zBpuohHWj/QXU/tcEIDrB VIUv9e9lzBU97E/bViRuV0MubiEVd6Co0hZDwotIkoW99ZfA/qTi/AGzzZ7M1csGUWxR pUXpsW84G06F9SLCelZ56wa40bcRAQifzpfy1yz7SUUagEBxe95+PcETfUJ7QayAmG7L XMmSp1fqvx3p01UVbgnfTYcecsLYquup1qpgXtzpPTUx3zFMahp1nOBcOCSzaPulOccD rpnzh/n6UHw6CC+tPz5D5J3wRbTHdJC90sL4BKHpO6jajmjwlYh9iOgv2mKqgURyePjV FOgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=A5MwpX51H3caeXHi2l546BikiZXGyjgenkjfml96O34=; b=EKxVVwxjbxel2iDEiCwE+Hu6TvWpyz1Tdskn4ZxAZvChCVeY3bSZGNoFT49ufgLeWI BNQFtLByh1Tt7yCFZR3ycbMwMmpWYkXmSbRqaswQ5sYVtbolq20LaVp1d0Bc9cXf63Pr koOblnYhrGGpqlr3z5k7lgyhOswSzm1gU1tN11INd4p+eHjt/ZP6ga1Z/3mqMZTHUryF oUErkiLdzUm3XIWUujyR8lDRF02ua/P+xTWC6O+uK6KLcGJMeiToDr0WAWmrlLjAXG8Y SKrfogf9Mwbhtn6z69TfFFDx7oI5Ju4ymXamqxcLJUWRnNKJlzsoB5p1SYTIjVaBQcVv hs7g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d1-v6si436115pla.103.2018.08.28.01.12.43; Tue, 28 Aug 2018 01:12:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727176AbeH1MB7 (ORCPT + 99 others); Tue, 28 Aug 2018 08:01:59 -0400 Received: from mga05.intel.com ([192.55.52.43]:6674 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726806AbeH1MB7 (ORCPT ); Tue, 28 Aug 2018 08:01:59 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Aug 2018 01:11:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,298,1531810800"; d="scan'208";a="66537614" Received: from jsakkine-mobl1.fi.intel.com (HELO localhost) ([10.237.66.39]) by fmsmga008.fm.intel.com with ESMTP; 28 Aug 2018 01:11:24 -0700 Date: Tue, 28 Aug 2018 11:11:23 +0300 From: Jarkko Sakkinen To: Dave Hansen Cc: x86@kernel.org, platform-driver-x86@vger.kernel.org, sean.j.christopherson@intel.com, nhorman@redhat.com, npmccallum@redhat.com, linux-sgx@vger.kernel.org, Haim Cohen , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Borislav Petkov , Konrad Rzeszutek Wilk , Tom Lendacky , Paolo Bonzini , David Woodhouse , Greg Kroah-Hartman , Janakarajan Natarajan , Matt Turner , Andy Lutomirski , "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" Subject: Re: [PATCH v13 05/13] x86/msr: Add SGX definitions to msr-index.h Message-ID: <20180828081123.GF15508@linux.intel.com> References: <20180827185507.17087-1-jarkko.sakkinen@linux.intel.com> <20180827185507.17087-6-jarkko.sakkinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 27, 2018 at 12:42:32PM -0700, Dave Hansen wrote: > On 08/27/2018 11:53 AM, Jarkko Sakkinen wrote: > > @@ -866,10 +867,9 @@ void get_cpu_cap(struct cpuinfo_x86 *c) > > } > > } > > > > - /* Intel SGX features: level 0x00000012 */ > > - if (c->cpuid_level >= 0x00000012) { > > - cpuid(0x00000012, &eax, &ebx, &ecx, &edx); > > - > > + /* Intel SGX features */ > > + if (c->cpuid_level >= SGX_CPUID) { > > + cpuid(SGX_CPUID, &eax, &ebx, &ecx, &edx); > > c->x86_capability[CPUID_12_EAX] = eax; > > } > > This hunk has no apparent connection to the changelog. Thanks for catching this, the same squashing mistake :-) /Jarkko