Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp7281565imm; Tue, 28 Aug 2018 09:15:22 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYIjo2NeqkVRb0OpdhojY8cbqG5uxrLtVLiYiPFKGaHFOH8PGFCf9cg8xwrxDWqDDRWI7JR X-Received: by 2002:a17:902:1d4a:: with SMTP id u10-v6mr2203415plu.267.1535472922845; Tue, 28 Aug 2018 09:15:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535472922; cv=none; d=google.com; s=arc-20160816; b=f98HmuRM7Wnvy+P6t437srFpFd6aj5LBO1cHd91yQ9ukS09fKzTYvFXEiowjJ22/4B QMAYRBu/YPFcKyS5Ly25iBGJ72gsy3VAMBQoTkHyAK0Kja/gVj3uDLvS5rmBaaMtuo4s USp3eVvVwK4ZLpODWvpQXqE4biUWDA3eSOvXagb4ZXFTo2A/vDZ0AzhOsxFywqkbnJuY iwaix4QCzTnorN2hQwQxruHY8jx4Ix3TlKXnPzMAPXORbxRf4SSbVJqxI0hO1e/3bNJ2 qLfj93oWxWBbu8qq8oDKu2IUp9c/X+7Ounrf/BUgR+AqV1+YE5+/AYzK1l9WwyecPyGO Ua6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=d/aQU3gGWveB4HYm0LC4xcMyn1mht7hnjC3otT8TcE0=; b=p5Bz0qF2SnkRFgvat0BenDYtm4gSDF9/4MLNRuq/Hwk9Kj1y/0pHZPxfZKq/Wa55Ir 1Q8JfVqvCKLRd4N+apFsX+BHZgeHcrGr+YXTXmIlViIN1VgzGs9S8azZZZWTucnMX5fc +5VZDrlkI7p0YhkxJ+WI3M2r3EB4uvVU/ZFjJSWAzNueKxBxg26vp3YxIR9U9EwXU+On VKTrO84WZ9aOqBy2NxGFLbvtxLLo9x+7t3ry/90bZd9uLF/xDq/8MH8JMDffVdx1Hk6R kbzokQ/jC8noh9AbvkalPe3Ey/kfrmXNbUE7OIGItzdXn5ZskXc+HL3vQ8lK7bOWFO0a c9Aw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=H6QYq6Ci; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j14-v6si1447650pgh.22.2018.08.28.09.15.07; Tue, 28 Aug 2018 09:15:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=H6QYq6Ci; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727333AbeH1UGR (ORCPT + 99 others); Tue, 28 Aug 2018 16:06:17 -0400 Received: from mail-it0-f67.google.com ([209.85.214.67]:54128 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726975AbeH1UGR (ORCPT ); Tue, 28 Aug 2018 16:06:17 -0400 Received: by mail-it0-f67.google.com with SMTP id p79-v6so3459704itp.3 for ; Tue, 28 Aug 2018 09:13:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=d/aQU3gGWveB4HYm0LC4xcMyn1mht7hnjC3otT8TcE0=; b=H6QYq6Ci39eCdlt9VxkUsT6znYjDbdJZ3XHOxaDTQK0i1dIYH5IV8DmduCJW4u5kJZ goA99tReOGpdMg9wEmHgh+uB/x4PFwptUVkqti8k4etSeAotLrrEEnKjMafAAp22bwJ1 fuzLSwTm8Zb5M0LH3DVuFyFmFE8yEhhsPioJ1E1E99+tYuGzxMCCG8XvbX6ByqzFeHz4 9QVOysSq4K39lRy+pwzV+mbafA5Idm7gRKvhVJjUDrJ+czfWcqwIDzIourt7Ec3v7d3Y Iiu4It1IjLVykieW19LWRIXsczdkXCBXHkFo8BO//6Wg7HXzak7qx6YZiRlSrzlYH4kq /bNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=d/aQU3gGWveB4HYm0LC4xcMyn1mht7hnjC3otT8TcE0=; b=PZmebnQcX2Bf4Dw1UbJwlxAm9OpwEqK2sP+ah9nfQBlmf2pp+xfWFi+eZIW3iE7Pd7 EC2YKdbpbg49gYbqjvglzD9BhTApdGK7MVSOnwiH1FAhn2PPCXDMDNtgNDV2qqNx8A8K RFGQSQySYhzr47VZaBvQJcn48u0+rFQaS08kSRdRhLnH6aIuF0lwakxnzrGwdtQxsfnE RO1msDgTcVa1oBWO3OYFrgXWsInzsbTzFChTaV3qpFuOKnaNuAb1UtT2o65hTsd3o4nz qj3izy7kB0kf3nFqeiPgar6rcIQVakokThOHue+oac7+yGPdpKEARup4Z4nrZoj80SiD AQ2Q== X-Gm-Message-State: APzg51CWYyvgu4iyEaDnHWDZu2PbdBBN7IL3VbX3Mv5+ykMl0ZRvauTb CGUvTikxy/h99+SV1T0kj+Sq64u62O8= X-Received: by 2002:a24:9787:: with SMTP id k129-v6mr2129967ite.51.1535472833632; Tue, 28 Aug 2018 09:13:53 -0700 (PDT) Received: from [192.168.1.56] ([216.160.245.98]) by smtp.gmail.com with ESMTPSA id n198-v6sm893770itn.36.2018.08.28.09.13.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Aug 2018 09:13:51 -0700 (PDT) Subject: Re: [PATCH] Revert "blk-mq: issue directly if hw queue isn't busy in case of 'none'" To: Ian W MORRISON Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, kashyap.desai@broadcom.com, loberman@redhat.com, osandov@fb.com, hch@lst.de, bart.vanassche@wdc.com, hare@suse.de, ming.lei@redhat.com References: <20180828154727.3589-1-ianwmorrison@gmail.com> <211633e2-a812-d489-e11c-c3f271c465fc@kernel.dk> <1cbdba28-3ff5-2bbe-a2cf-b533249c6970@kernel.dk> From: Jens Axboe Message-ID: <853d7213-c6ce-5de9-6c83-806c3b8f18ca@kernel.dk> Date: Tue, 28 Aug 2018 10:13:50 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/28/18 10:10 AM, Ian W MORRISON wrote: > On Wed, 29 Aug 2018 at 02:09, Jens Axboe wrote: >> >> On 8/28/18 10:07 AM, Ian W MORRISON wrote: >>> On Wed, 29 Aug 2018 at 01:48, Jens Axboe wrote: >>>> >>>> On 8/28/18 9:47 AM, Ian W MORRISON wrote: >>>>> Kernel oops when booting on Bay and Cherry Trail devices >>>>> such as Intel Compute Stick. Bisected as: >>>>> >>>>> commit 6ce3dd6eec11 ("blk-mq: issue directly if hw queue isn't busy in case of 'none'") >>>>> >>>>> This patch reverts the above commit. >>>> >>>> Did I miss the posting of that oops? Just curious where this is >>>> going wrong. Not adverse to reverting, but I'd like to try to >>>> understand the issue first. >>>> >>>> -- >>>> Jens Axboe >>>> >>> >>> I've not been able to capture it however manually transcribing what is >>> on the screen: >>> >>> mmc0: Got data interrupt 0x00000002 even though no data operation >>> >>> followed by: >>> >>> mmc0: sdhci: ============= SDHCI REGISTER DUMP ============== >>> >>> Do you want any specific register value or should I transcribe each >>> (as I am working from an image taken at boot)? >> >> Just take a picture of the screen, that should be good enough. >> >> -- >> Jens Axboe >> > > Attached as requested. Can you see if this patch helps? https://marc.info/?l=linux-mmc&m=153485326025301&w=2 -- Jens Axboe