Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263178AbTKCRTa (ORCPT ); Mon, 3 Nov 2003 12:19:30 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263189AbTKCRTa (ORCPT ); Mon, 3 Nov 2003 12:19:30 -0500 Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:11150 "EHLO www.linux.org.uk") by vger.kernel.org with ESMTP id S263178AbTKCRT2 (ORCPT ); Mon, 3 Nov 2003 12:19:28 -0500 Date: Mon, 3 Nov 2003 17:19:25 +0000 From: viro@parcelfarce.linux.theplanet.co.uk To: Linus Torvalds Cc: Konstantin Boldyshev , Kernel Mailing List , marcelo.tosatti@cyclades.com Subject: Re: minix fs corruption fix for 2.4 Message-ID: <20031103171925.GH7665@parcelfarce.linux.theplanet.co.uk> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 835 Lines: 20 On Mon, Nov 03, 2003 at 08:55:42AM -0800, Linus Torvalds wrote: > I'd also prefer to do the test the other way around: test for CHRDEV and > BLKDEV in inode.c the same way the other functions do. Something like the > appended.. > > Al, can you verify? I think this crept in when you did the block lookup > cleanups. I also worry whether anybody else got the bug? > > Linus Hmm... I would rather check for regular|directory|symlink explicitly - note that FIFO and socket can have junk in i_data. Looks like that fsckup had happened only in fs/minix - fs/sysv/itree.c does it right. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/