Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH V2] xen: export device state to sysfs
To:     Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Juergen Gross <jgross@suse.com>,
        Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <c7cfcd6d-5245-b82f-781f-32bddec5aeab@oracle.com>
 <6cccd58c-f962-ac4b-bfb4-08df8432f4e5@oracle.com>
From:   Joe Jin <joe.jin@oracle.com>
Message-ID: <cb9d797b-0df1-8bb2-93b3-34caf6da6f30@oracle.com>
Date:   Tue, 28 Aug 2018 10:14:05 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <6cccd58c-f962-ac4b-bfb4-08df8432f4e5@oracle.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 8/28/18 9:53 AM, Boris Ostrovsky wrote:
> On 08/28/2018 10:56 AM, Joe Jin wrote:
>> Export device state to sysfs to allow for easier get device state.
>>
>> Signed-off-by: Joe Jin <joe.jin@oracle.com>
>> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>> Cc: Juergen Gross <jgross@suse.com>
>> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>> ---
>>  Documentation/ABI/stable/sysfs-bus-xen-backend | 9 +++++++++
>>  drivers/xen/xenbus/xenbus_probe.c              | 9 +++++++++
>>  2 files changed, 18 insertions(+)
>>
>> diff --git a/Documentation/ABI/stable/sysfs-bus-xen-backend b/Documentation/ABI/stable/sysfs-bus-xen-backend
>> index 3d5951c8bf5f..e8b60bd766f7 100644
>> --- a/Documentation/ABI/stable/sysfs-bus-xen-backend
> 
> 
> Won't this show up in the frontend as well?

Yes it will, current there is no any ABI document for xen-frontend.

Thanks,
Joe
> 
> -boris
> 
>> +++ b/Documentation/ABI/stable/sysfs-bus-xen-backend
>> @@ -73,3 +73,12 @@ KernelVersion:	3.0
>>  Contact:	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>>  Description:
>>                  Number of sectors written by the frontend.
>> +
>> +What:		/sys/bus/xen-backend/devices/*/state
>> +Date:		August 2018
>> +KernelVersion:	4.19
>> +Contact:	Joe Jin <joe.jin@oracle.com>
>> +Description:
>> +                The state of the device. One of: 'Unknown',
>> +                'Initialising', 'Initialised', 'Connected', 'Closing',
>> +                'Closed', 'Reconfiguring', 'Reconfigured'.
>> diff --git a/drivers/xen/xenbus/xenbus_probe.c b/drivers/xen/xenbus/xenbus_probe.c
>> index f2088838f690..5b471889d723 100644
>> --- a/drivers/xen/xenbus/xenbus_probe.c
>> +++ b/drivers/xen/xenbus/xenbus_probe.c
>> @@ -402,10 +402,19 @@ static ssize_t modalias_show(struct device *dev,
>>  }
>>  static DEVICE_ATTR_RO(modalias);
>>  
>> +static ssize_t state_show(struct device *dev,
>> +			    struct device_attribute *attr, char *buf)
>> +{
>> +	return sprintf(buf, "%s\n",
>> +			xenbus_strstate(to_xenbus_device(dev)->state));
>> +}
>> +static DEVICE_ATTR_RO(state);
>> +
>>  static struct attribute *xenbus_dev_attrs[] = {
>>  	&dev_attr_nodename.attr,
>>  	&dev_attr_devtype.attr,
>>  	&dev_attr_modalias.attr,
>> +	&dev_attr_state.attr,
>>  	NULL,
>>  };
>>  
>