Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp7349723imm; Tue, 28 Aug 2018 10:25:08 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZJNiAquQz+HB65IzO5q/NZHkHqxnvYQridr7DcJsWePFQgpydkcYx9w86WY6kosWN23Um3 X-Received: by 2002:a65:650f:: with SMTP id x15-v6mr2465102pgv.127.1535477108690; Tue, 28 Aug 2018 10:25:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535477108; cv=none; d=google.com; s=arc-20160816; b=wcrh360bhFP6h1SV2BwBaEIDXnv0NOwHXDOQsE9HkJrIr04ZvjYMW7Oy9KF2EEVUEj tgCQObWsfT6uT+Mda6fPowboJezkvbxy2Zayx7jkhR3BmhNSOD1R5OVpYWZ6rbDpLfVn SmzY34GGG9BH0NJXakJWK/774EP1utmT8L6pQocRWNpFwJQHWAUOHh24w16DYk4+oivV Dekoh7+erfFOtw5A0ocX22i3frOc6+6upcmBT7WF/3on9Z4xRvNw24GCU8/OQnbtjWP7 /Yf5jiIG4y2kJfG224U7ufhdTYL8m6Y4f3o3xAxgHmfHNjvb1LEi1CxA/4pUFrUMTIsd UijQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=/su2Xrr3lQDX5ALOohq5KkDM3OQAwHC1+exX8OmH6ME=; b=wKXP9cnM4PPCRsaHGDusC//AD1BPMueQZfAn+0r0JddrtmIoz3abFEf8aHQwYlLDbq 4CRUvYxH1NXIxH50GonzrHV76D1OD8zi/lvcRbTy7XGNtGnYzDnpGEYFMDPmWvAXwhxD LicZyTQpys0PE3XgrafGMT1xtDNekwGAtjOPirM8RZhoIM77euCp0Ga0Br7PblQF4Wz1 2Ik05iFpii/HL34kwun/Og7tT6424Sb+OXOP/JIZRF3hTQN9lammRJa/Ojt/duTNtk5z f+sa3C1I6hnm7fysM0tGH5pOqv0UUL6sYQgclXOh8rnh11mGMiePtkicfLamulJZIUtN Gahg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=i3VAVTEl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o20-v6si1568491pgh.319.2018.08.28.10.24.53; Tue, 28 Aug 2018 10:25:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=i3VAVTEl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727687AbeH1VQN (ORCPT + 99 others); Tue, 28 Aug 2018 17:16:13 -0400 Received: from mail-yw1-f66.google.com ([209.85.161.66]:34548 "EHLO mail-yw1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727636AbeH1VQM (ORCPT ); Tue, 28 Aug 2018 17:16:12 -0400 Received: by mail-yw1-f66.google.com with SMTP id y134-v6so892920ywg.1 for ; Tue, 28 Aug 2018 10:23:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=/su2Xrr3lQDX5ALOohq5KkDM3OQAwHC1+exX8OmH6ME=; b=i3VAVTElMSCvpvFUYOOStTltjA1/oebEvqEJgK2PA6DvRgVyiCOVmImPqaMHV76+HV VddU83sXNka2uP8uLhNarc3C2lzzvrReI+SbDrvTyIXsP1XFvdHCxca7/vPI1SBidGlY buQn7ZBYitfoffhdVUWFbLr+vurVJdCSRIuSjGWsRt7YkzUPvXNnKxEuNrJs5pgfggwY RrZ91V0TriiZsSKvcbz+7lBp8vJzlG7ATC8Hzb9YU5vFngGZvk7zApkQC2o8nIfrmqQF qtOwuR2A4xmDAYtk1lC721AXu4fK7f3FTCAYfodsCKjMhevrxlO/tVrioleIU4YRkO5d Luaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=/su2Xrr3lQDX5ALOohq5KkDM3OQAwHC1+exX8OmH6ME=; b=TTM8Kpds844M/f/6N9lJFgVGBtfg7kYH4hR4o7d0NEQwu8s6o6bIVavZxZmg1ATFSB GqBu7Hy/JJIVJL20wAzB+IIoPDHqKy9NAcuuMUBt9ZPjB0ZFCi7WfSzUI4nF1gxfOreH MVKxXcgeW4qZeKhB73sqGzh+8mmmtvwxoUO4g3XINguHlVOoDTFWVKMpalz2bGKveFNc DAuW0roxMy+V3TxOoq07w49JS3ThZhlXbZ9Q9vujp8uwoIEWqU3xtSPdqql3aocK7xti zTIK1LzWrixhuHR8e4Mwcu+FtQxJtUBXUISWP7f2V/MxvJFVh13xeb1ndgWGgBaljEVD RJYg== X-Gm-Message-State: APzg51CVdmjbBP/D3PXfneAVt38WbNEbkFgSj8AR2xamCoTCRHJZFVPo uhtU14Z6afRtxswikCoyzlZIQQ== X-Received: by 2002:a0d:cb88:: with SMTP id n130-v6mr1380569ywd.243.1535477013307; Tue, 28 Aug 2018 10:23:33 -0700 (PDT) Received: from localhost ([2620:10d:c091:200::1:de86]) by smtp.gmail.com with ESMTPSA id r3-v6sm675063ywr.80.2018.08.28.10.23.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 28 Aug 2018 10:23:32 -0700 (PDT) From: Johannes Weiner To: Ingo Molnar , Peter Zijlstra , Andrew Morton , Linus Torvalds Cc: Tejun Heo , Suren Baghdasaryan , Daniel Drake , Vinayak Menon , Christopher Lameter , Peter Enderborg , Shakeel Butt , Mike Galbraith , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: [PATCH 7/9] sched: introduce this_rq_lock_irq() Date: Tue, 28 Aug 2018 13:22:56 -0400 Message-Id: <20180828172258.3185-8-hannes@cmpxchg.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180828172258.3185-1-hannes@cmpxchg.org> References: <20180828172258.3185-1-hannes@cmpxchg.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org do_sched_yield() disables IRQs, looks up this_rq() and locks it. The next patch is adding another site with the same pattern, so provide a convenience function for it. Signed-off-by: Johannes Weiner --- kernel/sched/core.c | 4 +--- kernel/sched/sched.h | 12 ++++++++++++ 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index fe365c9a08e9..61059e671fc6 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -4960,9 +4960,7 @@ static void do_sched_yield(void) struct rq_flags rf; struct rq *rq; - local_irq_disable(); - rq = this_rq(); - rq_lock(rq, &rf); + rq = this_rq_lock_irq(&rf); schedstat_inc(rq->yld_count); current->sched_class->yield_task(rq); diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index eb9b1326906c..83db5de1464c 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -1126,6 +1126,18 @@ rq_unlock(struct rq *rq, struct rq_flags *rf) raw_spin_unlock(&rq->lock); } +static inline struct rq * +this_rq_lock_irq(struct rq_flags *rf) + __acquires(rq->lock) +{ + struct rq *rq; + + local_irq_disable(); + rq = this_rq(); + rq_lock(rq, rf); + return rq; +} + #ifdef CONFIG_NUMA enum numa_topology_type { NUMA_DIRECT, -- 2.18.0