Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp7524813imm; Tue, 28 Aug 2018 13:46:21 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZ9yRn2CbZk+Lwjky4fWo7WFp5C3TO1xBbV6bAb10RLGUamzREwkFP5UM9oy3K2wErk/oxO X-Received: by 2002:a63:550b:: with SMTP id j11-v6mr1494441pgb.167.1535489181200; Tue, 28 Aug 2018 13:46:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535489181; cv=none; d=google.com; s=arc-20160816; b=WijV5EEpHhkvHW5rBwg++fTF09slBam94yzpKWgnrYJUvsrjnZjkbRUfHddjTDDhLg TD2uMZY5vsEatWuPINvhBy7AQv4mChGn3u4cpZrh8MrWHxNAgfrcHZMywe36aUa+QrHD U0QWrrY1SrrYhQaoEHIqh36JObg8Gy3BrDKc+332T57X3ScAB/iJuPcyenrMZOwEnh5H 82r/npdpHGogsBNSUKVXrYwlCCU3fTJykRIKqyhbsHyxMG4WQpVKZgvUM27drOiHKOV2 fz+9rB4+CSrkdmmtl5uXbku7DzJoDoKEZrBGfMg+WO+tjPNCKJsbie5fFcgSph94urkX jQZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=on8rNc/xblfTuccF0SfsmtBI4KCbZGqHG7iz90qLQks=; b=y8Ne0nvkPqTEl1hxPxI8HwfS8ZTISnL27MxnICIP1wFGEYDb91RR6/WeeYMXexSlUW D3Zv1VZXs1ZXTsU1JNw6Z8lGfYOoo9nC7dEsrNdOahEoLfbnj0NO4R/RNZVM4fpZ48qQ 29nviqTEO+Teq+u6xi04bTUEJRyyhk/MqOKj6tOL/pdsvw+sVjBn0y6J7kwSL4+JxFTA Gbsaj38oMvDvC/TaS0EEWMvmonua9ScCSzAr1t3Q9aqre2w1KvtZor1tCXvIuY2t+VLH m3j0Ly4VZJXfEvRonjbzIhKFCTxBmGk9/gkMW1wuMLJdEQid4Legwrb3S7l4ijqCq3+Q W5Lw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ca14-v6si2072704plb.438.2018.08.28.13.46.05; Tue, 28 Aug 2018 13:46:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727474AbeH2AhU (ORCPT + 99 others); Tue, 28 Aug 2018 20:37:20 -0400 Received: from mail.ispras.ru ([83.149.199.45]:46144 "EHLO mail.ispras.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726998AbeH2AhU (ORCPT ); Tue, 28 Aug 2018 20:37:20 -0400 Received: from localhost.localdomain (ppp85-140-182-184.pppoe.mtu-net.ru [85.140.182.184]) by mail.ispras.ru (Postfix) with ESMTPSA id D6E0954008A; Tue, 28 Aug 2018 23:43:56 +0300 (MSK) From: Alexey Khoroshilov To: Hoan Tran , Linus Walleij Cc: Alexey Khoroshilov , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org Subject: [PATCH] gpio: dwapb: Fix error handling in dwapb_gpio_probe() Date: Tue, 28 Aug 2018 23:40:26 +0300 Message-Id: <1535488826-30200-1-git-send-email-khoroshilov@ispras.ru> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If dwapb_gpio_add_port() fails in dwapb_gpio_probe(), gpio->clk is left undisabled. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/gpio/gpio-dwapb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c index 28da700f5f52..044888fd96a1 100644 --- a/drivers/gpio/gpio-dwapb.c +++ b/drivers/gpio/gpio-dwapb.c @@ -728,6 +728,7 @@ static int dwapb_gpio_probe(struct platform_device *pdev) out_unregister: dwapb_gpio_unregister(gpio); dwapb_irq_teardown(gpio); + clk_disable_unprepare(gpio->clk); return err; } -- 2.7.4