Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp247826imm; Tue, 28 Aug 2018 22:08:20 -0700 (PDT) X-Google-Smtp-Source: ANB0VdaBOhzRs2L86SSRVbJtXAXEfWmEN3d5IBEKs0GnOPqEWdbtESO09u7MaBLUWtn2jy38SbMX X-Received: by 2002:a17:902:934a:: with SMTP id g10-v6mr4359164plp.121.1535519300053; Tue, 28 Aug 2018 22:08:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535519300; cv=none; d=google.com; s=arc-20160816; b=ju/P6U0WVBBtWKn1k24SK4x45VKklyi01tbcUtsgkpvDn1kSJnfxaI7JHhuYXrNWo0 uhXUpV/HK4SPlbUKfrJiWHKPLTtpB5x9skbSnW+r/UDKP7dtmLTVd2y3BEQLKvP6qWqx XKMNA2OQeEgPkKtPGQMOQ2TVj7gp70RCqmEX/jDevpWHFv/EaLlUmGKWIRzHymMi5BWW RgEdyTyzbVHqToFnbDujPVRG4h9YHa4DPQWY874l77bSam9K/MWraug42jB96Qt9lfam aNnBkCOOZnxdsx7mNlG/fjzb680Tzhu4kLUeg+MfVJsOlk2QxQD1bO5Dtq8gahDVtSX0 mqmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature :arc-authentication-results; bh=9I3xKe+TNiLVnmaTxN+Ip94t7VZ2Wt+gZjLJ2Brw1lo=; b=Y0UScxpVJUnhHuV0ltYJO178sLbLRDKVDFvXxpLHvg2DnOu/+k8UPJXJoIju7gwUqH OlzQVAZlldF0KGtuaCmJnpHUZ5idJNLv42NZe1wpTAXFSh+5l5w9bOK5WtzEyAD/fRen OKmxt/5oOiZd6ik3JhAaK3Lg/F1yIfVR8DZsXyTrKv2yoeVKPX1a/3WYuw/yeuoAZU8O 1bZN3Vuz3721w/C9E8FRAsncxFKARROfD33xue+x0PpCTJ77YVS7v3PtlCJcL1a+ZF57 KafdQD18RoPpzGYca63sipjo9GCVBBz3xVYnNj+9HE+7EHfirzAjzA6QjR3yCWHDgjq1 dKEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@zx2c4.com header.s=mail header.b=r5BcZn0k; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w31-v6si2876875pla.133.2018.08.28.22.08.04; Tue, 28 Aug 2018 22:08:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@zx2c4.com header.s=mail header.b=r5BcZn0k; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727322AbeH2JCB (ORCPT + 99 others); Wed, 29 Aug 2018 05:02:01 -0400 Received: from frisell.zx2c4.com ([192.95.5.64]:57495 "EHLO frisell.zx2c4.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726209AbeH2JCB (ORCPT ); Wed, 29 Aug 2018 05:02:01 -0400 Received: by frisell.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 2f7ee2f3; Wed, 29 Aug 2018 04:51:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=zx2c4.com; h=mime-version :references:in-reply-to:from:date:message-id:subject:to:cc :content-type; s=mail; bh=+/H235g0EyT+zZXsuxyqRNYzH4I=; b=r5BcZn 0k79Hmo8EzxlHhoarKL8Il0ewuRMSPzO90o8pA2pH6ENw5IRjQQuztommK1LOiNh 3ShuY5Y2p6lYvqvUHHwCvydbhMcsHByd6bbPQ/iEJG69OQ6vCyKn7nL03TK5lEve zzJO+DRxBtB3OV8lOagh3S31/N/1yool5dNtdSCiJwFXIjyoMuiLhR+ADA+Tqyxh 0y7NQCeRAU2uST6JnuwZ6VN+P2uigiC+x2qW/fKT5d3ZlVQsM0xUd5iy0riCkBXh OfjaHZJLyk4kUIHoN0ND7WQDajCdYsOKEMawwFXQ8ZoGSN+e62fXRA4HNWujnXK1 IWNh2e7EqvZSgfGg== Received: by frisell.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 3a384976 (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128:NO); Wed, 29 Aug 2018 04:51:56 +0000 (UTC) Received: by mail-oi0-f49.google.com with SMTP id b15-v6so6941441oib.10; Tue, 28 Aug 2018 22:06:55 -0700 (PDT) X-Gm-Message-State: APzg51A8e2pHLG2wRJTqgiEXQz1VY8lOxDidUHL6XtYPwFGwDYXU3yDD LbseBHqmYgzcWEpC7eaN1kEJYmciDai6MgDh0rU= X-Received: by 2002:aca:2e86:: with SMTP id u128-v6mr1138879oiu.132.1535519213446; Tue, 28 Aug 2018 22:06:53 -0700 (PDT) MIME-Version: 1.0 References: <20180824213849.23647-1-Jason@zx2c4.com> <20180824213849.23647-16-Jason@zx2c4.com> In-Reply-To: From: "Jason A. Donenfeld" Date: Tue, 28 Aug 2018 23:06:42 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 15/17] zinc: Curve25519 ARM implementation To: Ard Biesheuvel Cc: LKML , Netdev , David Miller , Andrew Lutomirski , Greg Kroah-Hartman , Samuel Neves , "Daniel J . Bernstein" , Jean-Philippe Aumasson , Russell King - ARM Linux , linux-arm-kernel@lists.infradead.org, Linux Crypto Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hey Ard, Thanks for the thorough review. Very much appreciated. I've incorporated nearly all of your suggestions into my development tree: https://git.kernel.org/pub/scm/linux/kernel/git/zx2c4/linux.git/tree/lib/zinc/curve25519/curve25519-arm.S?h=jd/wireguard These changes will be part of v3. Regards, Jason