Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Wed, 29 Aug 2018 12:43:28 +0530
From:   kgunda@codeaurora.org
To:     Bjorn Andersson <bjorn.andersson@linaro.org>
Cc:     jingoohan1@gmail.com, lee.jones@linaro.org,
        b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org,
        daniel.thompson@linaro.org, jacek.anaszewski@gmail.com,
        pavel@ucw.cz, robh+dt@kernel.org, mark.rutland@arm.com,
        linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
        linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH V5 8/8] backlight: qcom-wled: Add auto string detection
 logic
In-Reply-To: <20180827145420.GL3048@tuxbook-pro>
References: <1535106467-17843-1-git-send-email-kgunda@codeaurora.org>
 <1535106467-17843-9-git-send-email-kgunda@codeaurora.org>
 <20180827145420.GL3048@tuxbook-pro>
Message-ID: <f6e6baa748d73b68c1cbcc5d955df471@codeaurora.org>
User-Agent: Roundcube Webmail/1.2.5
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2018-08-27 20:24, Bjorn Andersson wrote:
> On Fri 24 Aug 03:27 PDT 2018, Kiran Gunda wrote:
>> diff --git a/drivers/video/backlight/qcom-wled.c 
>> b/drivers/video/backlight/qcom-wled.c
> [..]
>>  struct wled {
>> @@ -135,16 +146,22 @@ struct wled {
>>  	struct regmap *regmap;
>>  	struct mutex lock;	/* Lock to avoid race from thread irq handler */
>>  	ktime_t last_short_event;
>> +	ktime_t start_ovp_fault_time;
>>  	u16 ctrl_addr;
>>  	u16 sink_addr;
>>  	u16 max_string_count;
>> +	u16 auto_detection_ovp_count;
>>  	u32 brightness;
>>  	u32 max_brightness;
>>  	u32 short_count;
>> +	u32 auto_detect_count;
>>  	bool disabled_by_short;
>>  	bool has_short_detect;
>> +	int ovp_irq;
>> +	bool ovp_irq_disabled;
> 
> ovp_irq_disabled is now only assigned, never read. So you should be 
> able
> to drop it.
> 
Ok. will address in next series.
> [..]
>> @@ -200,7 +226,18 @@ static int wled_module_enable(struct wled *wled, 
>> int val)
>>  				WLED_CTRL_REG_MOD_EN,
>>  				WLED_CTRL_REG_MOD_EN_MASK,
>>  				val << WLED_CTRL_REG_MOD_EN_SHIFT);
>> -	return rc;
>> +	if (rc < 0)
>> +		return rc;
>> +
>> +	if (val) {
>> +		schedule_delayed_work(&wled->ovp_work, HZ / 100);
> 
> wled_ovp_work() is a nop when ovp_irq == 0, so wrap the entire if/else
> in a check for ovp_irq > 0 (rather than include it in the else) and 
> drop
> it from the worker.
> 
Will address in next series.
>> +	} else {
>> +		if (!cancel_delayed_work_sync(&wled->ovp_work) &&
>> +		    wled->ovp_irq > 0)
>> +			disable_irq(wled->ovp_irq);
>> +	}
>> +
>> +	return 0;
> 
> Also, if a user calls rmmod within 10ms of enabling module we will
> schedule work of code that's no longer available in the kernel. So you
> need to also cancel_delayed_work_sync() in the remove function of the
> driver.
> 
> 
Will address in next series.
> Apart from this I think this patch looks good now!
> 
Thank you
> Regards,
> Bjorn