Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp328005imm; Wed, 29 Aug 2018 00:45:23 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZXIUPYGkCeRPcgn2ajKqXTcMTpxPwnvypERlMGwHzis9iZEKvqpZp4y/ua88NGTZR3Tcgl X-Received: by 2002:a63:ad07:: with SMTP id g7-v6mr4645812pgf.19.1535528723207; Wed, 29 Aug 2018 00:45:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535528723; cv=none; d=google.com; s=arc-20160816; b=SAiGw2oYnUFm5HvoV4T+35rZlNMUDtE55fSahJtIOwLK425/qFx/rWLaSTL0igIeIS 1BqHZaNiQC6EXekxNhYMhE20bs9U4nrjlQ0d7om/8aeW9KOvfWiq8dyXCUPgfhhbml2B o/aUWZMNcLw1PU7z1voITzk+mqOnIRJD3XGrexI6K1SiFOTwIiQUOsoCu5jbjsGp0/W1 3AbnrQmWH9ZPffTzQAdKG7t5L97uOs1wt4giQT9mhsIKL/B4mLtnvQI+pMLcySeNTfXW TrOMLWWsmLS51Qy29EJZwhs3v/l+Hzkk8xEC6HtPpxpZDAQ6zMUt9a8Hn1elJZh2jDuo yd+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature :arc-authentication-results; bh=4DDAKbSLrjPXiyeHhBKSLKKCWbarsLJa9tjcfedxeyo=; b=HT3NyChN6fv6iUzgU8zAE7H/+IR4PC0ivXpiV3fcqwuwhOQHHvWqWqqHJEZGYbH5A0 +jacIr9MvIvjOJz/S1ByOsfSJGD84PncjTXuCdyH2UoezHYKu91Gv4SUxeRX63ImWshm 0mQNXOZWmp1ZqQCLCrBQyBBBrKntaMjW3wKSe07YhYWnYd/Vfi87D+tNsI16iBaizza9 0Lj8+fWpNc2Q2b0WHZgp9m8WIEdgt8/TU1Ua6YeOvqjdM3332jVEMRvWTsYJmJi5iNVW zcysZ9Sb/pWp86NFJSyvkmySW69gR8AuLwUs+HVDyxomGMD7UCFNW9H5O/v2TvOwz0ry VVUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hgtRBHSD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h8-v6si3422485pli.14.2018.08.29.00.45.07; Wed, 29 Aug 2018 00:45:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hgtRBHSD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727755AbeH2LjO (ORCPT + 99 others); Wed, 29 Aug 2018 07:39:14 -0400 Received: from mail-it0-f67.google.com ([209.85.214.67]:38637 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727304AbeH2LjN (ORCPT ); Wed, 29 Aug 2018 07:39:13 -0400 Received: by mail-it0-f67.google.com with SMTP id p129-v6so6014918ite.3 for ; Wed, 29 Aug 2018 00:43:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4DDAKbSLrjPXiyeHhBKSLKKCWbarsLJa9tjcfedxeyo=; b=hgtRBHSDoKByIjcU5mivSShK1XfMgmRNlQ2yds1Q0yKt+OKOwnyoIYHEcOO+RcH90a Ln8CogLcPV3IMBQYYBMgR0xaHr6runmahyAUeC8iT1LVVcpzcmt0T//Dn8ShGjfTRMC3 5UYYidjPhyIxGKz8Vu8Hu36v9pOxbFmNtFd2g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4DDAKbSLrjPXiyeHhBKSLKKCWbarsLJa9tjcfedxeyo=; b=Q9wVPBiUglkhKM4xXl/dxsmS3sCSq65Nzbm2+TjmSUzoy6/VqSk8hLct1BAr2QYikr S7tIWl609bgaIPCfaS9aWdr+A1vVoI7S6opUdHqmw1nH/Y0fqXu0yO+7eFcFCJSQCN/6 G2IQ9QW431uMCaKd4IyfVHlkKrORA+kP28/rs3Bi3M0swqoymsmpLx/bxFkGoFYk1NTd 8PYQI2/2bCo+vbIQ8b4q5zYwqF9ClPYNjLyHwSeD5MEvk/hnkvF+76YsRWJHZuWpiiE7 0RUPQr1YGzy099f8aqZTzztrBYCkfkXNv5gzWrUEDKChOrxHrWtVzX1ZpC6je/gkyXd8 sDYg== X-Gm-Message-State: APzg51BcFuycvmdX///Johk1h2+K7pc5XwURf+x+fR3yHfQsRlW6Lwvx dhiLmfe1GGGTlcByGnRR2wIXg5+E6Gui6MU7FFcSxA== X-Received: by 2002:a24:144:: with SMTP id 65-v6mr4089951itk.62.1535528619556; Wed, 29 Aug 2018 00:43:39 -0700 (PDT) MIME-Version: 1.0 References: <20180816200648.90458-1-swboyd@chromium.org> <20180816200648.90458-4-swboyd@chromium.org> In-Reply-To: <20180816200648.90458-4-swboyd@chromium.org> From: Linus Walleij Date: Wed, 29 Aug 2018 09:43:27 +0200 Message-ID: Subject: Re: [PATCH v3 3/3] pinctrl: msm: Configure interrupts as input and gpio mode To: Stephen Boyd Cc: "linux-kernel@vger.kernel.org" , "open list:GPIO SUBSYSTEM" , linux-arm-msm@vger.kernel.org, Bjorn Andersson , Doug Anderson Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 16, 2018 at 10:06 PM Stephen Boyd wrote: > When requesting a gpio as an interrupt, we should make sure to mux the > pin as the GPIO function and configure it to be an input so that various > functions or output signals don't affect the interrupt state of the pin. > So far, we've relied on pinmux configurations in DT to handle this, but > let's explicitly configure this in the code so that DT implementers > don't have to get this part right. > > Cc: Bjorn Andersson > Cc: Doug Anderson > Signed-off-by: Stephen Boyd Patch applied for v4.20 with Bjorn's ACK. Yours, Linus Walleij