Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp338583imm; Wed, 29 Aug 2018 01:04:38 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZ2vTEiPk0Tm+AlsGZ9HtnncPoKpcwAFzRu5fxzvOBJouZPUtmIhpqXG/7xjF+qY1PjYx97 X-Received: by 2002:a62:e11:: with SMTP id w17-v6mr4907001pfi.242.1535529878263; Wed, 29 Aug 2018 01:04:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535529878; cv=none; d=google.com; s=arc-20160816; b=BHa7GE4jDD8wT1prdMqOrT9Znq1ytEhfh1Httc+307kd3AmawKklZ5e/Z3fcFfgkxs DwrsjegoOaajkH21FaSySKwItmHpVw9Mfp130cYnDftbTOlc9zgkZPuoF4u2vlyEx1RI DioVbXW9QfIr4ug+od4pLKZQ8DuCOT2XG3mxsyMcoMnu11ud6jcCSLdqQ3RcijnNo/7l SzsnGL/dI6Zn2Zw8YrS6gvWAbamd8IAlHuj+pbskLL0kbQ1s4tcm92LZgPpDACF6EZLT eNRwj2AOiEgyL2t8P/OU1LPhTXJz4hgxB5HA2k2ZiL3UluRkz5KFXtO+6TE1FRAHesun DkZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:arc-authentication-results; bh=ROh0EHp5rNqDUv6urGeVUTzSoqA6VJTBSjnz0TJQq24=; b=mUTFAj4/p9MfFjVc+U1wQbU6XYSv+Z2dDiD1f0Ac0UGs6CQn3m2iCdkFj+NBASLAJZ sqgk55kOGWfjTrhSySu7hMOPktCEUD2ZyNUEGTfWAlle86GHbeRBApfxwSEmlMOpOG0N sPqp7RO+rUFLmVrEd5bpURjpqPbPUQDPwWIAb5nTqKPiYAIu11kRIYvBRnM/YHHIyHlW 58jkIjURA2wgkRbkMJWDHCFgY8EKrjjpGzkfnsvR9cPc30IcMpGOtppDeKKSj5Y7GwL/ enhR3ktBp1G6r6dAs2C8svYtsAtsIRiygkX5ovjlk35rZOYQgGOMKkCbGrcUaq1CNWac gG7A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w11-v6si2510400pgm.616.2018.08.29.01.04.23; Wed, 29 Aug 2018 01:04:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727616AbeH2L6W (ORCPT + 99 others); Wed, 29 Aug 2018 07:58:22 -0400 Received: from mail.bootlin.com ([62.4.15.54]:42271 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726656AbeH2L6V (ORCPT ); Wed, 29 Aug 2018 07:58:21 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 8034C20795; Wed, 29 Aug 2018 10:02:41 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from windsurf (AAubervilliers-681-1-53-19.w90-88.abo.wanadoo.fr [90.88.170.19]) by mail.bootlin.com (Postfix) with ESMTPSA id 10BED206EE; Wed, 29 Aug 2018 10:02:31 +0200 (CEST) Date: Wed, 29 Aug 2018 10:02:29 +0200 From: Thomas Petazzoni To: Linus Walleij Cc: aditya@kobol.io, "thierry.reding@gmail.com" , Thomas Petazzoni , Jason Cooper , "open list:GPIO SUBSYSTEM" , Richard Genoud , Gregory Clement , gauthier@kobol.io, Alban Browaeys , linux-pwm@vger.kernel.org, "linux-kernel@vger.kernel.org" , dennis@ausil.us, Ralph Sennhauser , Andrew Lunn Subject: Re: [PATCH RESEND 1/2] gpio: mvebu: Add support for multiple PWM lines per GPIO chip Message-ID: <20180829100229.7566e0db@windsurf> In-Reply-To: References: <1533522556-55055-1-git-send-email-aditya@kobol.io> <1533522556-55055-2-git-send-email-aditya@kobol.io> Organization: Bootlin (formerly Free Electrons) X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Linus, On Wed, 29 Aug 2018 09:54:04 +0200, Linus Walleij wrote: > On Mon, Aug 6, 2018 at 4:31 AM Aditya Prayoga wrote: > > > Allow more than 1 PWM request (eg. PWM fan) on the same GPIO chip. > > > > based on initial work on LK4.4 by Alban Browaeys. > > URL: https://github.com/helios-4/linux-marvell/commit/743ae97 > > [Aditya Prayoga: forward port, cleanup] > > Signed-off-by: Aditya Prayoga > > It would be awesome to get some feedback from the MVEBU maintainers > on this patch set. > > Who are most active on Marvell stuff these days? Thomas? Andrew Lunn did the initial support for PWM in this driver, and he outlined in the commit log the limitation of his first implementation: However, there are only two sets of PWM configuration registers for all the GPIO lines. This driver simply allows a single GPIO line per GPIO chip of 32 lines to be used as a PWM. Attempts to use more return EBUSY. Andrew, perhaps you could review the patch posted by Aditya, since you already looked at PWM support on mvebu platforms ? Thanks! Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com